From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id CC4A81B1B5 for ; Wed, 10 Jan 2018 23:46:54 +0100 (CET) Received: by mail-pg0-f43.google.com with SMTP id r2so864916pgq.13 for ; Wed, 10 Jan 2018 14:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HaHMnGyFoc4ITojFGNaKhCHejk1kq6KfgY4B+qjkgAM=; b=RPTF3W+IZ4Dr8JAPQrOmjK90lrSIvfUFDZle0ZK4a3/N7PXkmOTQUjLVO2zGoSGxyp lzTs/47wnjHzWtrNelvJs8KQkdF2sIpi+wCn2FDoqe2uKxZONxkgB5FFF0nIGDYFdp57 iFvFnREfdQjR1yP5JFeT/1MQ4LvsuDZfNviMJBMwEaeS9ayVGRbAnFZIZFuPlBDwiyTn 5pPILbO4dV8Mm7aCQ7qwuvT5vxDz3MvPYfez9K0RgI09O1X4yrZPrsBbmYn6C7sceulL ZPYkve2fmL3QgVcdeTRamC3fF7OxXExQz30P80xhQJ+DtW4EZGQgUF3oklpZFstdbPtw Gr+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HaHMnGyFoc4ITojFGNaKhCHejk1kq6KfgY4B+qjkgAM=; b=VmV6/CMmY5M6eStNQZos8XcfMx49ovmeuUJTaE5RUBbo4vUCVGQcbPRqjiVBfZ9UbV WWOZwmqO85NvX5hUVdlpcughTXynkkxgwKJts4aOrBo5yqMQA3JLjtFpsP2hNRRODDSR BlqC965WoHF2HazxtKJQJKBlL8aSKTxLC+30jrk4U28W6IfH4Zvdauy9lsg4na9xphgF VMrsW9i4NnkTReWbgXOndKUVkYyNGcVb9N3MUZjmlTmuQYsQH0hmmYP2Za2ppOM0PPWO 7b2k1bfYZ3PGg2q2Kjf7blQP+jLbw681r9L+twk/qv11B7m6cweas2xylIWpK+aUquXe UwpQ== X-Gm-Message-State: AKGB3mLp7frN5C4/1lkf/7dPceOPZcAXYGTwdL85zcy37P85euhYXoFL Kzo9zqaL0t08FXME8MPRnWlXnlHl3EekVeEssdbKtw== X-Google-Smtp-Source: ACJfBosBRNezXoXCrDTWzV90GRnFbyLfx3k5P6yIUstSV3zMYnIliHEQOl1TiDQ7TmlYmFeY4jdQKjw2Z0TzHsE0bX8= X-Received: by 10.124.24.6 with SMTP id a6mr12090381plz.390.1515624413823; Wed, 10 Jan 2018 14:46:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.133.130 with HTTP; Wed, 10 Jan 2018 14:46:53 -0800 (PST) In-Reply-To: References: <20180103142923.3528-1-olivier.matz@6wind.com> <94479800C636CB44BD422CB454846E01320873A8@SHSMSX101.ccr.corp.intel.com> From: Igor Ryzhov Date: Thu, 11 Jan 2018 01:46:53 +0300 Message-ID: To: "Zhang, Helin" Cc: "Xing, Beilei" , Olivier Matz , "dev@dpdk.org" , "Wu, Jingjing" , "stable@dpdk.org" , Laurent Hardy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 22:46:55 -0000 Hello everyone. It's sad that my comments were unanswered. I'm ok with the first two =E2=80=93 they were mostly style-related. But I made an investigation on the third one and it is a bug. This is a description (from X710 datasheet) of flags sent to mac_address_write command: By bits: 0-7 =E2=80=93 Reserved 8 =E2=80=93 MAC_MAG_EN 9 =E2=80=93 LAA_WOL_PRESERVE 10-13 =E2=80=93 Reserved 14-15 =E2=80=93 Write type (00 =E2=80=93 Update LAA only, 01 =E2=80=93 Upda= te LAA and WOL, 10 =E2=80=93 Update port address, 11 =E2=80=93 Reserved, but used in Linux to enable mul= ticast magic packet wake up) Current code uses 0x3 flag, apparently trying to update LAA, WOL and port address, but it sets first two bits instead of last two. These bits are reserved, that's why it doesn't break anything. At the same time, last two bits are set to zero, and the command changes LAA address only =E2=80=93 it's enough to work in simple case. The last question =E2=80=93 which flag is correct to use =E2=80=93 01 (LAA = + WOL) or 11 (LAA + WOL + port). Linux driver uses the first one, and here is the patch to fix the issue: https://dpdk.org/dev/patchwork/patch/33524/ Best regards, Igor On Wed, Jan 10, 2018 at 4:57 PM, Zhang, Helin wrote= : > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei > > Sent: Thursday, January 4, 2018 1:39 PM > > To: Olivier Matz; dev@dpdk.org; Wu, Jingjing > > Cc: stable@dpdk.org; Laurent Hardy > > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary > address > > change > > > > > > > > > -----Original Message----- > > > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > > Sent: Wednesday, January 3, 2018 10:29 PM > > > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > > > Cc: stable@dpdk.org; Laurent Hardy > > > Subject: [PATCH] net/i40e: fix VSI MAC filter on primary address > > > change > > > > > > When primary address mac is changed, the mac filters were not updated > > > in the VSI with the new mac addr and incoming packets with this > > > destination address are dropped by the hardware filters. > > > > > > This patch removes the VSI mac filter for the previous mac address an= d > > > adds a new one for new mac address. > > > > > > Fixes: e18e01e92c29 ("i40e: support default MAC address setting") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Laurent Hardy > > > Signed-off-by: Olivier Matz > > > > Thanks for the fix. > > Acked-by: Beilei Xing > Applied to dpdk-next-net-intel, thanks! > > /Helin >