From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id B6D70A00E6
	for <public@inbox.dpdk.org>; Mon, 10 Jun 2019 13:23:50 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 398B51C014;
	Mon, 10 Jun 2019 13:23:49 +0200 (CEST)
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id ECBF41C012
 for <dev@dpdk.org>; Mon, 10 Jun 2019 13:23:47 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id m3so8798758wrv.2
 for <dev@dpdk.org>; Mon, 10 Jun 2019 04:23:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=nfware-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=DJblTJhy9h6kdFBLHYAeShzc/zPI1K15pzW5J5XLRVU=;
 b=QRYNgTQvV7vibY26mZdmOPuBT5HVvHttqigfe/CWxnvhOtN1ZKQs/u99Rbp4N4fUMZ
 TvQCOTK3m4zCrAT/UTNgFKrxkcJUQXnFZhdjZAxy3Lsg5+mKiE4U+3DmReJjshZFG28C
 JnyzPNmtltlv6+VFLPDgEli93T8mE9Ex3tR5NPDmwvVwWyVqgkiQZYhnA8iimD6LEPO+
 1VlCS3xkDK83M4oeqnjJqAtIZ/CzXO1i0S4OaaP4mco/0pqiblRPyGXa+y3E/ZKjx0fB
 VnPfmSVCm+xmbetAdvWJPldfW+tK6qiF5Y8uG3Xm/AJnQmLeZtsvUqCtecFYAfYgXsir
 O8tQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=DJblTJhy9h6kdFBLHYAeShzc/zPI1K15pzW5J5XLRVU=;
 b=cUmzK/RCdAhVlESpl19goLhVEVG51b+pTsuQ+8oqVVkoXhhMW3E9VE7cxx+0N5o6NL
 Li0HDmsHNNtIWwe3YaCr+NnM6BfBFTRITIXi9B52GkyVkyS6vTSxm8QW7FqHjGrp+K/E
 FYMR/y2JYDSpyC4L1jBsbGppSiiF5YkBx8PROofyrd9gxg5MQUv6+YxaV3PIW9sR1VRa
 5Pyy3wG+12AzktC0lqKogKAyRio3GK0CgHAGjVDq+87XMkqvvkGBGc1YcMqePAHJKbmN
 /8b4CGmjbm1PhArnuJGbk872kD2u3sq1AsRAIn5kx6kcardbGbzyeBh00EKPC0Edzaoz
 hRBQ==
X-Gm-Message-State: APjAAAUJIDp7bEfNEOBK6aCS3CbQtImBcMsV6N4GdgnZCdFinXU4TbPl
 ZuTGKPDJFIGlnDxgglmb6xIUkBfLA7FZZpBAyLntwQ==
X-Google-Smtp-Source: APXvYqwnuo1GbrnP+p3vw9XQzvFiYjVqiKDNMWRZsX8ndCtE9cMYtMTcvg2B0hbcnbKUFbGiVElA2QPMS/16rs+YQJA=
X-Received: by 2002:a5d:554b:: with SMTP id g11mr29638658wrw.10.1560165827666; 
 Mon, 10 Jun 2019 04:23:47 -0700 (PDT)
MIME-Version: 1.0
References: <20190610082552.79083-1-iryzhov@nfware.com>
 <20190610093717.GA1925@bricha3-MOBL.ger.corp.intel.com>
 <CAF+s_Fz2xBQNZjS-eBA1sUi2WbePvJSMt9k8YAb5a8qmwWGFoA@mail.gmail.com>
 <20190610111203.GA1930@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <20190610111203.GA1930@bricha3-MOBL.ger.corp.intel.com>
From: Igor Ryzhov <iryzhov@nfware.com>
Date: Mon, 10 Jun 2019 14:23:36 +0300
Message-ID: <CAF+s_FxM=3+OfpScz_CgkjmKtsYQwU1gYhE=GWi1TR7DP8Y_Qg@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks for the clarification, I get it now.
I will send v2 later today.

On Mon, Jun 10, 2019 at 2:12 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:

> On Mon, Jun 10, 2019 at 02:04:26PM +0300, Igor Ryzhov wrote:
> >    Bruce,
> >    From my understanding, kernel_dir is a directory with kernel headers
> >    needed
> >    for modules building.
>
> Right now, yes. I'd suggest that we change that to the actual kernel
> modules directory, and we get both the build directory and the install
> directory based off that.
>
> >    When it's formed automatically, yes, it will be
> >    "/lib/modules/version/build" and we can get installation directory by
> >    stripping
> >    "/build".
>
> Well, I'd suggest if we query the value automatically we don't both adding
> the build, and just add that later when building the modules, i.e.
> kernel_dir should always be the the base directory without "build" on it.
>
> >  But when it's set manually, it can be set to, for example,
> >    "/usr/src/linux-headers-version", and build will be successful, but we
> >    won't be
> >    able to strip "/build" as there is no "/build".
> >    Which path should be used for installation in cross-compile case, when
> >    the
> >    kernel_dir is set manually?
>
> The stripping "build" was just a suggestion to allow the value to be
> specified either with or without the "build/" suffix and have things work.
> For the paths specified in the cross-compile case, my thinking was that we
> would:
> * build using <kernel_dir>/build
> * install to <kernel_dir>/extra/dpdk
>
> as with the non-cross-compile case.
>
> /Bruce
>
>