From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f193.google.com (mail-ua0-f193.google.com [209.85.217.193]) by dpdk.org (Postfix) with ESMTP id 9C3D0558C for ; Thu, 1 Dec 2016 10:52:45 +0100 (CET) Received: by mail-ua0-f193.google.com with SMTP id 20so20545899uak.0 for ; Thu, 01 Dec 2016 01:52:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Z99tJiJVr84cdWWag4gWl1iDpnQ5g14igHi1rpPjI7w=; b=C/TB1DMgPawJczabL+BY1fYRuAM908WAFN4c2QOgwWap4UNjHoTCRJOXdQOJR4xlxE q0teUe/0W2+uh1cqPLBrNzsU9kCHYdo6ydJ9FaP6k/CSbnaPr11DCaplRzyABLJqwtOk 71TH5LOfyxfdB8+UAkd8tV7/9YyXGHpFQx5qUO72tLaU4LEU3T5MUQlkVPXT1ldFkGcH P/NdjMGoI/oabxDDRrzfzclvlck/PKjh6gYrMDIHVMbFxOaeteMEOBW9Ptv8a88aWYdT mHJ9iZp4mY4Rc/nqXQBbJtN0y25RUemUms55y8qU3RGJ1VWYeSrQT5Kv2NnRX56Q3E3z RYDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Z99tJiJVr84cdWWag4gWl1iDpnQ5g14igHi1rpPjI7w=; b=j5RVryt5uS2OWXKa9PWj6lQXJdy6vtoTBx+T6uRBrT5s93qSO0MmI64CV1J4kRPhiJ VPeFl8T5SAUha4AC8ove1yiF3xP/9+Ez91uO0g7Bwo1Q3TJZ1UoPoXaXyEK9hYHbeZ9I F07lMGeHUAxDF/NbnIjCcItf+I5ZldvlI3WSRogA/ZN5erxvp3yI35ilZmvmhl7PEd6h 5gh3EeK0DS02ckgSKgp4ERlZTnWosrlLNbFM+Tc29uKjBshP+0VG4SeO6QLjgylUtzaX EsqHxak2PrIWHcn/q996L/XXR16tCIJT4nzBPULOY14Im/6d6FuDCtPg3Ic4ZsDWK8Tv Z5ZQ== X-Gm-Message-State: AKaTC02DRE3hM4Y687NAU1Bngz8DHFUaY7zHLDvtGbaS3Z9AiQqHT5ff3htskwxldjh0faoEn4i4rKd3Zjp+Vg== X-Received: by 10.159.40.135 with SMTP id d7mr22608701uad.98.1480585965002; Thu, 01 Dec 2016 01:52:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.80.111 with HTTP; Thu, 1 Dec 2016 01:52:44 -0800 (PST) X-Originating-IP: [95.182.74.2] In-Reply-To: <1479990879-26598-1-git-send-email-iryzhov@nfware.com> References: <1479990879-26598-1-git-send-email-iryzhov@nfware.com> From: Igor Ryzhov Date: Thu, 1 Dec 2016 12:52:44 +0300 Message-ID: To: "dev@dpdk.org" Cc: Helin Zhang , jingjing.wu@intel.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC PATCH] i40e: fix setting of default MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 09:52:45 -0000 Ping. On Thu, Nov 24, 2016 at 3:34 PM, Igor Ryzhov wrote: > While testing X710 cards in our lab I found that setting of default MAC > address > doesn't work correctly for i40e driver. I compared DPDK driver > implementation > with Linux driver implementation and found that a lot of code is lost in > DPDK. > I tried to make DPDK implementation similar to Linux implementation and i= t > worked for me =E2=80=93 now everything is working. But I'm not sure that = my > changes are > correct so, please, maintainers, check the patch very careful. > > Signed-off-by: Igor Ryzhov > --- > drivers/net/i40e/i40e_ethdev.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ > ethdev.c > index 67778ba..b73f9c8 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -9694,6 +9694,7 @@ static int i40e_get_eeprom(struct rte_eth_dev *dev, > static void i40e_set_default_mac_addr(struct rte_eth_dev *dev, > struct ether_addr *mac_addr) > { > + struct i40e_vsi *vsi =3D I40E_DEV_PRIVATE_TO_MAIN_VSI( > dev->data->dev_private); > struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev-> > data->dev_private); > > if (!is_valid_assigned_ether_addr(mac_addr)) { > @@ -9701,8 +9702,33 @@ static void i40e_set_default_mac_addr(struct > rte_eth_dev *dev, > return; > } > > - /* Flags: 0x3 updates port address */ > - i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes, NULL); > + i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL, > mac_addr->addr_bytes, NULL); > + > + if (!memcmp(&dev->data->mac_addrs[0].addr_bytes, hw->mac.addr, > ETH_ADDR_LEN)) { > + struct i40e_aqc_remove_macvlan_element_data element; > + > + memset(&element, 0, sizeof(element)); > + memcpy(element.mac_addr, &dev->data->mac_addrs[0].addr_by= tes, > ETH_ADDR_LEN); > + element.flags =3D I40E_AQC_MACVLAN_DEL_PERFECT_MATCH; > + i40e_aq_remove_macvlan(hw, vsi->seid, &element, 1, NULL); > + } else { > + i40e_vsi_delete_mac(vsi, &dev->data->mac_addrs[0]); > + } > + > + if (!memcmp(mac_addr->addr_bytes, hw->mac.addr, ETH_ADDR_LEN)) { > + struct i40e_aqc_add_macvlan_element_data element; > + > + memset(&element, 0, sizeof(element)); > + memcpy(element.mac_addr, hw->mac.addr, ETH_ADDR_LEN); > + element.flags =3D CPU_TO_LE16(I40E_AQC_MACVLAN_ > ADD_PERFECT_MATCH); > + i40e_aq_add_macvlan(hw, vsi->seid, &element, 1, NULL); > + } else { > + struct i40e_mac_filter_info filter; > + > + memcpy(&filter.mac_addr, mac_addr, ETH_ADDR_LEN); > + filter.filter_type =3D RTE_MAC_PERFECT_MATCH; > + i40e_vsi_add_mac(vsi, &filter); > + } > } > > static int > -- > 2.6.4 > >