From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 066DE5F1B for ; Sat, 1 Dec 2018 12:13:05 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id x21-v6so4088478pln.9 for ; Sat, 01 Dec 2018 03:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JX5EYJVas0i/rLGNl8E1Sr2f51OFFFho31gkONr5ASU=; b=rPM9OfiqWfRbPrqA8wxgHu/nG5v7xUOtw0Gt6bfE5GvfnF8W6eVATMIaUhD4eZ+g2H kp/+pFYP46MGXsORK2gCnPBpCCtcJxlo8tJ37YEySXbmBYkQ61lmIKCGY7sHMYK8AmhH E4uujYURYrcPxja1VmN77CB0PnE8jSWE6JkBEmBLe6M355GkIJDC49h92OVBJ2XnoJEK l/KnV19T+CjXVx5z152QEB6k8v9p3EF0oC5cVMXD0fTZdrBaRnhFPODfNVtvF742Kd4g vCdzHv/2gubU5oDZMzVZxLFk/E0SHhARn/PoAGkLYD0U1bv8UvsyZkh6Km8X2lpbmT3x 8Gww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JX5EYJVas0i/rLGNl8E1Sr2f51OFFFho31gkONr5ASU=; b=hvCx6PytvLatDxOcuzRAeWceExFyK4Pm4VK6NJ8Xe0d2DkKzZvAJHE+hBVDddxjqxW BVy+hK/KbXxqe1WwEFnKr8p2lfiI5jwsZ5+jCVafpQ52O/XWpsFagSwxJsIHIPpRV0uO +rK7SzVL/W8Afa2Fn3e0wactqW/zczcXM2c8gCo/EGmdgLDI7dbWUke7b1qzkZXMoolr Yo+F39WyYO1aTDVt0/daFf0g/X3bbUImfc6Qh9UU65bOqfVijS9OuHWFL0COdh8znFYa rzQVHHEXs65Drhe33Y7HwAuMbOPAmM0hkHhSNpnAGibKBB5kMJiWSh87BuLNpALLy5+u 1xow== X-Gm-Message-State: AA+aEWbDwhzlbMIWFlS5fRXxqQu8lmc5b1deCJo3w4SQSerbD4e0nbIL S82LKn5ca1mRXmCcA+G+9QnJ6MGv3xhvo2iQZ+WB7OYX X-Google-Smtp-Source: AFSGD/WY8uj69g1Cs2toWRXSKM892EqMRqwLwi4sCkyObKw1eNxUxX0ST7DZbKYSy5uROcmQ6u/H/e0+cGOGWKWNnxs= X-Received: by 2002:a17:902:bf0c:: with SMTP id bi12mr8395092plb.0.1543662785080; Sat, 01 Dec 2018 03:13:05 -0800 (PST) MIME-Version: 1.0 References: <20181130192946.13732-1-iryzhov@nfware.com> <20181130194750.13870-1-iryzhov@nfware.com> <20181130153815.3be2f30b@xeon-e3> In-Reply-To: <20181130153815.3be2f30b@xeon-e3> From: Igor Ryzhov Date: Sat, 1 Dec 2018 14:12:54 +0300 Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2018 11:13:06 -0000 Hi Stephen, I also do not see the point of the current implementation of ethtool support. That's why I sent this patch =E2=80=93 it enables ethtool_ops for all devic= es, independent of the underlying driver. Right now only .get_link is supported, but I am thinking about implementation of a larger set of functions, using req/resp queue, like netdev_ops functions are working. Regarding the KNI itself, we use it as Linux mirror of physical port for: 1. Port configuration from Linux =E2=80=93 such functions as set_mac, chang= e_mtu, etc. And ethtool_ops will be used the same way. 2. Passing control-plane packets to Linux. Can virtio user be used the same way, as a mirror of physical port? Best regards, Igor On Sat, Dec 1, 2018 at 2:38 AM Stephen Hemminger wrote: > On Fri, 30 Nov 2018 22:47:50 +0300 > Igor Ryzhov wrote: > > > Current implementation of kni_ethtool_ops just uses corresponding > > ethtool_ops function of underlying driver for all functions except for > > .get_link. This commit sets kni->net_dev->ethtool_ops directly to the > > ethtool_ops of the corresponding driver. > > > > For unknown drivers (all but ixgbe and i40e) we still use > > kni_ethtool_ops with implemented .get_link function. > > > > Signed-off-by: Igor Ryzhov > > Why does KNI still support ethtool which: > 1. Only works on a subset of devices > 2. Requires a 3rd implmentation of the HW device (Linux, DPDK, and KNI) > > Then again why does KNI exist at all? What is missing from virtio user > which > is faster anyway. >