From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70B8AA04DB; Thu, 15 Oct 2020 09:56:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2266B1D905; Thu, 15 Oct 2020 09:56:07 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by dpdk.org (Postfix) with ESMTP id 6BE901C032 for ; Thu, 15 Oct 2020 09:56:05 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id h5so2187958wrv.7 for ; Thu, 15 Oct 2020 00:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=grgRrOnFEus2lq4AdeBf6xrBZ1JyyfLluoWKdNzYJnY=; b=XBood+pVpfRioLJogY6euMWKJFJyqxg8rDA1qO/BxpOA8QvaAPJKDM6m2L9s3pfPub 4p0CCBZhFqT8Zba5gVu7fXCvIpNjlHGe24iKeBN2MoGctSUgMrIv/bhOmBH+X9dWNjw2 Puso02sxkQdGROgt5sLdfc7Y17LQtbskqrIKhN0qk1jeZHSE+6fBqGcveYcEzbRMr8pJ x+miJ/nCBfPt8QST79E58gwgkGWOWCOFH8H0NKLHA47/RCLv5uziFrctGyKpHmt/qRC1 xxfhp4WPZEP+c3Oy6ljcuw/hIcMu4zKHZUHIAVBmnBzCwFiSEzIB1R5XmYKHCkRuU5oX g1fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=grgRrOnFEus2lq4AdeBf6xrBZ1JyyfLluoWKdNzYJnY=; b=h3rqklSq0XWIov4pcX+u6LgIMTIMbtq/q1cBJ+WByEqVRgHOoThdlOC6gWOQvd6g5p 70RsNOToHP8qU1Kq9KQASn0vPOzZT8gyrDe65P2S3ae3BrJnBITfU+BmQqn38idYlxwm B0FIK1JQwB8eW/bp8PRff9euiRS2eLaiPPKJGLsD+zQOehrtHTtptCWTTJd3JJym11eO lr0wQoB0V3pVcDIlWTAD5YFvNAR6MSyLa47PaE6RKBI7T+qtQv4NMhbRJ7aAtEDyqLkK SIf3TcwYSagS1p/rP4YwtWRyvpJQtcw7ohOPhneGwkwUdwDb+pAm8dLckxECmJvOrgwA Aocg== X-Gm-Message-State: AOAM531tR7Du4MMyC4x0KGTPKlCJrpHTcwMD8uLnLFjwe0rr7qZV9fPN SSmUfsQzTd/4sjywHUGw7hmIRRdMx7QZfrXb4YOJjw== X-Google-Smtp-Source: ABdhPJxTJe3vA2xoGX5rc+jv1QsnvM+6BC6iYzYwQSI4qeTbsQoyqNhIEUrkaaMDuKVQLi6VXRX/yLeNAXllovxf0R0= X-Received: by 2002:a5d:4cd1:: with SMTP id c17mr2818416wrt.109.1602748563951; Thu, 15 Oct 2020 00:56:03 -0700 (PDT) MIME-Version: 1.0 References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-2-ferruh.yigit@intel.com> <1735675.BVRYxsEZks@thomas> In-Reply-To: <1735675.BVRYxsEZks@thomas> From: Igor Ryzhov Date: Thu, 15 Oct 2020 10:55:53 +0300 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , Bruce Richardson , Ray Kinsella , Andrew Rybchenko , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Thanks for the slides, I checked the latest code and multicast/broadcast counters mostly look standardized. But mlx5 adds the "port" word to all its xstats names. I suppose you may be the right person to ask - is there any specific reason for this? On Wed, Oct 14, 2020 at 12:45 PM Thomas Monjalon wrote: > 14/10/2020 11:35, Igor Ryzhov: > > Hi Ferruh, > > > > As rte_eth_stats is going to be changed, is it possible to add new > counters > > there? > > For example, in/out multicast/broadcast packets. > > Good question. > In order to avoid redundancy, I prefer focusing on xstats > and plan deprecation of rte_eth_stats. > > The basic stats you are asking for should have standardized names > and reserved ids in xstats API. > Please see these slides: > https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf > > >