From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id C17EA1B3A6 for ; Mon, 3 Dec 2018 15:06:17 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id d72so5758441pga.9 for ; Mon, 03 Dec 2018 06:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fCbDTyWTSle+Znuce9i62krblXoIT8DChis77BByRs0=; b=lsynPaJ2YL3YBXcyEObHtzy84SYBb2f/fzQvB087kCYQEES7imWiEhNygGTgnVjU0Q LyydIHVUTj6BODCCXZ+KbBAvnhiOwBoCb86ty3qhGN8+9Ng391gXg4yUiPvp9WQ9bpmZ 3qO3rg8iEuIwi0AdYMSUPBKvAQLIEm+5iGjBbUrOUi3ZxzCkqnDeT0qimlRtoshUSx8j rCeCGZk2dJxpiUmijpnWH1Sn2JOK04dLyBPA/kicaGurYMdcrgzB7pwjZefi4UJMH16j bzRwSrYpzc+acuKjCEpgf/b1ss1U8Cq0zA0e6YfF2ihl5xv63P7Nl6hisouaHN/hOrTG oJ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fCbDTyWTSle+Znuce9i62krblXoIT8DChis77BByRs0=; b=um9tW10Sr38dysgTEOn/cBnDOG7zl8niUlJzlF/JGnz8Tvq1hQpLKQIpPo0oJ3dp+t 4bnoOThb0bk/peWPC+PhPkrCXBBTsCQ67AedeOSxnaKZD0XsXtrUGqZ8KWmqBt0BABXZ y8JiV828GAwJ81nYdHYtinON1TDn3YiVKqOWJXABqoPyzzKQ687+GRskenBHLLiRYD9Q XbRkGp5t/jh8pfVADsYvto+3Fiq4BYQV4Hs8rM8v78nuaH9cxhmUaDYD14Bvtz3nJ6Y+ dQmwVXp41Xeyftl+ndbTPGqXpEeNwJwK3wWLLnGzEHU5J0BT1EpLLRlnGSackl/1u6Wu eyaQ== X-Gm-Message-State: AA+aEWYIdwyyHLbGgIxCydwSiTWdF8FZCt7t51umHroxUL83zAJ+VXDr iNuaeviq8WEANxdee2Jj7CeT3lfKJ/yXumt9z3MXFQ== X-Google-Smtp-Source: AFSGD/Ufp68NQ8I+bfGc1bzzmbGkvY0ENfHp0Bz35iLM+2QvQ0yIxPuVUwrubbuUtRTkdb3a9xMnJmG9tzW+UchEq0E= X-Received: by 2002:a63:4b25:: with SMTP id y37mr13784748pga.181.1543845976862; Mon, 03 Dec 2018 06:06:16 -0800 (PST) MIME-Version: 1.0 References: <20181130192946.13732-1-iryzhov@nfware.com> <20181130194750.13870-1-iryzhov@nfware.com> <20181130153815.3be2f30b@xeon-e3> <7f929055-b55a-e839-9927-96787db88094@intel.com> In-Reply-To: <7f929055-b55a-e839-9927-96787db88094@intel.com> From: Igor Ryzhov Date: Mon, 3 Dec 2018 17:06:05 +0300 Message-ID: To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2018 14:06:18 -0000 Hi Ferruh, What about the patch? I also support dropping ethtool for ixgbe and i40e, but to save generic ethtool_ops with .get_link implementation, because it's an essential function that works correctly after proper implementation of carrier status that was merged into 18.11. Also, other ethtool operations may be implemented in a driver-independent way using the same concept as for netdev_ops. On Mon, Dec 3, 2018 at 4:09 PM Ferruh Yigit wrote: > On 11/30/2018 11:38 PM, Stephen Hemminger wrote: > > On Fri, 30 Nov 2018 22:47:50 +0300 > > Igor Ryzhov wrote: > > > >> Current implementation of kni_ethtool_ops just uses corresponding > >> ethtool_ops function of underlying driver for all functions except for > >> .get_link. This commit sets kni->net_dev->ethtool_ops directly to the > >> ethtool_ops of the corresponding driver. > >> > >> For unknown drivers (all but ixgbe and i40e) we still use > >> kni_ethtool_ops with implemented .get_link function. > >> > >> Signed-off-by: Igor Ryzhov > > > > Why does KNI still support ethtool which: > > 1. Only works on a subset of devices > > 2. Requires a 3rd implmentation of the HW device (Linux, DPDK, and KNI) > > +1 to drop ethtool support, last time we tried concern was anybody may be > using > it, perhaps we can try again. > > > > > Then again why does KNI exist at all? What is missing from virtio user > which > > is faster anyway. > > > >