From: Ariel Otilibili <ariel.otilibili@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Thomas Monjalon" <thomas@monjalon.net>,
"David Marchand" <david.marchand@redhat.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH 2/2] mempool: turn functions into single-exit ones
Date: Mon, 20 Jan 2025 11:05:07 +0100 [thread overview]
Message-ID: <CAF1zDgaWLj_1sKNvR7pX6Pf8-8pQTxDUm9keUkoqi83dhUc_GQ@mail.gmail.com> (raw)
In-Reply-To: <7524c0626a384d458ca64414ca1ff0e4@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
Hi Konstantin,
On Mon, Jan 20, 2025 at 12:44 AM Konstantin Ananyev <
konstantin.ananyev@huawei.com> wrote:
>
>
> > Some functions did not set rte_errno; for avoiding that, they are turned
> > into single-exit ones.
> >
> > Bugzilla ID: 1559
> > Signed-off-by: Ariel Otilibili <ariel.otilibili@6wind.com>
>
> But reading through public API comments none of these functions are
> expected to set rte_errno value.
> If rte_mempool_create_empty() forgets to set rte_errno, why it is not
> enough just to add missing one in rte_mempool_create_empty()?
>
Thanks for your feedback. Indeed, only rte_mempool_create_empty() returns
a rte_errno
https://doc.dpdk.org/api/rte__mempool_8h.html#a82e301ee33ed7a263ceb4582655dc3ea
I'll push a new series with this change.
Regards,
Ariel
[-- Attachment #2: Type: text/html, Size: 1405 bytes --]
next prev parent reply other threads:[~2025-01-20 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 17:46 [PATCH 0/2] mempool: add rte_errno, and " Ariel Otilibili
2025-01-19 17:46 ` [PATCH 1/2] mempool: add rte_errno in rte_mempool_set_ops_byname Ariel Otilibili
2025-01-19 17:46 ` [PATCH 2/2] mempool: turn functions into single-exit ones Ariel Otilibili
2025-01-19 23:44 ` Konstantin Ananyev
2025-01-20 10:05 ` Ariel Otilibili [this message]
2025-01-20 12:21 ` [PATCH v2 0/2] add rte_errno to rte_mempool_create_empty, and refactor Ariel Otilibili
2025-01-20 12:21 ` [PATCH v2 1/2] mempool: fix rte_errno in rte_mempool_create_empty Ariel Otilibili
2025-01-20 12:21 ` [PATCH v2 2/2] mempool: make rte_mempool_create_empty a single-exit Ariel Otilibili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF1zDgaWLj_1sKNvR7pX6Pf8-8pQTxDUm9keUkoqi83dhUc_GQ@mail.gmail.com \
--to=ariel.otilibili@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).