From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by dpdk.org (Postfix) with ESMTP id C91341B141 for ; Mon, 15 Apr 2019 11:44:24 +0200 (CEST) Received: by mail-yb1-f194.google.com with SMTP id u187so6124324ybg.11 for ; Mon, 15 Apr 2019 02:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HbEUKzGj/q8ouGrb+JzchIoCdtUIUW7skN5MEND3x+Q=; b=bXGVxY1Y91fCdyUr+gwW68RdT6aZAESL/SwkN/of2givz9/gm2jUna+BURR+1ihe0C W/dNcgbenv+UkFUJtCjumip3DpNCRknuvyaLKlxE0OqKvSrqbD+4YhAGs55cr3/uJ/R/ 0PPrpIOJJUCruooRkTcEcsjaPZJEjkK+ze55WKbujUFVffbXtVu77ZhRRi2bEI9NKkQ7 LwS7KpJJaa6gy9gqp5FnoYt5xryoM7uAHeB9Fxp8P7HbbdJTvwP/BvoytdSzj8aK+04u kL8sE+JlXVvNGihZ5U/vtEa7ez5zLePWVQrsNzuKx+esis+vHJEB2sqv0W1Ua0Qf2kpI USag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HbEUKzGj/q8ouGrb+JzchIoCdtUIUW7skN5MEND3x+Q=; b=SzPJPSTZGmhBvpY+ENByQ5GajcJF6g7HJeRp4gr5/LMDGHKLoxSIzYngPbMRESr6Dl f3FzuAPkqXIinkknQXMPMz78ZIMQgoBcxQ8neJg4oJPMtC5INuR+UV2vB7YkeiDmRd+b 2+66EwVMHnBxdIq9cQdvJZjtKjkkcPK59QBmx/ztPLU+ROuxT3etJW0+0W9S5FDpjlGE KsScUTOF02MDzFtHumRa05Eic+ggHiRlICSDw9ej2hyTlmVOD1EURN9cu2k+nF6bZ7Ek 6IhOWZGF4kdIyGBD1G/SbiJWfjURgTM1DcVcaJqil2b/IZeDvuY2vZCoLP1X9O06zI0M 0jEw== X-Gm-Message-State: APjAAAVhLAvd3drrGbpnf0b5Fso4nb06hQL5fhdS26F4VSXki8fLNFEO Spv9zpawTZq2jJfHWQryCeZdbU75w6lxUpx3l5U= X-Google-Smtp-Source: APXvYqzxrCHm+xtxUBVjKOWlayM0nCLX13D/NfwYJe+jtEPf3THWjQxYvjxHXFMHRAo/vgIkbYKbvH46JNPNT+oirlo= X-Received: by 2002:a25:9b43:: with SMTP id u3mr41856485ybo.24.1555321464207; Mon, 15 Apr 2019 02:44:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?UHJ6ZW15c8WCYXcgT8WCdGFyemV3c2tp?= Date: Mon, 15 Apr 2019 11:50:35 +0200 Message-ID: To: David Marchand Cc: Chas Williams <3chas3@gmail.com>, dev X-Mailman-Approved-At: Tue, 16 Apr 2019 18:14:55 +0200 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2019 09:44:25 -0000 Hello, Last week I attempted to migrate our system from DPDK 18.11.1 to current master with David's patches applied. I haven't been able to make it work correctly - probably due to other changes in master since 18.11.1 - so unfortunately I cannot confirm that David's patchset solves the issue (although from source code analysis it seems that array dimension has been fixed). I have already spent considerable time migrating from 17.11.5 to 18.11.1 and for the time being I need to focus on diagnosing the original issue in our system that led to discovery of invalid array dimension. I will try again when I have some more time. Best Regards, Przemys=C5=82aw O=C5=82tarzewski On Wed, Apr 10, 2019 at 2:56 PM David Marchand wrote: > On Wed, Apr 10, 2019 at 1:33 PM Przemys=C5=82aw O=C5=82tarzewski < > p.oltarzewski@gmail.com> wrote: > >> Hello David, >> >> I can merge these fixes and run our system using patched DPDK version. >> Then report back any problems / improvements I observe. I can also walk >> through source code changes and check for anything questionable. >> >> Unfortunately I lack deep enough understanding of DPDK source code to >> test these fixes comprehensively and I have been short on time recently = as >> well, so that's the best I can do right now. >> > > Please, be aware that other fixes have been already merged in master sinc= e > 18.11. > https://git.dpdk.org/dpdk/log/drivers/net/bonding > > I just sent the patchset that should fix your issue: > http://patchwork.dpdk.org/project/dpdk/list/?series=3D4240 > > > -- > David Marchand > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0B562A00E6 for ; Tue, 16 Apr 2019 18:14:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B6451B523; Tue, 16 Apr 2019 18:14:56 +0200 (CEST) Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by dpdk.org (Postfix) with ESMTP id C91341B141 for ; Mon, 15 Apr 2019 11:44:24 +0200 (CEST) Received: by mail-yb1-f194.google.com with SMTP id u187so6124324ybg.11 for ; Mon, 15 Apr 2019 02:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HbEUKzGj/q8ouGrb+JzchIoCdtUIUW7skN5MEND3x+Q=; b=bXGVxY1Y91fCdyUr+gwW68RdT6aZAESL/SwkN/of2givz9/gm2jUna+BURR+1ihe0C W/dNcgbenv+UkFUJtCjumip3DpNCRknuvyaLKlxE0OqKvSrqbD+4YhAGs55cr3/uJ/R/ 0PPrpIOJJUCruooRkTcEcsjaPZJEjkK+ze55WKbujUFVffbXtVu77ZhRRi2bEI9NKkQ7 LwS7KpJJaa6gy9gqp5FnoYt5xryoM7uAHeB9Fxp8P7HbbdJTvwP/BvoytdSzj8aK+04u kL8sE+JlXVvNGihZ5U/vtEa7ez5zLePWVQrsNzuKx+esis+vHJEB2sqv0W1Ua0Qf2kpI USag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HbEUKzGj/q8ouGrb+JzchIoCdtUIUW7skN5MEND3x+Q=; b=SzPJPSTZGmhBvpY+ENByQ5GajcJF6g7HJeRp4gr5/LMDGHKLoxSIzYngPbMRESr6Dl f3FzuAPkqXIinkknQXMPMz78ZIMQgoBcxQ8neJg4oJPMtC5INuR+UV2vB7YkeiDmRd+b 2+66EwVMHnBxdIq9cQdvJZjtKjkkcPK59QBmx/ztPLU+ROuxT3etJW0+0W9S5FDpjlGE KsScUTOF02MDzFtHumRa05Eic+ggHiRlICSDw9ej2hyTlmVOD1EURN9cu2k+nF6bZ7Ek 6IhOWZGF4kdIyGBD1G/SbiJWfjURgTM1DcVcaJqil2b/IZeDvuY2vZCoLP1X9O06zI0M 0jEw== X-Gm-Message-State: APjAAAVhLAvd3drrGbpnf0b5Fso4nb06hQL5fhdS26F4VSXki8fLNFEO Spv9zpawTZq2jJfHWQryCeZdbU75w6lxUpx3l5U= X-Google-Smtp-Source: APXvYqzxrCHm+xtxUBVjKOWlayM0nCLX13D/NfwYJe+jtEPf3THWjQxYvjxHXFMHRAo/vgIkbYKbvH46JNPNT+oirlo= X-Received: by 2002:a25:9b43:: with SMTP id u3mr41856485ybo.24.1555321464207; Mon, 15 Apr 2019 02:44:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?UHJ6ZW15c8WCYXcgT8WCdGFyemV3c2tp?= Date: Mon, 15 Apr 2019 11:50:35 +0200 Message-ID: To: David Marchand Cc: Chas Williams <3chas3@gmail.com>, dev X-Mailman-Approved-At: Tue, 16 Apr 2019 18:14:55 +0200 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415095035.X24l4Xy1zAzBB4wMminmfY2lqDwFgE7UUvZnvS1qFQM@z> Hello, Last week I attempted to migrate our system from DPDK 18.11.1 to current master with David's patches applied. I haven't been able to make it work correctly - probably due to other changes in master since 18.11.1 - so unfortunately I cannot confirm that David's patchset solves the issue (although from source code analysis it seems that array dimension has been fixed). I have already spent considerable time migrating from 17.11.5 to 18.11.1 and for the time being I need to focus on diagnosing the original issue in our system that led to discovery of invalid array dimension. I will try again when I have some more time. Best Regards, Przemys=C5=82aw O=C5=82tarzewski On Wed, Apr 10, 2019 at 2:56 PM David Marchand wrote: > On Wed, Apr 10, 2019 at 1:33 PM Przemys=C5=82aw O=C5=82tarzewski < > p.oltarzewski@gmail.com> wrote: > >> Hello David, >> >> I can merge these fixes and run our system using patched DPDK version. >> Then report back any problems / improvements I observe. I can also walk >> through source code changes and check for anything questionable. >> >> Unfortunately I lack deep enough understanding of DPDK source code to >> test these fixes comprehensively and I have been short on time recently = as >> well, so that's the best I can do right now. >> > > Please, be aware that other fixes have been already merged in master sinc= e > 18.11. > https://git.dpdk.org/dpdk/log/drivers/net/bonding > > I just sent the patchset that should fix your issue: > http://patchwork.dpdk.org/project/dpdk/list/?series=3D4240 > > > -- > David Marchand >