From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id 46747F72 for ; Mon, 8 May 2017 23:04:42 +0200 (CEST) Received: by mail-pg0-f66.google.com with SMTP id s62so12225242pgc.0 for ; Mon, 08 May 2017 14:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=C+8KvLw7ioxPJ4WQmAR1R9U0p6E75t6npWPVzgEYWXk=; b=r0C+E5zEzZsqD4MvYK9ozTHeu5b1YfWQe7LLvg7N0lH5uH6MWqJIUjkYgaSHS/DETr B/QkrCDSOZtIfbG8n07ZbZs1Www8yggsKCy5iyaHfbtcT9bxi52xQmEZpPO3xgTMGZXm JGP1aMzC34fZhNmJRore0e/5MAEPUPTZaYR2vxpw26qEkTNUWHM8SQrGguf5HOxfm9Sf ZuN4K5GuvWkLKyRoWjtAOEqTDgQ9r98l0BK4jJJuIXcdFIjWgDtGSpdmbszMyXEW9Z7l tigN0j+ZEJusbx0wUiVdSXMGZF1Co7HSKC22+FeN2Jg05POy2aPcgYCWBMC/ljECJwHJ Vbvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=C+8KvLw7ioxPJ4WQmAR1R9U0p6E75t6npWPVzgEYWXk=; b=n4sHTIlaKOdA1RNSo5/fgIFv8k8B9EDkmCnF7Or9wIrKSAuXJVs4MB0S4wrcvhEZmb hQSADM49zSKnNo0OfBKNRPakIDOYdchS/kSEiPGlNo0+KzxI1hBkj+qias6WRm4MpwAy aBlPkrr4IX7f6IQ89UBrIKP7xBisf8PGVD4XsrB0F2lL89Vti3QCIBtgiPQ+TN5Y6R/n VJWukbvJXLwEFEZ+A+8KU1IX8eKyufRsF/52T5nIoVeebZSNKVTKKYJv1FTPRWUpnBP4 uosO7lY/ikTYmRSanRRfjMqt5XZ4Sha+UUrP9TKDbUw0C3WoVcLbZhQOTcW5yz4b5qXR a71Q== X-Gm-Message-State: AN3rC/7x52JV6qVUXwaYhpen1z2FmHnbMZiQvMMktNyopdvihzIE9aeT WdKRutI//3vtnnYfQdJfjlIjj1eE4Q== X-Received: by 10.99.115.11 with SMTP id o11mr20504523pgc.10.1494277481450; Mon, 08 May 2017 14:04:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.180.42 with HTTP; Mon, 8 May 2017 14:04:41 -0700 (PDT) In-Reply-To: <2449201.3f6kNIuhA3@xps> References: <1493145557-17160-1-git-send-email-rkerur@gmail.com> <2449201.3f6kNIuhA3@xps> From: Ravi Kerur Date: Mon, 8 May 2017 14:04:41 -0700 Message-ID: To: Thomas Monjalon Cc: "dev@dpdk.org" , "Ananyev, Konstantin" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] doc: Merge l3fwd and l3fwd-acl documentation files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 May 2017 21:04:42 -0000 On Sun, May 7, 2017 at 1:50 PM, Thomas Monjalon wrote: > Hi, > > 25/04/2017 20:39, Ravi Kerur: > > Merge relevant contents of l3fwd and l3fwd-acl documentation. > > Modify l3fwd document with ACL specific information. > > Remove l3fwd-acl documentation file. > > > > Signed-off-by: Ravi Kerur > > --- > > doc/guides/sample_app_ug/img/ipv4_hash_rule.svg | 158 +++++++++ > > doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg | 139 ++++++++ > > doc/guides/sample_app_ug/index.rst | 1 - > > doc/guides/sample_app_ug/l3_forward.rst | 326 > ++++++++++++++++- > > .../sample_app_ug/l3_forward_access_ctrl.rst | 385 > --------------------- > > 5 files changed, 614 insertions(+), 395 deletions(-) > > create mode 100644 doc/guides/sample_app_ug/img/ipv4_hash_rule.svg > > create mode 100644 doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg > > delete mode 100644 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst > > I've not looked at the content. > I just do not understand why a patch for merging content is adding > some new files. > Moreover, these SVG files contains some binary PNG. > Please send only some source files. > Thanks John and Thomas for review. We have created two new ".svg" files illustrating an example for LPM and Exact Match rules and hence they are reflected in the patch. I have created .svg files directly from inkscape and they now contain only html. I have sent 'v2', please review it and let me know if additional changes are required.