From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-ob0-f171.google.com (mail-ob0-f171.google.com
 [209.85.214.171]) by dpdk.org (Postfix) with ESMTP id 4C01F7F1C
 for <dev@dpdk.org>; Fri, 17 Apr 2015 00:08:51 +0200 (CEST)
Received: by oblw8 with SMTP id w8so54941217obl.0
 for <dev@dpdk.org>; Thu, 16 Apr 2015 15:08:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=ffk1XuQNRaX8N/Oj09l12QLr/VanGHSiwE1/K/FvIEs=;
 b=vOaWslba5b9ONv2Fy4l280bPGYUpT8hCHMHec5Pu7g/2xRAdNt1bwgnC/p1Zqr1vcc
 X60Lih8kRYIfxVy0x/X9ysueThu4LTW/9MnxTSwb/nxs2RVVAcyRkGBlv1PsgxDJ6oyE
 cREK3/PMs2UNdxlUq49Al0MUnliILiQ0i3rmypcXuVTMXr1dLy3PeWIEu2Fhl6daCJS+
 2qYcXym4KccmbrcEsaICYeLMLFvqrcdCmWqy1HzyW4wuKLuLH8vDHE1ZrazY4CzsZXfM
 V+txle25OCd/06DOf8OwnYhbVVDSFNfU9O0HMdPEa1HQA22FRuLpGjaj2NFZXU3A8LTP
 Y3kQ==
MIME-Version: 1.0
X-Received: by 10.202.220.135 with SMTP id t129mr22361517oig.115.1429222129693; 
 Thu, 16 Apr 2015 15:08:49 -0700 (PDT)
Received: by 10.202.179.6 with HTTP; Thu, 16 Apr 2015 15:08:49 -0700 (PDT)
In-Reply-To: <4780798.Fhdhc6hoDZ@xps13>
References: <1428608301-31033-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-3-git-send-email-rkerur@gmail.com>
 <4780798.Fhdhc6hoDZ@xps13>
Date: Thu, 16 Apr 2015 15:08:49 -0700
Message-ID: <CAFb4SLCt6HAnL7tb7HJB2HBvHPoMghkv-e-pCiK_EyjYB_p9ew@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Apr 2015 22:08:51 -0000

On Thu, Apr 16, 2015 at 1:24 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> Hi Ravi,
>
> I think this patch is too complex and move too many different things:
> - sysfs
> - mem_cfg
> - proc_type
> - application_usage
> Please split them up.
>
> I'm not sure the classification in eal_common_runtime.c and
> eal_common_system.c
> new file is clear.
>

I chose most system related functions (hugepages, lcore sockets, sysfs)
into eal_common_system.c file. Rest I moved them to eal_common_runtime.c
file for lack of better name. You want more fine grained control and divide
them into 4 files??

>
> 2015-04-09 12:40, Ravi Kerur:
> > +     mem_config = (struct rte_mem_config *) mmap(NULL,
> sizeof(*mem_config),
>
> Why this cast is needed?
>

Linux has it, BSD doesn't. I just chose Linux version.