From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f41.google.com (mail-oi0-f41.google.com [209.85.218.41]) by dpdk.org (Postfix) with ESMTP id CB12A9A81 for ; Fri, 17 Apr 2015 00:11:04 +0200 (CEST) Received: by oiko83 with SMTP id o83so58116262oik.1 for ; Thu, 16 Apr 2015 15:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9uYv8TpYX16lpF/WhpTyno2hcH1v3XCVZSDPVNZlpTc=; b=GoLGCNyjjyrbO2rJPOBNUcVI4C1Lt9TxNKPpQUB6acKjz9w5CjffEoNQlK0gssDV/8 dIJOe8RSrXg7xFMu62SFo31y4V92OzcSGrw9iNO9/v/i3vm9cxchI5FRsWkIOgbegpzf fb+h4HrC23jVB4+baXyb5elaNijFpwWLZT7dcssZBxu3hFXyPhuYwZ5b4xAeA3KFnOZg OHDDmG+egKdKu0VG6C0lt9potu0Js0hjL107MYIDxnAv5tddPZ4ViNaFw7IwQzOMCP3p EG5F5pIOAuWx40vaSkne8S6jpUriyixd0iGLssJv5CcudhPkAitNFf3tjp6rKBzYMUYI ILTA== MIME-Version: 1.0 X-Received: by 10.60.54.37 with SMTP id g5mr27656397oep.43.1429222264333; Thu, 16 Apr 2015 15:11:04 -0700 (PDT) Received: by 10.202.179.6 with HTTP; Thu, 16 Apr 2015 15:11:04 -0700 (PDT) In-Reply-To: <2134052.2sEotUrNoM@xps13> References: <1428608301-31033-1-git-send-email-rkerur@gmail.com> <1428608412-31191-1-git-send-email-rkerur@gmail.com> <1428608412-31191-5-git-send-email-rkerur@gmail.com> <2134052.2sEotUrNoM@xps13> Date: Thu, 16 Apr 2015 15:11:04 -0700 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 22:11:05 -0000 On Thu, Apr 16, 2015 at 1:46 AM, Thomas Monjalon wrote: > 2015-04-09 12:40, Ravi Kerur: > > Changes in v5 > > Rebase to latest code. > > > > Changes in v4 > > Removed extern declaration of eal_tsc_resolution_hz, > > instead provided _set_ API. > > Make set_tsc_freq_from_clock as wrapper function for BSD. > > > > Changes in v3 > > Changed subject to be more explicit on file name inclusion. > > > > Changes in v2 > > Use common function name set_tsc_freq_from_sysctl for BSD and Linux. > > Update comments about its actuality in function declaration. > > > > Changes in v1 > > Move common functions in eal_timer.c to librte_eal/common/ > > eal_common_timer.c file. > > > > Following functions are moved to eal_common_timer.c file > > > > void rte_delay_us(unsigned us); > > uint64_t rte_get_tsc_hz(void); > > static void set_tsc_freq_fallback(void); > > void set_tsc_freq(void); > > > > Makefile changes to reflect new file added. > > Fix checkpatch warnings and errors. > > > > Signed-off-by: Ravi Kerur > > Seems good. > Acked-by: Thomas Monjalon > > Minor nit, a blank line is missing: > Will fix this in next version. > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > DAMAGE. > > + */ > > +#include >