From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67])
 by dpdk.org (Postfix) with ESMTP id C49D72C35
 for <dev@dpdk.org>; Tue,  7 Mar 2017 00:16:43 +0100 (CET)
Received: by mail-pg0-f67.google.com with SMTP id b5so4191266pgg.1
 for <dev@dpdk.org>; Mon, 06 Mar 2017 15:16:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=VZLfPmdALEYN03/DEe8NDMaGxzAPfWwCZKvI7Gt7tAI=;
 b=Kz8bC+wDSnBBlc9yu6jvIk3rq6z+sbDClBBl21G26aYZLswf6asKPld45X/8tbKTWJ
 zFkjbA30oClf9ye95Cu9aEIVDPu2bl0wswHBR3P5tZrFk001UhRfaW5Ad+7B2FVg3D+Z
 wtiOUMdD4lxYQ/QdA10R0s05rCAQvOLyj4zv6UH6fwJJoyWGQeKEKla7u1oxA4X9EQjy
 4CldcM29Bdifl0qU2i0Bs6VSE8BSSdbMf1kv+C/965AbAVD2oHDNanP55tgTc/PBTMrl
 1npfgpsl/rGxWTWsfJ8OxdHwUzSs3/QLdqz/s9Z+gj+YS5TLTZFN8kYneMqrI0PzGd+f
 rk9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=VZLfPmdALEYN03/DEe8NDMaGxzAPfWwCZKvI7Gt7tAI=;
 b=ILRA24xVLhSooOZmTrV+5dzd/YekbXtKai6nXCQxB0zM0QSKcLM0498xdOKdYamKoW
 LgN9IKMettJLiHlQ12ziP8VSCOhjnttnAqEh0JKXCESA7hDCwehb2XlGOxZlbT2eUoT0
 RdFFJX996/sHZI8zUakDxA164T0F1Gy5L3g5iZNXiaQw88dKciR+q/NpteTr/hZ6UKyN
 S4zJzSatU/hVWWmu4yigW9Hjx9AND50wGPCdcCs6rYeRviXtPNc1PkzS31dx1loFdtLP
 Pt7+taszM/Uiei5b+EQMHqP9V6fs/aMNNofBUJTvBbs8qcrLR5+T+QhFPL3NFAgQKL33
 GFmA==
X-Gm-Message-State: AMke39lLEWU+IQ7XxUcC9b1d5w96PdwyxIgR9zmZELtQ1blgLfZnksQLmSwu8CN5Lwp4fZoU4pBqUNkBMjZLjw==
X-Received: by 10.99.114.66 with SMTP id c2mr22973901pgn.4.1488842203068; Mon,
 06 Mar 2017 15:16:43 -0800 (PST)
MIME-Version: 1.0
Received: by 10.100.128.202 with HTTP; Mon, 6 Mar 2017 15:16:42 -0800 (PST)
In-Reply-To: <20170306084620.5bb094b5@xeon-e3>
References: <1488660259-6228-1-git-send-email-rkerur@gmail.com>
 <1488660259-6228-3-git-send-email-rkerur@gmail.com>
 <20170306084620.5bb094b5@xeon-e3>
From: Ravi Kerur <rkerur@gmail.com>
Date: Mon, 6 Mar 2017 15:16:42 -0800
Message-ID: <CAFb4SLDNf03Q6v7rAubVJdJRkrNbNW=KjPQHXw9Czqz-22J9rw@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, 
 Bruce Richardson <bruce.richardson@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [v3 2/3] LPM config file read option.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Mar 2017 23:16:44 -0000

Sure Stephen will make the changes.

On Mon, Mar 6, 2017 at 8:46 AM, Stephen Hemminger <
stephen@networkplumber.org> wrote:

> On Sat,  4 Mar 2017 12:44:18 -0800
> Ravi Kerur <rkerur@gmail.com> wrote:
>
> > +/* Bypass comment and empty lines */
> > +static inline int
> > +is_bypass_line(char *buff)
> > +{
> > +     int i = 0;
> > +
> > +     /* comment line */
> > +     if (buff[0] == COMMENT_LEAD_CHAR)
> > +             return 1;
> > +     /* empty line */
> > +     while (buff[i] != '\0') {
> > +             if (!isspace(buff[i]))
> > +                     return 0;
> > +             i++;
> > +     }
> > +     return 1;
> > +}
>
> This is not performance crtitical should not be inline.
> The argument is never modified and therefore should be "const char *buff"
>