From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by dpdk.org (Postfix) with ESMTP id 6ED1858EF for ; Fri, 17 Apr 2015 00:22:35 +0200 (CEST) Received: by oift201 with SMTP id t201so59912756oif.3 for ; Thu, 16 Apr 2015 15:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=fJfNwf+/QcVADP0ELrfzhPAt5oXcBCG35PPmzdMUT6Q=; b=RknqJUa8bCvk+ritlA7EzMgJSDB71o+INS8r2uFuGviINFGKj4n/9wrM5yx38n54jI M9NPq17YLge3r/g3zmLUBKzM+p+YHiCzE6H/d46X3oK6NsE2iGBze7P3qts3hpDzHeM3 gEUeJf9nU0ElVJmkuA2Ij0/ZSJ4pr5oZuoUcFr0BJogKynSGJnskxA/i3tpW6hnG94+1 RDp/kw9uu+dptjxktOLhJE/tOvBH6XRJyBb3AzPqmZ2+AyjNeituobPABkPgkn34Bmw6 KCDFQhjfv0RVYDL1WqewrOOGMwuDqr3o8kjytpDfhJmd6a8IQdpy1xGzDJS2xDY3QE32 87zg== MIME-Version: 1.0 X-Received: by 10.60.70.40 with SMTP id j8mr28266322oeu.59.1429222954974; Thu, 16 Apr 2015 15:22:34 -0700 (PDT) Received: by 10.202.179.6 with HTTP; Thu, 16 Apr 2015 15:22:34 -0700 (PDT) In-Reply-To: References: <1428608301-31033-1-git-send-email-rkerur@gmail.com> <1428608412-31191-1-git-send-email-rkerur@gmail.com> <1428608412-31191-3-git-send-email-rkerur@gmail.com> <4780798.Fhdhc6hoDZ@xps13> Date: Thu, 16 Apr 2015 15:22:34 -0700 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 22:22:35 -0000 Thomas, Thanks for the review so far, I will make necessary changes and send out v6. Thanks, Ravi On Thu, Apr 16, 2015 at 3:08 PM, Ravi Kerur wrote: > > > On Thu, Apr 16, 2015 at 1:24 AM, Thomas Monjalon < > thomas.monjalon@6wind.com> wrote: > >> Hi Ravi, >> >> I think this patch is too complex and move too many different things: >> - sysfs >> - mem_cfg >> - proc_type >> - application_usage >> Please split them up. >> >> I'm not sure the classification in eal_common_runtime.c and >> eal_common_system.c >> new file is clear. >> > > I chose most system related functions (hugepages, lcore sockets, sysfs) > into eal_common_system.c file. Rest I moved them to eal_common_runtime.c > file for lack of better name. You want more fine grained control and divide > them into 4 files?? > >> >> 2015-04-09 12:40, Ravi Kerur: >> > + mem_config = (struct rte_mem_config *) mmap(NULL, >> sizeof(*mem_config), >> >> Why this cast is needed? >> > > Linux has it, BSD doesn't. I just chose Linux version. > >