From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) by dpdk.org (Postfix) with ESMTP id 1D8961B262 for ; Thu, 21 Dec 2017 13:37:26 +0100 (CET) Received: by mail-it0-f47.google.com with SMTP id 68so10676610ite.4 for ; Thu, 21 Dec 2017 04:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F37n0ygzEl8Q3FzC3533GD17XVwdIMv5OSMigljasWE=; b=kC9BVd/yrfekMePRyCLOP1HqRPjA1R7ah8XyxWYsahSoNL9e1GnKxQyUczSgGhNpBs eezGxdkaRCSZWIXb9VOjmPfbwemaaLQ8eqCwUJJdTIsaqdR3LbsMzW58q4vEV+vyOqZ3 kuRizThxlBCa5laHNoEdwUgMl07Wtbvv1vAJ2u+aW0cKrDIo4kFLoBybu8yQbfVNbMLk Ia3ma8pUhiuUnlxqWKkJEHqOwWoo4a75MiuMNqnbIDiVW/a9qZfGegnS+U9VbhOXWJD3 /rSRbPNrQyFEcHXeisQPohONEymSQB2FCeKhQFvDDtSwCaBdDYldC7DzqAQK8xAxRJhd 8iCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F37n0ygzEl8Q3FzC3533GD17XVwdIMv5OSMigljasWE=; b=msIKojxXCrcgZbpexXqcqRYa0asK4lHEAQfsK8uMWGcIJNAGGtvMG51gwkVXLby4pv rmaP9ol6mGtF43yejcXQWmaU6lZDj2eAFZ/I9DuZjmwiaOCkN5iQkt27g1hqLTkS98S0 lS1vPKYPmCULxGFbM2FQAQyznuaE3wOhK6ayF0XcyAevuShou8j768pdyUzuktunHFtF x0h7kAwArH12K0/pV3o+OHfvLgRC6cD4lU60u4A2Eco5Xxmk3IPqAp2lJZgKkQYbGkGq i88thugfaN2RqyP7YqYdA5E2JKKfVbZUoIOpHvJnO6WBs92Hunesde1zJId6N7VDAYTl ir+Q== X-Gm-Message-State: AKGB3mKiAtYD5IZC0yhTT+s+fQmha+xsVQHzVV2373TzG2VcF43jPpps fOc80XD6sL6wuDAcHq+S9Y2va5ZcOCNPqdYWevw= X-Google-Smtp-Source: ACJfBosKMtEcDx8Q15ZuJCHlDqfH4FI71E+ir50y6jAr1WtyBODO1Ar0/Hp7eB67Hzi2yBToejO80GIzV5zzEVsIVX8= X-Received: by 10.36.145.216 with SMTP id i207mr12620424ite.73.1513859846080; Thu, 21 Dec 2017 04:37:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.53.2 with HTTP; Thu, 21 Dec 2017 04:37:25 -0800 (PST) In-Reply-To: <1513823719-36066-2-git-send-email-qi.z.zhang@intel.com> References: <1513823719-36066-1-git-send-email-qi.z.zhang@intel.com> <1513823719-36066-2-git-send-email-qi.z.zhang@intel.com> From: Alex Rosenbaum Date: Thu, 21 Dec 2017 14:37:25 +0200 Message-ID: To: Qi Zhang Cc: adrien.mazarguil@6wind.com, DPDK , Declan Doherty Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC v2 1/5] ether: add flow action to redirect packet in a switch domain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 12:37:27 -0000 On Thu, Dec 21, 2017 at 4:35 AM, Qi Zhang wrote: > Add action RTE_FLOW_ACTION_TYPE_SWITCH_PORT, it can be used to redirect I guess the word "SWITCH" should be remove from commit message. you don't use it later in the patch. > > +Action: ``PORT`` > +^^^^^^^^^^^^^^^^ > + > +Redirect packets to an interface that connect to the same switch domain. > + > +The desitnation should be managed by a rte_ethdev instance, port_id is > +the identification of the destination. A typical use case is to define > +a flow that redirect packet to a interface that mananged by a Port > +Representor. A verbs would be better suited for an ACTION_TYPE. while ".._TYPE_PORT" is a nous. Probably ".._TYPE_REDIRECT" would better fit here. See man tc-mirred as referance: http://man7.org/linux/man-pages/man8/tc-mirred.8.html Do we want to distinguish between different destination type? The target might be a port (port_id) or potencial other destinations/queue. So maybe use ".._TYPE_REDIRECT_TO_PORT"? Anyway, I think you should remove the "same switch domain" from docs since there is no switch domain yet in DPDK. Lets let the PMD decided if this sucessed or fails, based on the target type and other HW limitations. Not just based on switch domain. PS: I agree switch domain needs to be introduced. I don't think port representor is the correct direction. Alex