From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-it0-f66.google.com (mail-it0-f66.google.com [209.85.214.66]) by dpdk.org (Postfix) with ESMTP id CE1702BF7; Thu, 23 Aug 2018 17:21:56 +0200 (CEST) Received: by mail-it0-f66.google.com with SMTP id 139-v6so8065399itf.0; Thu, 23 Aug 2018 08:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IivGrXJg8uWNSLBRQoQ5n0o1i9Bu+hqxsbB0Npn82iI=; b=N2n1pMJpOSvbTwXVGKCVcj5A0YFI7JHWhJFIXJU2C3gpFoCaXsaH2M6xmU/MiqPjJ1 hPsz7TzKk155gthGG6wVvVd+I+L2KUqXpbCU7q5Vu3UZ+Z0tDPC30dRrIB/zuHpIUo7l sUxlCrf/xK8hH0qSRYP5XOx5MuJ40Mwc2rBhtMZHDsMmBSaMQ3WZ9mRnaqoOQ3NWecnN bz8lTj0LCUieefM+T+9XDfl5xpQRPXHFHFmQR4aKRiNCjFfL87e+eB85DtHYNl4idKQI B0hRkiC7Mf4zPhWVNlr52tYtrZ7+QmasS6L4ylmqiPgZIplnrmni4D5+f3wufmzAVBFM 2Tlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IivGrXJg8uWNSLBRQoQ5n0o1i9Bu+hqxsbB0Npn82iI=; b=EARSJ1WcPue3QKB1KGFWv9V+tEjzkO5YI7/AO9LoE1lff6dK8mqM+RyFPQXUXlrhF7 R8JTiIve2XesnbvIdDmuvZ4GzksX7qdM5CKWJdVkW1gezL4Crkzues5J3HM3szVNvqB6 T255U99bt53IPWJ3ub/QuW5RxiokzsRtSWI5VLKu1TsfovHFjScLYjPUuMTvBPLarkwD /mKH0ZGNQ0/Omad6LPvIZs9eI2M+Atcms5CRwtIBqYDzhYqN2P7FxH0mtgJViBhf/MaM VhxFp0zMMPNe3otW0eoeP15aJFEg9MC2QZpLb4bikpCympZfv0OOFWlIg3FEFtOhfq9Z POOA== X-Gm-Message-State: AOUpUlEZks51e+WySFTB7GkmvGi0tX8gScsw4TIPnSKfbmuio0vjC6Gj B3L996yQun5fBP8K6+pUTn2IpKgokOJRZbZ6mTc= X-Google-Smtp-Source: AA+uWPxp2odxFrhEW+kIpQYxGGCDMfc4FYEMcpqVhfSYbmcxoXWl/yYPseIEAPh1v0CvJNeca1PsTnRkbPmek35ILFo= X-Received: by 2002:a02:10c6:: with SMTP id 189-v6mr53216035jay.54.1535037716194; Thu, 23 Aug 2018 08:21:56 -0700 (PDT) MIME-Version: 1.0 References: <1533129523-1407-1-git-send-email-radu.nicolau@intel.com> <0c16cb66-6ee4-ff2d-6d16-7a3fdd021b0c@intel.com> <11360076.HoYMhSRcrZ@xps> In-Reply-To: From: Chas Williams <3chas3@gmail.com> Date: Thu, 23 Aug 2018 11:21:45 -0400 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Chas Williams , dev@dpdk.org, Declan Doherty , Radu Nicolau , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 15:21:57 -0000 On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit wrote: > On 8/6/2018 4:50 PM, Chas Williams wrote: > > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon > wrote: > > > >> 02/08/2018 15:38, Doherty, Declan: > >>> On 01/08/2018 2:18 PM, Radu Nicolau wrote: > >>>> When a bonding port is stopped also stop and deactivate all slaves. > >>>> Otherwise slaves will be still listed as active. > >>>> > >>>> Fixes: 69bce062132b ("net/bonding: do not clear active slave count") > >>>> Cc: stable@dpdk.org > >>>> > >>>> Signed-off-by: Radu Nicolau > >>> > >>> Acked-by: Declan Doherty > >> > >> Waiting for opinion from the other bonding maintainer (Chas) > >> who started to review and has some doubts. > >> > > > > The slaves being listed as active is not a bug. If the slaves are not > > deactivated, then they should be considered activated. Previously, > > stopping the bonding PMD just reset the active slave count. That's > > not the right way to deactivate slaves. This was fixed by 69bce062132b. > > > > This patch is new behavior of explicitly deactivating the slaves when > > the bonding PMD is stopped. > > > > As I mentioned, I think this makes life difficult for those of us using > > an external state machine. However, that should probably be fixed > > differently then. > > > > > >> > >> Chas, please do you agree with Declan's ack? > >> > >> > >> > > Change the Fixes line. > > Hi Chas, > > Are you OK with the rest of the patch if Fixes line fixed? > If already have a proposed fixes line I can fix it while merging. > Yes, the rest of the patch is fine as long as the Fixes is correct. Try this: Fixes: 2efb58cbab6e ("bond: new link bonding library") And it's really new behavior. Perhaps Fixes: isn't quite right. The current code works fine with activated slaves existing outside of the stop/star. > > Thanks, > ferruh >