From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-io0-f173.google.com (mail-io0-f173.google.com [209.85.223.173]) by dpdk.org (Postfix) with ESMTP id 127C6A490 for ; Mon, 2 Apr 2018 15:57:14 +0200 (CEST) Received: by mail-io0-f173.google.com with SMTP id v13so17996725iob.6 for ; Mon, 02 Apr 2018 06:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=j4255Driq1Du2xSQ/Opy215DIMdHhJBBUbFdu5IV4Kk=; b=biCxkmfUtsXrK1BZOfFIcFmjrka7c/EDKEnmKfnHATcI2vO/R4RMEjQzQ4UPu65lKI g9aYc9icFEPEDs7Wm26paBT/LTMiWFk2LGHD+mPQ69Az6CSIOwIWLlgNYJNCkE3eJqsA iQUQZFu+AsoQ7HWWu0vjTwHjLdhKyBWng3DAtVC7j3fkV+7AgZWizHj+hOFGhC3ty9k7 IjHnjihXq4L1JfRQ3ly/HNjqXl3axRl8a5vOVTTMyztE79njbKwq9yftQW2x9fH7Ee/M VtHGFVBYFTCuMD+zKWXLXPtoAWUk0qsGgeRGjJICPrvydBBY4M8xVOsWx0I+2sWDWO4o gexg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=j4255Driq1Du2xSQ/Opy215DIMdHhJBBUbFdu5IV4Kk=; b=djT/A+u5J7qF2dcQH9bWIaDMSdfiMBw4R3m/Kb6xvGl0PZt4sLIZP9DXnwBt9HP/ou M5ZZD1HxZGZwptKs3kaw6iEpNbV4CeBdFIqlWjT1ZIPAJhk03gC4ihnMs/ZwOJo+eJOJ eNUX6DFG66pKiWecZ0Pmg3kEqlZJgcoISuvV4a/qDWhfnhFtJG51bf+yHKHLOgO0H7mL vz/+Jeee50dT+lkTxmADSOhPl70Be2hMOQOr3hSdM0oU58G1xzgCnOViWyyXs5WyLt8M ZWUrGu7Vp6aEFpmeUrgJzXS57dbC8U1PhtgTnbhhDRBUdazdDSrun/Sbi4Qs9QoyRwPu iMtQ== X-Gm-Message-State: ALQs6tB63VoBPWxyU8QhBDsoqeOJJmkgFA0KwUm8d+ooJ/ryuqIwda66 n9+7zsxCGI8R4rzueGxWVRGHx3wwbmp+AlUIu7o= X-Google-Smtp-Source: AIpwx4+lnC8M+FvojUQUwWYCvuSff6Vkj/waJb8yqGejmuEhGlmqE+IcfRo2UZjU7ZjwMmrWuGIUK7iVzo8JXTxtCPI= X-Received: by 10.107.222.1 with SMTP id v1mr8978724iog.155.1522677433368; Mon, 02 Apr 2018 06:57:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.2.8 with HTTP; Mon, 2 Apr 2018 06:57:12 -0700 (PDT) In-Reply-To: <039ED4275CED7440929022BC67E7061153177B93@SHSMSX103.ccr.corp.intel.com> References: <20180213225618.15693-1-3chas3@gmail.com> <039ED4275CED7440929022BC67E7061153177875@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E7061153177B93@SHSMSX103.ccr.corp.intel.com> From: Chas Williams <3chas3@gmail.com> Date: Mon, 2 Apr 2018 09:57:12 -0400 Message-ID: To: "Zhang, Qi Z" Cc: "Zhang, Helin" , "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Charles (Chas) Williams" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 13:57:14 -0000 On Mon, Apr 2, 2018 at 9:45 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Chas Williams [mailto:3chas3@gmail.com] >> Sent: Monday, April 2, 2018 9:38 PM >> To: Zhang, Qi Z >> Cc: Zhang, Helin ; dev@dpdk.org; Lu, Wenzhuo >> ; Ananyev, Konstantin >> ; Charles (Chas) Williams >> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on >> start >> >> On Mon, Apr 2, 2018 at 8:40 AM, Zhang, Qi Z wrote: >> > Hi Williams: >> > >> >> -----Original Message----- >> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams >> >> Sent: Saturday, March 31, 2018 1:22 AM >> >> To: Zhang, Helin >> >> Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, >> >> Konstantin ; Charles (Chas) Williams >> >> >> >> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link >> >> status on start >> >> >> >> On Fri, Mar 30, 2018 at 12:30 PM, Zhang, Helin >> >> >> >> wrote: >> >> > >> >> > >> >> >> -----Original Message----- >> >> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams >> >> >> Sent: Wednesday, February 14, 2018 6:56 AM >> >> >> To: dev@dpdk.org >> >> >> Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams >> >> >> Subject: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link >> >> >> status on start >> >> >> >> >> >> From: "Charles (Chas) Williams" >> >> >> >> >> >> dev->data->eth_link isn't updated until the first interrupt. If a >> >> >> link is carrier down, then this interrupt may never happen. >> >> >> Before we finished starting the PMD, call ixgbe_dev_link_update() >> >> >> to ensure we >> >> have a valid status. >> >> >> >> >> >> Signed-off-by: Chas Williams >> >> >> --- >> >> >> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++ >> >> >> 1 file changed, 4 insertions(+) >> >> >> >> >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> >> >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> >> >> index 37eb668..27d29dc 100644 >> >> >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> >> >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> >> >> @@ -2666,6 +2666,8 @@ ixgbe_dev_start(struct rte_eth_dev *dev) >> >> >> if (err) >> >> >> goto error; >> >> >> >> >> >> + ixgbe_dev_link_update(dev, 0); >> >> > It is called in rte_eth_dev_start() if lsc is not enabled, and it >> >> > is not needed here to avoid any duplication. >> >> > BTW, did you see any issue or just check the code? Thanks! >> >> >> >> Yes, I see an issue with bonding. If LSC is enabled, then >> >> link_status isn't set until the first interrupt to update the link >> >> status. If a link is down, this interrupt may never happen result in >> link_status being somewhat undefined. >> > >> > Is your issue only happened on VF? >> > For PF, I saw ixgbe_check_link is called at ixgbe_dev_start, so link status is >> assume be updated. >> > If you think it is just missed in VF, can you implemented this in the similar way >> as PF? >> >> No, I don't believe it's isolated to VF. ixgbe_check_link() doesn't update >> (atomically write) the dev->data->dev_link. After .dev_start() finishes, I need >> the link_status of the adapter to be set. > > I saw dev_link.link_status does be updated. > err = ixgbe_check_link(hw, &speed, &link_up, 0); > if (err) > goto error; > dev->data->dev_link.link_status = link_up; That doesn't fill in link_duplex, link_speed, or link_autoneg. 802.3ad requires that all the ports of the same bonding group have the same speed and duplex. I need to be able to check the speed and the duplex at least (and autoneg as well). > >> I can't wait until I hope the first >> interrupt has happened that would update >> dev->data->dev_link. How long would I wait? I don't really care if >> the link is down, >> or up, or whatever, but it can't be partially filled in. Bonding (in >> 802.3ad) wants the >> links to be similarly configured. >> >> > >> > Regards >> > Qi >> > >> >> >> >> > >> >> > /Helin >> >> > >> >> >> + >> >> >> skip_link_setup: >> >> >> >> >> >> if (rte_intr_allow_others(intr_handle)) { @@ -5033,6 +5035,8 >> >> >> @@ ixgbevf_dev_start(struct rte_eth_dev *dev) >> >> >> >> >> >> ixgbevf_dev_rxtx_start(dev); >> >> >> >> >> >> + ixgbevf_dev_link_update(dev, 0); >> >> >> + >> >> >> /* check and configure queue intr-vector mapping */ >> >> >> if (rte_intr_cap_multiple(intr_handle) && >> >> >> dev->data->dev_conf.intr_conf.rxq) { >> >> >> -- >> >> >> 2.9.5 >> >> >