From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-it0-f66.google.com (mail-it0-f66.google.com [209.85.214.66]) by dpdk.org (Postfix) with ESMTP id 574824CC0; Tue, 20 Mar 2018 15:42:11 +0100 (CET) Received: by mail-it0-f66.google.com with SMTP id e195-v6so2744765ita.5; Tue, 20 Mar 2018 07:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WivBEC/03elYrv/gap/tEJl0QF+OMPwhziddukSlHoQ=; b=HBeHc48uyQz4Rv8FTdJ6ZuRgO6Fl2f2XY5naiXJsO7k/NhF2nu0iihpQpqlvIzlq4Z eLO9BgSCc2TI7qOxSKbl6n+ElXkjX8EMisgFAArAeio0jTgayvTHCVOC/hZF3NSRs4f0 2BKzN3yz4umW03oQtLYYxSDBOnWzqn7uRw+By/GmegsnOUIet1N888SiyVYz73OYOYUl XfUnVk7vN/A9oBPtPTiyOg7iYWAXPAK+AZv7CsqdIRsdzDavVm73w+9r6PO2Z9oUOjh9 n2jXChrD9nyrR7PPz7ABetIIkR6WAZEhI1dBITIWDE1CGO6rwsLCzCaLnPKPT8CgWRz2 Rb+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WivBEC/03elYrv/gap/tEJl0QF+OMPwhziddukSlHoQ=; b=FNW/ocV1W3S/mXfGu94QReIjeoeD1KYvjViI/pFJdcoSKZ+6imxe2PcwiqkxdK8le/ c/YTtr73GKzgAlWODCrhpfdDP4+BcU4/58nXPDSr6DmJKa17jZcl9eDuxx1FYTnYhjej U5UCWYZzY8INevxCudbr245O6BCUoBINh8yi0DwiwwRG462wU1U7HhC5jn6MLnS6AYiT Y3oLymHLuv2JghuCd1W8oaBKylfiWOBPJzh9xrfEur62oRH2RIKDv2l6lQO1iqnZC3qm 5GC9ZDvB8TPDtDk+x1V43NtSQMnY74qnoU/fOEmgnSfQmKo1TTcB1FG0z3iNJF9izI7b yI/g== X-Gm-Message-State: AElRT7H10dDxfJVvWotHxhkaDBI8utzopfEFl2OApUv763k5045sD4z6 CRPeXLuCtfH4SClXMBOV+nuzPihPOdalI4n0Tl4= X-Google-Smtp-Source: AG47ELu4k9XZO0AtjxitWKwDoa7sXg6VgFac+cn1canMXgBf2xRyIc9qlC1cUAtzRr0tOE3erFwBtQ+b7qKFvja4Q9s= X-Received: by 2002:a24:4352:: with SMTP id s79-v6mr1894071itb.84.1521556930403; Tue, 20 Mar 2018 07:42:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.2.8 with HTTP; Tue, 20 Mar 2018 07:42:10 -0700 (PDT) In-Reply-To: References: <20180318014552.16703-1-3chas3@gmail.com> From: Chas Williams <3chas3@gmail.com> Date: Tue, 20 Mar 2018 10:42:10 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, skhare@vmware.com, Chas Williams , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 14:42:11 -0000 On Tue, Mar 20, 2018 at 10:12 AM, Ferruh Yigit wrote: > On 3/18/2018 1:45 AM, Chas Williams wrote: > > From: Chas Williams > > > > The vmxnet3 never attempts link speed negotiation. As a virtual device > > the link speed is vague at best. However, it is important for certain > > applications, like bonding, to see a consistent link_status. 802.3ad > > requires that only links of the same cost (link speed) be enslaved. > > Keeping the link status consistent in vmxnet3 avoids races with bonding > > enslavement. > > > > Author: Thomas Monjalon > > Date: Fri Jan 5 18:38:55 2018 +0100 > Didn't mean for this to be in the commit message. I will submit a v2. > > > > Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value") > > Cc: stable@dpdk.org > > There were a few more PMDs [1] they have been updated from FIXED to > AUTONEG with > above commit, do you think should we update them back to FIXED as well? > Same comments as above apply. link_autoneg implies that there is some sort of autonegotiation. Unless there is actually sort some of autonegotiating happening there isn't a reason to indicate it. > [1] > pcap > softnic > vmxnet3 > > > > > Signed-off-by: Chas Williams > > --- > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c > b/drivers/net/vmxnet3/vmxnet3_ethdev.c > > index 426008722..48a4d4f98 100644 > > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > > @@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev, > > link.link_status = ETH_LINK_UP; > > link.link_duplex = ETH_LINK_FULL_DUPLEX; > > link.link_speed = ETH_SPEED_NUM_10G; > > - link.link_autoneg = ETH_LINK_AUTONEG; > > + link.link_autoneg = ETH_LINK_FIXED; > > > > return rte_eth_linkstatus_set(dev, &link); > > } > > > >