From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-it0-f67.google.com (mail-it0-f67.google.com [209.85.214.67]) by dpdk.org (Postfix) with ESMTP id 04ED64F98 for ; Sun, 16 Sep 2018 18:02:36 +0200 (CEST) Received: by mail-it0-f67.google.com with SMTP id 139-v6so8086005itf.0 for ; Sun, 16 Sep 2018 09:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:sender:from:date:message-id :subject:to:cc; bh=X2LB4kbpjrzTdu9+paoQG+yaxCDtcFvvJoxPJx+VweE=; b=R6QcCclGju6fvObKHWIlzRZYO9hswheK4tfytWKex1hCD2aB5nacq+2oROj0xy4JfN OV8pe2JQT5I+23puHvpqVnrk+dpKGA5e0n5yoQFpln+NbIlJHr8vtIQJiT2U+aqhSWqO FTedekN2Uw8+Y6TAPX5CukaSTFa+oM0+9TgvItTJEoVWoqZCBBwtBzquoRlnzzHwBzyZ OxO0YIAS62RG+wWwB3c6eBnOz8iZ7FvScy1/glKgNle0XVc209mRxYcJk1EMlG7h+o+I AYmHHodtuk44aFv5juPUUrMDxrtDHq0Zyy93Qa5hyiKszk49B2ojJUl4o5E8dbNr1GJg tTuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:sender:from :date:message-id:subject:to:cc; bh=X2LB4kbpjrzTdu9+paoQG+yaxCDtcFvvJoxPJx+VweE=; b=I1z+dKseFG57f0gGtfMxHwMv7mCzb2HST0/3ihLd8kKudKhLa4efX/d6+hTNiyMrVr tWirT2mZIEsQJcyfBw23LK/w09e5BR1CYWnyq9gflfKFgjbSi3J5ffSAFVSCZQaNdB9i eZ46PcayXeP6IOwYbAmQg8zShATrrxDh6Li/oQUKl/Hpc4GOG2uAwSJIHtBDOTrkVoXA E3Z9jEMO87jyzjPHI2d4bSva0lirLY9ZMNZmmm8/rvxXndCBUibWdV0w3v6xk+979QBI 0f0vo8HbpF5o9Tgwx8tSs8yTl0drRUbepqi5KNwSQ5tPqj37NXP7n6/4YQKVXEY+NqnE v6dA== X-Gm-Message-State: APzg51DLEMSZWe41xFogSNuMhqcDa6WqFIyVxcj7ZfHJJgBzwMYU0T9r lr9zzI8TPEfoUocsBymA+MQzwYWmXTAYN0QGODM= X-Google-Smtp-Source: ANB0VdaZyfA35IxdttqctheXv9nQUn6PSSH7+LqjARi4Nm7TEmyL364g2gO4hNTyZ4s3OcSHkVfrsvu0bo+G1cGAYfw= X-Received: by 2002:a24:6b0d:: with SMTP id v13-v6mr10171672itc.16.1537113756195; Sun, 16 Sep 2018 09:02:36 -0700 (PDT) MIME-Version: 1.0 References: <1536976343-5548-1-git-send-email-jerry.lilijun@huawei.com> In-Reply-To: <1536976343-5548-1-git-send-email-jerry.lilijun@huawei.com> Sender: chasmosaurus@gmail.com X-Google-Sender-Delegation: chasmosaurus@gmail.com From: Chas Williams <3chas3@gmail.com> Date: Sun, 16 Sep 2018 12:02:24 -0400 X-Google-Sender-Auth: yIeo4mhOQvMnwa3FM67AtVVwfDY Message-ID: To: jerry.lilijun@huawei.com Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bonding: add QinQ packet xmit hash support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2018 16:02:37 -0000 I think this change already went in dpdk-next-net: commit 61e99d7e944885e8d625ded41b5877653e0b637e Author: Yunjian Wang Date: Tue Aug 7 16:10:46 2018 +0800 net/bonding: add support to match on 0x88A8 ethertype We assume VLAN ethtertype is 0x8100 in get_vlan_offset() function, but it could be 0x88A8 if QinQ is supported. Fixes: 06fe78b98ccd ("bond: add mode 6") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Chas Williams On Fri, Sep 14, 2018 at 9:52 PM Lilijun wrote: > > For QinQ packet with ether type 0x88a8, dpdk bond's xmit hash policy is > not worked to get the ip or port field. > > Signed-off-by: Lilijun > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 58f7377..4417422 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -37,7 +37,8 @@ > { > size_t vlan_offset = 0; > > - if (rte_cpu_to_be_16(ETHER_TYPE_VLAN) == *proto) { > + if (rte_cpu_to_be_16(ETHER_TYPE_VLAN) == *proto || > + rte_cpu_to_be_16(ETHER_TYPE_QINQ) == *proto) { > struct vlan_hdr *vlan_hdr = (struct vlan_hdr *)(eth_hdr + 1); > > vlan_offset = sizeof(struct vlan_hdr); > -- > 1.8.4.msysgit.0 > >