From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <3chas3@gmail.com>
Received: from mail-it0-f68.google.com (mail-it0-f68.google.com
[209.85.214.68]) by dpdk.org (Postfix) with ESMTP id 99EC81B149;
Mon, 6 Aug 2018 17:51:01 +0200 (CEST)
Received: by mail-it0-f68.google.com with SMTP id s7-v6so18049293itb.4;
Mon, 06 Aug 2018 08:51:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=0j2OQTAHbt3L04JNnp9pbHE2swxWtlTtYzGnDMPHfOg=;
b=qEr3lq1UX3WxR+urtoalk/ftJ97PwQEz985nuqaxhTFV0Bo6cbQuuCg9CXLNfB6d/j
S70SCSZp1tJhwOTU51Zsjau8jCn6bWpc9VYgOjByP29xabnObCVK2KB2x1EaOqBU5Af6
fSNzMkWQm58PRJiWoTcWwvjEvHM59mCL2NigJaFMTgxf6gg6VZsoHCvobdLqvMefwrE6
1UOO9XmFzy5aNrulRWblQOrNX4O9+2wKmH4W1kByExVE0r+2IjRPwJXk2rKVcEE09RpS
QdV0Zbp1jooqimnkNtgRkLCmkE7KKY3yf+9WeZTIEldm5Ofs/p5+PWUj59VPRSJYR2Tj
o3nA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=0j2OQTAHbt3L04JNnp9pbHE2swxWtlTtYzGnDMPHfOg=;
b=jsKwZZ8uG22hDnRMXZBchvqun5B9gNdQ8Ouue6/jznB/7nP3tALWgY0dcGa32DErj3
XimJuK72buV5M11PCuxebiCAElYmSIICSKU1CBBfJDzipw0yPp7FexglQVKV2mJzZ5A0
xRgVLfEb6In6CbGX9du5wAmoC8k51FC1wQviiZjkmzJhpIkpUc7H6Embz1tzDhoaBaRe
rm/H59C/XvspPgmfDDtgSXUk967i/9h+fLwnARu6CBat16xrg2WxlhVLIgGmz/Yv9ZnI
moYgGBrneE2hWCxPWc9x9do7rKJkxZf3ZhoVKaL7B/4mWBzD3HV8qDQoqDh7C9X/KJXl
Pazw==
X-Gm-Message-State: AOUpUlGx3fCkImSnlDQi5Jl5ZDpGqS8iUPPtAW9aFLL5a1kjfGlIfB7f
27R2eWV+HcnqQskEXNLseC6EFEVX8sl7SPvgAWQ=
X-Google-Smtp-Source: AAOMgpeYCurDC2E+8BhS5xGRu4vTVOeQUoa6H46mCfxjFJHv/7o8O5cR1WePu9fM+hOScBoQLkScxiwBW3ihcu5ihNY=
X-Received: by 2002:a02:4502:: with SMTP id
y2-v6mr13806378jaa.11.1533570660970;
Mon, 06 Aug 2018 08:51:00 -0700 (PDT)
MIME-Version: 1.0
References: <1533129523-1407-1-git-send-email-radu.nicolau@intel.com>
<0c16cb66-6ee4-ff2d-6d16-7a3fdd021b0c@intel.com> <11360076.HoYMhSRcrZ@xps>
In-Reply-To: <11360076.HoYMhSRcrZ@xps>
From: Chas Williams <3chas3@gmail.com>
Date: Mon, 6 Aug 2018 11:50:49 -0400
Message-ID: <CAG2-GkmSxhU22RTiK+_C3y+x2ECsL_ooEuhEzt5n2tyKbMoAKw@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Chas Williams <chas3@att.com>, dev@dpdk.org,
Declan Doherty <declan.doherty@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when
bonding port is stopped
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2018 15:51:01 -0000
On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 02/08/2018 15:38, Doherty, Declan:
> > On 01/08/2018 2:18 PM, Radu Nicolau wrote:
> > > When a bonding port is stopped also stop and deactivate all slaves.
> > > Otherwise slaves will be still listed as active.
> > >
> > > Fixes: 69bce062132b ("net/bonding: do not clear active slave count")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> >
> > Acked-by: Declan Doherty <declan.doherty@intel.com>
>
> Waiting for opinion from the other bonding maintainer (Chas)
> who started to review and has some doubts.
>
The slaves being listed as active is not a bug. If the slaves are not
deactivated, then they should be considered activated. Previously,
stopping the bonding PMD just reset the active slave count. That's
not the right way to deactivate slaves. This was fixed by 69bce062132b.
This patch is new behavior of explicitly deactivating the slaves when
the bonding PMD is stopped.
As I mentioned, I think this makes life difficult for those of us using
an external state machine. However, that should probably be fixed
differently then.
>
> Chas, please do you agree with Declan's ack?
>
>
>
Change the Fixes line.