From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-it0-f54.google.com (mail-it0-f54.google.com [209.85.214.54]) by dpdk.org (Postfix) with ESMTP id 18EB7A497 for ; Mon, 2 Apr 2018 15:38:23 +0200 (CEST) Received: by mail-it0-f54.google.com with SMTP id 142-v6so18823931itl.5 for ; Mon, 02 Apr 2018 06:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=upwws1a8aqK5mZGLWmLNuLYC5V/GyQxAPotv2epjYqo=; b=S95j9F6HR1+pQ0Y9cVgchao9OUksiirgphtINkPrJUD+pKYTsVKM38/VSwLiU1Y07J qyl9nqrEFSBAYWM3KbJwWjD3bmuKUsf6EMNijaUqyQFxb9LKYzzmqFQJ6M1bnE0gI+xm eKIPDegFtDb8YO/3PrxWDZPVzy58sDsbTYWJMGNZQgGUUEH/n2q1thtYGclfUFRt2fGQ lcGWscdDi6Kg6MRngY0LCVZV0LISFTf1QxgzdUqEzTY2qYLipEPYFsJqaxMeDIKJL2By 219ukf7y4iGIqdw3uEeV543R1XEmnmlYdcKVRv1Vf0eDUL8+D7liGh4nbxSsRSzwmE4S cfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=upwws1a8aqK5mZGLWmLNuLYC5V/GyQxAPotv2epjYqo=; b=m96qaSifzFbVKgDOO0qdZs9BlMM9+nn8G/YlTQBWfrUuYio69btv9XiM3v0NaP5WvK 8yaYJfaQV+v8CJtlOqZZd5l2aI+C5WDiD16xQxofXsvAawo3xzuIotg0+RG8LsAyLY2c CYaxZHlQwtkPYrQWNwY6Xeq9TjZbhQSn2BHP3tM0IAbA9AGnr40Qin7EXHwSA6hD84VZ YPRh+vmo8u/9QwtkNHvZnPrdKAgKvhs+3NCCs6ge2XpgwDdqSMzdwSK2RSqbsLKMq2Vc yg+mQtiJXsHI9nGCea/aELGBg/JdNq+zVSa8eczgy8rUv6NMxJK0NfoFVPOVonR8CsOC 3i7A== X-Gm-Message-State: ALQs6tBpAk9tQDyb8h+6i4INm+0RSHkmDfHd2/EvYCl7NM/IfmY26rd7 8ljR34DiTbpMjTsLZpLrnr398Lcf8DNYcAZmOhk= X-Google-Smtp-Source: AIpwx4+FzNaryiQa7mxBdeVgKeYleNRaWP305Q0ZVrp12K4x7wn7084/bAb5vNMQ0OzR5LjfQYDwVkgNUdF2Ybb2is8= X-Received: by 2002:a24:2289:: with SMTP id o131-v6mr992753ito.95.1522676302477; Mon, 02 Apr 2018 06:38:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.2.8 with HTTP; Mon, 2 Apr 2018 06:38:21 -0700 (PDT) In-Reply-To: <039ED4275CED7440929022BC67E7061153177875@SHSMSX103.ccr.corp.intel.com> References: <20180213225618.15693-1-3chas3@gmail.com> <039ED4275CED7440929022BC67E7061153177875@SHSMSX103.ccr.corp.intel.com> From: Chas Williams <3chas3@gmail.com> Date: Mon, 2 Apr 2018 09:38:21 -0400 Message-ID: To: "Zhang, Qi Z" Cc: "Zhang, Helin" , "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Charles (Chas) Williams" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 13:38:23 -0000 On Mon, Apr 2, 2018 at 8:40 AM, Zhang, Qi Z wrote: > Hi Williams: > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams >> Sent: Saturday, March 31, 2018 1:22 AM >> To: Zhang, Helin >> Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, >> Konstantin ; Charles (Chas) Williams >> >> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on >> start >> >> On Fri, Mar 30, 2018 at 12:30 PM, Zhang, Helin >> wrote: >> > >> > >> >> -----Original Message----- >> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams >> >> Sent: Wednesday, February 14, 2018 6:56 AM >> >> To: dev@dpdk.org >> >> Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams >> >> Subject: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status >> >> on start >> >> >> >> From: "Charles (Chas) Williams" >> >> >> >> dev->data->eth_link isn't updated until the first interrupt. If a >> >> link is carrier down, then this interrupt may never happen. Before >> >> we finished starting the PMD, call ixgbe_dev_link_update() to ensure we >> have a valid status. >> >> >> >> Signed-off-by: Chas Williams >> >> --- >> >> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++ >> >> 1 file changed, 4 insertions(+) >> >> >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> >> index 37eb668..27d29dc 100644 >> >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> >> @@ -2666,6 +2666,8 @@ ixgbe_dev_start(struct rte_eth_dev *dev) >> >> if (err) >> >> goto error; >> >> >> >> + ixgbe_dev_link_update(dev, 0); >> > It is called in rte_eth_dev_start() if lsc is not enabled, and it is >> > not needed here to avoid any duplication. >> > BTW, did you see any issue or just check the code? Thanks! >> >> Yes, I see an issue with bonding. If LSC is enabled, then link_status isn't set >> until the first interrupt to update the link status. If a link is down, this >> interrupt may never happen result in link_status being somewhat undefined. > > Is your issue only happened on VF? > For PF, I saw ixgbe_check_link is called at ixgbe_dev_start, so link status is assume be updated. > If you think it is just missed in VF, can you implemented this in the similar way as PF? No, I don't believe it's isolated to VF. ixgbe_check_link() doesn't update (atomically write) the dev->data->dev_link. After .dev_start() finishes, I need the link_status of the adapter to be set. I can't wait until I hope the first interrupt has happened that would update dev->data->dev_link. How long would I wait? I don't really care if the link is down, or up, or whatever, but it can't be partially filled in. Bonding (in 802.3ad) wants the links to be similarly configured. > > Regards > Qi > >> >> > >> > /Helin >> > >> >> + >> >> skip_link_setup: >> >> >> >> if (rte_intr_allow_others(intr_handle)) { @@ -5033,6 +5035,8 @@ >> >> ixgbevf_dev_start(struct rte_eth_dev *dev) >> >> >> >> ixgbevf_dev_rxtx_start(dev); >> >> >> >> + ixgbevf_dev_link_update(dev, 0); >> >> + >> >> /* check and configure queue intr-vector mapping */ >> >> if (rte_intr_cap_multiple(intr_handle) && >> >> dev->data->dev_conf.intr_conf.rxq) { >> >> -- >> >> 2.9.5 >> >