From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 97ED3A034F;
	Thu, 25 Feb 2021 12:17:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 821E61607E5;
	Thu, 25 Feb 2021 12:17:28 +0100 (CET)
Received: from mail-il1-f176.google.com (mail-il1-f176.google.com
 [209.85.166.176])
 by mails.dpdk.org (Postfix) with ESMTP id A92EA1607E3
 for <dev@dpdk.org>; Thu, 25 Feb 2021 12:17:26 +0100 (CET)
Received: by mail-il1-f176.google.com with SMTP id q5so4553181ilc.10
 for <dev@dpdk.org>; Thu, 25 Feb 2021 03:17:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=4LZASe86dYbkMDyDGV5QCFqs9BHvxjXElOI/nGnZQ1U=;
 b=N2CABSmVcFk9mtHGwisoAnFhvBaM0c9QDZ+39fPjQuB9AjwkEIMTaP3qyButKKut4P
 YdGf6Ncj8JZfJgCnKgWQObMFoZdq9AT559DbydtLDVfaaf/rp6YpzvIXY4JqAvFwLgZn
 3OQfmsFMG6M/7vf/6rc/PKGlCz2vkXB9kclUx635VQYRjtYx4STJn5oI23uwKVDQhXcY
 eoaFzBlijAdYsU7Xrg+FNAZM3J1K4JBNd5Fe2o6cJiB+vw8QKiKhU+8LVrfZsLY7WSkc
 OkQfuazsIwaPt3lzV3dQ0XxT2JIO4MvcAFAL7OqhC0U1UfcRd4QP5l52vjNxnHRbUG09
 U7Cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=4LZASe86dYbkMDyDGV5QCFqs9BHvxjXElOI/nGnZQ1U=;
 b=EHWuQcRtoCtmoxcL9lTjOx+7KWmo3THrUi2gZtH+dep9sk5xpLbjaEvxgMDSMqBYh8
 6IyKHUedXFxgoq/8h+wm7QROFU/9aNKJvsIeChrljruuLNOW3lr55OmCnB/9cxTa80bB
 EBFBW3YLvyE9ZU1P00WFazMnio7Ux3Ld+oqn3I/KYDzWC8X3RbIlwDYVOkQD+mnzTePw
 9vBfAxaCFLR4pdpXA2DdjSvuptpvDQrE+ydiCkutl8jIUVxmhrMf8j3KC4poOOCZYn1M
 4eno1meO9LN+V9xR9az3LjqZLTOwCn0XwXef9iBPwrpJIIh4sY3JW/ZSsqmDELH6Ik0/
 lT6Q==
X-Gm-Message-State: AOAM530usncQ2GhDZs/MAQMQKA2tRnA6l/C5vASa/Mo7Byjek4VHPj6I
 0gxEr91hsar7Tp7z8BpxpXIq6sAmUPOZZgksiKMkdTmmlajWZw==
X-Google-Smtp-Source: ABdhPJw8ZgKmqMqZ5M8ebjuozZJkcLT/hYe4v2brZ0diSouzD9UTwjy2Ova6+nYRhKIiY6ai1eWRSuJ0TcPUgfm16yY=
X-Received: by 2002:a05:6e02:1c8a:: with SMTP id
 w10mr2124968ill.127.1614251845833; 
 Thu, 25 Feb 2021 03:17:25 -0800 (PST)
MIME-Version: 1.0
From: Levend Sayar <levendsayar@gmail.com>
Date: Thu, 25 Feb 2021 14:16:49 +0300
Message-ID: <CAGDw98k721Yaq3AxMXbm+5y5DacWMHrekFtZgKhiGGHj6-mLVQ@mail.gmail.com>
To: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: [dpdk-dev] IPv6 header misleading comment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, all.

Comment for payload_len is misleading. It says "includes header size".
In fact, payload_len does not include IPv6 header size.
As the name implies, only payload size + plus extensions size if any.

struct rte_ipv6_hdr {
	rte_be32_t vtc_flow;	/**< IP version, traffic class & flow label. */
	rte_be16_t payload_len;	/**< IP packet length - includes header size */
	uint8_t  proto;		/**< Protocol, next header. */
	uint8_t  hop_limits;	/**< Hop limits. */
	uint8_t  src_addr[16];	/**< IP address of source host. */
	uint8_t  dst_addr[16];	/**< IP address of destination host(s). */
} __rte_packed;


Best,

Levend