From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70703A0A02; Wed, 24 Mar 2021 07:35:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E431D140DC1; Wed, 24 Mar 2021 07:35:38 +0100 (CET) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mails.dpdk.org (Postfix) with ESMTP id 724B84067B for ; Wed, 24 Mar 2021 07:35:37 +0100 (CET) Received: by mail-ej1-f53.google.com with SMTP id b7so31015017ejv.1 for ; Tue, 23 Mar 2021 23:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BJceBg93QvFlo/Mvr8McG0Oh2cWkhQQn7fF2aoioM9c=; b=iSEyMOu61xX7q1nF0yfy3s4Yvh3ZtjAPMmRlAowi4SmxH3bEb2U04LBBKZXXPPeU0h zSnNLkve8u8XKXd75IK/MuHNEV1IdsJPdk4LDcP5rgKY1ZuwzSus/mnUEQnpjiJomaZw dgX1XAbTOff13Pe5ZrOmvMrLz1rXTSv7I61JjbrUVpVy3RACTBJrEcMiuyq1ucGvcWpK nvlbwABseVbyjajaN/YpDdMnGGyEniylIb6tzt9yGlbnOZbWtEGRJirVj/vHFz60c66U qXYN0ncIOSvw+wH9rnIL1EZ53bEiXaDX7qc+s1JBWfQlEaOOX3khXuMTaM+Mlho8OVod 4KDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BJceBg93QvFlo/Mvr8McG0Oh2cWkhQQn7fF2aoioM9c=; b=mdaVb97G+DgyXrD9NTVwaST1hOFWvE/0tz2woYpddfoMuX+IsPXFwi3nX3MxbpbHwX jgJfebCnlxPgcfvZ0P+Uqk8eEN+Ksu8aTtUJmO6nlU+LZ9kNnhhQirrZDYemUzczMQY8 GJJG6pV8dCq9JWVFbgwN5q7n0rP+V6uiyY5JDQ01qJkJnrCMoB6p8P1fo0lpOlngwWW2 KOSbg4HrWIbvaNkpDKyO8ClQD+exLPNz6aEjj/RrHRj8Ja5c7F8yD6dTdkNRvwgchfAM zSvzX6N2Ra6GlmvO2QQdVvw6J8CHXvAFuztqMadZSQ1v7jdEu4Z9GVMjK2eMXzjSFxUY l+kg== X-Gm-Message-State: AOAM530sh+hWarnbm2pRxyEiUr+1npoJ1txK/bScWn+dKv6WOo4tXDUh rVt9fv1PSG7v+JuYW+99HDOer/cf0hRNwSyrwjPlsw== X-Google-Smtp-Source: ABdhPJyMjwmkq+fKQL5GInYfRySaOaGWmukVwXEv8Qpof5fzX8xSVpc7JuB+vb7zWL5SQug0WgpmIAH3/gpmL3IDNU4= X-Received: by 2002:a17:906:4cd6:: with SMTP id q22mr1967321ejt.469.1616567737102; Tue, 23 Mar 2021 23:35:37 -0700 (PDT) MIME-Version: 1.0 References: <20210322140757.7888-1-gabriel.ganne@6wind.com> <20210323011800.2a50fde8@sovereign> <7f3f5e7c-6731-1062-49ef-52e071a076d1@mayadata.io> <20210324002148.5d7e008d@sovereign> <00d8f878-2008-2d09-4d5f-9ddf94be954c@mayadata.io> In-Reply-To: <00d8f878-2008-2d09-4d5f-9ddf94be954c@mayadata.io> From: Gabriel Ganne Date: Wed, 24 Mar 2021 07:35:27 +0100 Message-ID: To: Nick Connolly Cc: Dmitry Kozlyuk , Bruce Richardson , Kevin Laatz , dev@dpdk.org, Olivier Matz , Thierry Herbelot , "Dmitry Malloy (MESHCHANINOV)" , tal Shnaiderman , "Menon, Ranjit" , Thomas Monjalon , Tyler Retzlaff Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nick, Dmitry, Thanks for the reviews. I wrote this patch following the link issue I had with libpcap thinking it was "more of the same" ... which clearly it wasn't. I had a closer look to what dependency('threads') generates and I agree that it's not that well documented. From what I understand, it will always the '-pthread' arg in the command line arguments, and then convert the argument to the targeted environment (which might remove it if unsupported). For librte_metrics, I am mistaken and the added dep should be removed. I think that you are right to suggest keeping the "if not is_windows" test. I will set up more test environments before submitting a new patch. Best regards, On Tue, Mar 23, 2021 at 11:17 PM Nick Connolly wrote: > > > Agreed. In my tests it's "-pthread", not "-lpthread", but still. > Agreed - I must have been distracted by the array of -l: arguments :-) > > It's more like, in lib/librte_telemetry/meson.build: > > > > if not is_windows > > ext_deps += threads_dep > > endif > It's not a big deal, but my thinking was that the library has a genuine > threads dependency, but in the Windows case this is satisfied by EAL > and so threads_dep can perhaps legitimately be empty. It also means > there's only one place where the decision is made regardless of the > number of dependencies. > > Regards, > Nick > -- Gabriel Ganne