From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rich.lane@bigswitch.com>
Received: from mail-vk0-f42.google.com (mail-vk0-f42.google.com
 [209.85.213.42]) by dpdk.org (Postfix) with ESMTP id B9846ADA9
 for <dev@dpdk.org>; Tue, 10 May 2016 19:13:18 +0200 (CEST)
Received: by mail-vk0-f42.google.com with SMTP id f66so24747900vkh.2
 for <dev@dpdk.org>; Tue, 10 May 2016 10:13:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=bigswitch-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc; bh=z625ez2c838kazakKOgV4Sij7+duVRhjeA++DYPva1E=;
 b=Pi7eITD0vioXleDHHkAqnNPwr83CKfobs2bqYFUBkMs++1lo/JOMwwIIBpQinwIXze
 UnBgpUjWjLRCeW64OGXm03YXAuKgl9nm5NTwAVzMddBwzyCj2FDv3trzwwo40yMN+dpa
 cdffdxuRxb13nFQ1vHNoU4ZGHgjbrMy3xgIsfsReo8d75v9QW5qQj656/AQezCHCfqls
 A9EUEvv9nZX254A9nDzhAvxlk3Ymcgee9vKPieBGC+//7z189fOTwdCYYCDYk8WJjkRb
 toq5krZzicfZfx54qLAs45hg85gYnq5NXrnV4TZ3mIMo6cMVdnfHDZ5txjKR+25tQc31
 2q5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc;
 bh=z625ez2c838kazakKOgV4Sij7+duVRhjeA++DYPva1E=;
 b=KGI65K4Rg83ktoVlJHsr7n7q/lsP2kWZyrGS4DOnDPw7iEA4hmcPV7aHSlmh8ZdjSr
 +pPQYXomiNzHTSAAwqqIXje7fGR6dAqCGerqlh7LsWqETgmzUpFCpZ4lKmhc2JypMupD
 t6egK1EEElkOhG1TVXRU87+mRIaFCzl/MGct03unz32HkXAeHuzz+jS0USDS0D/FKO4d
 MFk0kpXIU1tGDFcc5U1YjkBV/KjwaKIRoHiKq+TpWCUy5inyWZIQmpjiBGcVWKTaVdM/
 PGMjaQVWaG35gQEK6gLKHp0TzYn9vp5Kdw2qG5LXAPpjrOsnW0ffUDAU/18+5+RxfhkQ
 JXVw==
X-Gm-Message-State: AOPr4FXP54lNuEx0fTtYY3dcZKbvWb/mBJansxuVYGKTsuM6JZ2E5r7SmYYrg9mVU7CAo7VXkM2QemzyqLk2Hrr4
MIME-Version: 1.0
X-Received: by 10.159.37.72 with SMTP id 66mr24232034uaz.111.1462900398119;
 Tue, 10 May 2016 10:13:18 -0700 (PDT)
Received: by 10.31.190.14 with HTTP; Tue, 10 May 2016 10:13:18 -0700 (PDT)
In-Reply-To: <20160510163927.GO5641@yliu-dev.sh.intel.com>
References: <1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1462227927-22853-11-git-send-email-yuanhan.liu@linux.intel.com>
 <CAGSMBPNYVCwAKO5F24SzP96Dt34bBhoTipyu3g5x2fr_FdWbWQ@mail.gmail.com>
 <20160510163927.GO5641@yliu-dev.sh.intel.com>
Date: Tue, 10 May 2016 10:13:18 -0700
Message-ID: <CAGSMBPMy9s2PPvy0VK5W7EZFG_bp4f59345OskohmFfg5YhLfw@mail.gmail.com>
From: Rich Lane <rich.lane@bigswitch.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, "huawei.xie" <huawei.xie@intel.com>, 
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Panu Matilainen <pmatilai@redhat.com>, 
 Tetsuya Mukawa <mukawa@igel.co.jp>, Traynor Kevin <kevin.traynor@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 10/16] vhost: export vid as the only
 interface to applications
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2016 17:13:19 -0000

On Tue, May 10, 2016 at 9:39 AM, Yuanhan Liu <yuanhan.liu@linux.intel.com>
wrote:
>
> Rich, would you help try by adding following line there and
> do a test? It would be great if this patch has your Tested-by :)
>
>     internal->vid = vid;
>

The problem is new_device has already returned before that point because
find_internal_resource failed.

I suggest adding a cookie parameter to rte_vhost_driver_register and
passing the cookie to each of the vhost_ops. The PMD can use pmd_internals
for the cookie and the whole internal_list can go away.

ps. Could you push git branches somewhere for these larger vhost patch
series? That would make it a lot easier to test than getting patches
individually from patchwork.