From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rich.lane@bigswitch.com>
Received: from mail-yk0-f179.google.com (mail-yk0-f179.google.com
 [209.85.160.179]) by dpdk.org (Postfix) with ESMTP id 4921091D7
 for <dev@dpdk.org>; Fri, 13 Nov 2015 05:03:44 +0100 (CET)
Received: by ykfs79 with SMTP id s79so128919959ykf.1
 for <dev@dpdk.org>; Thu, 12 Nov 2015 20:03:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=bigswitch_com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=jsmqgYLXaDdXMk68PkGMA3M0NL0sWl3iznGGFdS3XO8=;
 b=Expppn4et1KnjD+V3f/tyZB1v2xJ2Pfd7auNxklaVAbgK42G0eu9nemrHm+N9jI8KQ
 TlmwP71kGYnz+NCQKyjK3jzO9VABr+e/rs5l6qst9CIOkLogqCL1J/zkBRmKW9xHN0nI
 ZkkNsgnhDfh3fdiqwQh34AsYrUWrPoNPKiAoxDGwXra4OD1Cm0ot9eh3R6oMQe0PV65T
 HZcF+wZ4sGU73EfiWMAb1k6MVbNrpb1ocNw9BGDXBoSv2Lu/5mX/YJlYC6hU6tCB99fo
 T2m3pyoOJzDnOr8Wj2/tw/lh9v0Bypl6qeaZyxXcHvrUYOt6w5F1MYJz+y0Q+jRtyRMS
 nQCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=jsmqgYLXaDdXMk68PkGMA3M0NL0sWl3iznGGFdS3XO8=;
 b=KFDWpPgpWVuMgZDqVIj7FUkgsdqjVNqnqSAvCio/ayGHlgLJmIzGYq4AgyDbtCgPRY
 fkjl1QcxJv72bFJpeEmnn05HmGHkY7xV5Npb+f2MpFVMDaWXOcvZ+GeRbEhMjsqhoDU1
 ORiIfH+1291Qlmw3onbyJBGSy4Fy8Iapj1ZH1ztSeXFYuWLsxf+4fI8QA3a0cPQ27kaV
 mknOJNPLmj23aCFnWQXvXx15KzLZSi7k9Cx51VwIK5cnr2SonS+zojQ2jnAi7sCPNIEI
 ZgEvoaj1uL0e7BgCNMt/ALz5kO7ZWRu+tPO8rhanjIs/axq+JXEVqIl8s0RvKjhJSDow
 u3mQ==
X-Gm-Message-State: ALoCoQmz7bej816fGIHZRfHlLKypOmnaSoNNn9YRRvojTXF325QEmeq38AZWouKx9A6p3NdQOCJC
MIME-Version: 1.0
X-Received: by 10.13.251.66 with SMTP id l63mr18511648ywf.279.1447387423647;
 Thu, 12 Nov 2015 20:03:43 -0800 (PST)
Received: by 10.31.92.72 with HTTP; Thu, 12 Nov 2015 20:03:43 -0800 (PST)
In-Reply-To: <1447046221-20811-3-git-send-email-mukawa@igel.co.jp>
References: <1446436737-25606-2-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-1-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-3-git-send-email-mukawa@igel.co.jp>
Date: Thu, 12 Nov 2015 20:03:43 -0800
Message-ID: <CAGSMBPOSrdSgdTFX62dsq4f7ZP0FFCRvoySZH0M6NhZi9oUBzQ@mail.gmail.com>
From: Rich Lane <rich.lane@bigswitch.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com
Subject: Re: [dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 04:03:44 -0000

>
> +       if (rte_kvargs_count(kvlist, ETH_VHOST_IFACE_ARG) == 1) {
> +               ret = rte_kvargs_process(kvlist, ETH_VHOST_IFACE_ARG,
> +                                        &open_iface, &iface_name);
> +               if (ret < 0)
> +                       goto out_free;
> +       }
>

I noticed that the strdup in eth_dev_vhost_create crashes if you don't pass
the iface option, so this should probably return an error if the option
doesn't exist.