From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cernay@netcope.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 94C8C5688
 for <dev@dpdk.org>; Wed,  6 Mar 2019 13:49:05 +0100 (CET)
Received: by mail-lj1-f196.google.com with SMTP id q128so10736713ljb.11
 for <dev@dpdk.org>; Wed, 06 Mar 2019 04:49:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netcope.com; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=kqhNmZ/ulfFUlEOOxxu7g/ZJARUOa48ERc1xw7IRmjA=;
 b=IxjsqfpznPjNDuQLLx66Xjuw8YfJUetxDin2uhi8RnQkqwLzz71JcCjrA/yHwlgdOA
 Y9ckN0j6h24IF34xM0E0sKvIDkwrbJSuER8ap/uRRfQyXzqpWRsn8Tv3vzCDJfmneom7
 Qy1beqQ1ErmpWQGWTUDtSZfawMx3LFeTL6I2UCnUHjDLbkITSPpHWJ83dTenFlcJGTUM
 fEkDFdrulOAibhmdpVacKhEBmZN1HoFR7I8MNhqjeIwSSXdPXSxFIkbISKZ3+irReZdv
 C60EtBzkFxP0aF7vVWUpviEU9CvnwXQOxepgmtAVCcagnTgZyS9eUmczpLTPV5GZIbX4
 +6pg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=kqhNmZ/ulfFUlEOOxxu7g/ZJARUOa48ERc1xw7IRmjA=;
 b=Rpd9q2MqeEFRDeinpjkwkDSWmcaVB529CZB6xurmf5k75BrSbjbTBy/wEr4bq2agC8
 RUXu8I4SvKCdITacnNVjfSQaLI1D/poY8KIR3oi48zjJhwTEE0Y1wtczgAiKc0HblLLC
 t+wRlzUOBK8/ve7Lu3bChcZGUs6LbQE/biJWsDNBjr6oKcE4ycZz4+hP4/IP6uE69bBp
 wvmZFZ5YPe6r2W8ClWYwwf4xe7v91tJA8n3Vv72EL5Anf/AVM9TZtXMBAb8aJ0jUlkld
 BjLMaFz8CXsUYbzdaVameTxt2w+4D7RWg4gKqN5o46vs0oJVg1jkUdPa1PjswsfOYyQy
 4q8A==
X-Gm-Message-State: APjAAAXv/oYBUbJgRWGln0ePnkvAtXwYd123GVLReICwigFl1DTCdfGW
 kq+crFp/qYxgnWp2aedxNvc7UyaFn2bxyEgmduMrww==
X-Google-Smtp-Source: APXvYqz28wQ+nQCIMWYqdG0dfoamd6aG00KdzZLeU/R9Qips59s5Y9vNiwp1C59hcKdg/BpJyLaXKl5diGcZcSQ8TWc=
X-Received: by 2002:a2e:7314:: with SMTP id o20mr2359365ljc.111.1551876544520; 
 Wed, 06 Mar 2019 04:49:04 -0800 (PST)
MIME-Version: 1.0
References: <1551185824-5501-2-git-send-email-cernay@netcope.com>
 <1551451054-111249-1-git-send-email-cernay@netcope.com>
 <130a4780434ea30138a7c98f5689da143c73a8a1.camel@debian.org>
In-Reply-To: <130a4780434ea30138a7c98f5689da143c73a8a1.camel@debian.org>
From: =?UTF-8?Q?Rastislav_=C4=8Cernay?= <cernay@netcope.com>
Date: Wed, 6 Mar 2019 15:51:37 +0100
Message-ID: <CAGS_BLmdKdviXXHPpUa7-KsJtZOvS0QLG-ssQ=VRxBwBAjnhAg@mail.gmail.com>
To: Luca Boccassi <bluca@debian.org>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 12:49:05 -0000

>
>
> --Why is -lfdt added? I don't see any symbols from libfdt used in the
> --rest of the patch?
>

Hi,
libnfb is dependent on fdt and there is a special case, where some
functions are defined in header (netcope/rxmac.h, netcope/txmac.h).
So if one wants to use functions, from these headers fdt needs to be linked
manually, not just through nfb. I also added fdt to meson.build
so it is little clearer, however if libnfb is installed libfdt is always
installed too.