From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shrivastav.shyam@gmail.com> Received: from mail-qk0-f178.google.com (mail-qk0-f178.google.com [209.85.220.178]) by dpdk.org (Postfix) with ESMTP id 0C747D2D8 for <dev@dpdk.org>; Sat, 25 Mar 2017 06:48:38 +0100 (CET) Received: by mail-qk0-f178.google.com with SMTP id d10so568214qke.1 for <dev@dpdk.org>; Fri, 24 Mar 2017 22:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gJlAgU4Qlx7gBNJaHP4sB8LoiRIZ9U3fZmC2Fc+K+Zs=; b=GWAkzaki4xTqCGyatdykYwSanqtoyKiK7oKTNLXgdh2TlypTjqQiNJ8Z+H9d56rPsu ATv9jtf4JLWlnEuMpWjBLm7DLLlrHKzn2HmZ0yOx7zF7C/Rt0Xy1QwgOE65hw3MQjg0j GRypwAbdYrTBa3nMv3YdHLP9lIGV/xqIvHqzQqSxmFxLvQ4cIiPEhOgNDm7vZYSHYTW+ wAE4I+20smpjZ6a/BpmbUK4DFpStlJZnhzn9qr1zJj0icS8CWlJt5LNr/3HcuteOiuzO 9EDfcr7GvO4TSmMMmWTr/vFN/gplqxxo+vWYWmIz00nI3VXXc2ei/I7ZV/T0bm0BFUIU 3FaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gJlAgU4Qlx7gBNJaHP4sB8LoiRIZ9U3fZmC2Fc+K+Zs=; b=Dc+tPI9IndnBfS9IaOFiSp3/9z+BGPpvBZwX3HPV8mgQv+Kzng9J3FZoSL6QVWY7Bk k/taAToHaAp3Wo0byantFVq5cjmjwAziHKwkyLGkUVZrEmVapp0OBPT4T7eYCHsNDzO+ x1XBa2YcSwyfZ3pV0MTk2BO967FFHQRqUXZnpnY1QI2Z7DN7SiHcjJYLM6kVciwLE4Ab +ajo3szwa3XuQP/vIavlcnYXmIXHfaR74ipNPBhs8Lb7RfsRQdEwCIwhMufsmaZnQ9Q8 YJtQueg1YYjbMcQ69TqSoeGplHYyj9pwVnNxxMZrqSoBZnhLZO9usrZvlqlDbZketJjZ ULmw== X-Gm-Message-State: AFeK/H1HHwe92EuY4SGyV6XLyTqmC2sszQMPg706M/ZRKPtIwyKPvn6pnywlUprdLcKwS8xkcPgzpeLlbfEJjQ== X-Received: by 10.55.73.214 with SMTP id w205mr10315081qka.298.1490420917392; Fri, 24 Mar 2017 22:48:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.139.71 with HTTP; Fri, 24 Mar 2017 22:48:37 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891265277302E@IRSMSX108.ger.corp.intel.com> References: <1490146535-5065-1-git-send-email-shrivastav.shyam@gmail.com> <3EB4FA525960D640B5BDFFD6A3D891265277302E@IRSMSX108.ger.corp.intel.com> From: Shyam Shrivastav <shrivastav.shyam@gmail.com> Date: Sat, 25 Mar 2017 11:18:37 +0530 Message-ID: <CAGSp03=9puvs=YPVqYeeQma9iOp_qmf9-vNkMbswMBJyDpwjhQ@mail.gmail.com> To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] pipeline_firewall: Fix for port range filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 25 Mar 2017 05:48:38 -0000 > Firewall ACL definition need to use same input index for source and > > destination ports as these are 16 bits and would fit in one ACL > > field of 32 bits. This is required as per librte_acl API. Without this > > UDP/TCP source and destination ports filtering (and for that > > matter ICMP type/code filtering) does not work. > > > > Signed-off-by: Shyam Kumar Shrivastav <shrivastav.shyam@gmail.com> > > --- > > Reviewed-by: Jasvinder.Singh@intel.com > Acked-by: Cristian.Dumitrescu@intel.com > > Thanks, Shyam, for debugging this! > Tested-by: Shyam Kumar Shrivastav <shrivastav.shyam@gmail.com>