From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by dpdk.org (Postfix) with ESMTP id 48675200 for ; Sat, 25 Nov 2017 12:43:18 +0100 (CET) Received: by mail-qk0-f176.google.com with SMTP id a142so27257774qkb.5 for ; Sat, 25 Nov 2017 03:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3k4Io1B2IEm3BpJCldA/OlIRsRl2yIrjDs0pNspSMRg=; b=sDGSrAljnRh5ur8Gtm4M4hdULi4C94MmvxhbZLWGlJQ26IYOpRVw6wevXqLciM/Un8 c3V6jmdNW91g2c8TzkB1LppJAURaSHOdWL9anfYMFwsTVTk6Y7MfQh2Pmoql/3b47698 +Sm3udgpyY5l7UnAOod+lgfaFJtWNwTT/5WZ0y9RVQhHkkv2MBSHBcDM8nY7NcvLtDNG pqkP6kApvc3DyUYtCMTN6gULlecUdES9hgDWwmkfupjdom8weC8KQMWlugrGTciKETKC koBcZWi/+5N9rj+3W9XaVgFFMOsGFsDc/cCB11CQTWEZV6hMRx1nrjFxDYj+kd6KW1Qq D0FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3k4Io1B2IEm3BpJCldA/OlIRsRl2yIrjDs0pNspSMRg=; b=WpmZN2Y39JNIRGvBHwQQkpR+ow7OYrFftSg6q2/2Spmk5JsgHmQrxsajjwwq6Ehfyl k+JFGmPq8it06dPAVDzSLL4SjhrPChz3IWOTq4UzXEXPoWq1G4lTDP82NrnzRMG0x23X IGFRAPkWg5xDCFHu+FwsVPR6z0bjhMVtUocAV35dZJPVf2O1F5tXkKG2tc4s7WdKMisH Y4NnDwur+b/Dye20eNkz7Se8j4v1PYDMjMkrtmgySdYAcdub8qzjjCPw/zXJ4pQFn6Zx k51H1pj20qETA6W18tGN3xm/Cw2ACNlWMekraz48UnSoDKfC/RqKJ7/wanszvrqR8iQS mizg== X-Gm-Message-State: AJaThX7NZvXSOFK7vWNQlgRkBNWta3F7TP+L0Y7pvSaBmGBnhHrEMJ+l 9bZIpjpVIp8HkZW6xDlh7T67Zb9sAcB7oL9c70YViA== X-Google-Smtp-Source: AGs4zMbbGkkL8cfUD1WBCIgl2TzHGbN6yi2yXlm4Y6z8p1/W64yY6ypYrl8oTMxZ3Ta7JV/Nz9C7BLaxGcmicYi5yoA= X-Received: by 10.55.132.194 with SMTP id g185mr49289222qkd.18.1511610197571; Sat, 25 Nov 2017 03:43:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.63.206 with HTTP; Sat, 25 Nov 2017 03:43:17 -0800 (PST) In-Reply-To: <20170703094242.08afee17@platinum> References: <20170703094242.08afee17@platinum> From: Kevin Wilson Date: Sat, 25 Nov 2017 13:43:17 +0200 Message-ID: To: Olivier Matz Cc: "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used - shouldn't they be removed and deprecated ? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 11:43:18 -0000 Hi all, >Let's see if someone complains, and if no, we can plan to remove it >for 17.11. Well, unless I missed it, I did not encounter any complaints, and 17.11 was already released. And the status is of course the same (meaning that in the DPDK tree it is not used). Maybe now that 17.11 was just released several days ago, it is a good time to start deprecation process for these control MBUF stuff ? I know for sure that for DPDK newbies who read the programmer's guide and encounter it, this is a bit confusing (like in "2.3.3. Network Packet Buffer Management (librte_mbuf)" in http://dpdk.org/doc/guides/prog_guide/overview.html#network-packet-buffer-management-librte-mbuf) ... ... "This library provides an API to allocate/free mbufs, manipulate control message buffers (ctrlmbuf) which are generic message buffers, and packet buffers (pktmbuf) which are used to carry network packets." ... ... and of course also confusing those who delve into the code. Regards, KW On Mon, Jul 3, 2017 at 9:42 AM, Olivier Matz wrote: > Hi, > > On Mon, 3 Jul 2017 06:51:51 +0300, Kevin Wilson wrote: >> Hello, >> With the most recent master tree we have: >> >> git grep rte_ctrlmbuf_init >> doc/guides/prog_guide/mbuf_lib.rst:The rte_pktmbuf_init() and >> rte_ctrlmbuf_init() functions initialize some fields in the mbuf >> structure that >> lib/librte_mbuf/rte_mbuf.c:rte_ctrlmbuf_init(struct rte_mempool *mp, >> lib/librte_mbuf/rte_mbuf.h:void rte_ctrlmbuf_init(struct rte_mempool >> *mp, void *opaque_arg, >> lib/librte_mbuf/rte_mbuf_version.map: rte_ctrlmbuf_init; >> >> git grep rte_is_ctrlmbuf >> lib/librte_mbuf/rte_mbuf.h:rte_is_ctrlmbuf(struct rte_mbuf *m) >> >> git grep CTRL_MBUF_FLAG >> doc/guides/prog_guide/mbuf_lib.rst:or generic control buffers >> (indicated by the CTRL_MBUF_FLAG). >> lib/librte_mbuf/rte_mbuf.c: m->ol_flags |= CTRL_MBUF_FLAG; >> lib/librte_mbuf/rte_mbuf.h:#define CTRL_MBUF_FLAG (1ULL << 63) >> /**< Mbuf contains control data */ >> lib/librte_mbuf/rte_mbuf.h: return !!(m->ol_flags & CTRL_MBUF_FLAG); >> >> rte_ctrlmbuf_init() and CTRL_MBUF_FLAG and rte_is_ctrlmbuf() are not >> used - shouldn't they be removed and deprecated ? > > Yes, I'm in favor of removing it since a long time. This was > discussed and partially removed in 2014, because there was still a > user of it in examples/. But it looks that it's now unused since 2015. > > Let's see if someone complains, and if no, we can plan to remove it > for 17.11. > > Olivier