From: Kevin Wilson <wkevils@gmail.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used - shouldn't they be removed and deprecated ?
Date: Mon, 3 Jul 2017 06:51:51 +0300 [thread overview]
Message-ID: <CAGXs5wWKHqjc8Ct4fUDj0sMs=ONMRMi7iUchRF_VZDoNCWEy5A@mail.gmail.com> (raw)
Hello,
With the most recent master tree we have:
git grep rte_ctrlmbuf_init
doc/guides/prog_guide/mbuf_lib.rst:The rte_pktmbuf_init() and
rte_ctrlmbuf_init() functions initialize some fields in the mbuf
structure that
lib/librte_mbuf/rte_mbuf.c:rte_ctrlmbuf_init(struct rte_mempool *mp,
lib/librte_mbuf/rte_mbuf.h:void rte_ctrlmbuf_init(struct rte_mempool
*mp, void *opaque_arg,
lib/librte_mbuf/rte_mbuf_version.map: rte_ctrlmbuf_init;
git grep rte_is_ctrlmbuf
lib/librte_mbuf/rte_mbuf.h:rte_is_ctrlmbuf(struct rte_mbuf *m)
git grep CTRL_MBUF_FLAG
doc/guides/prog_guide/mbuf_lib.rst:or generic control buffers
(indicated by the CTRL_MBUF_FLAG).
lib/librte_mbuf/rte_mbuf.c: m->ol_flags |= CTRL_MBUF_FLAG;
lib/librte_mbuf/rte_mbuf.h:#define CTRL_MBUF_FLAG (1ULL << 63)
/**< Mbuf contains control data */
lib/librte_mbuf/rte_mbuf.h: return !!(m->ol_flags & CTRL_MBUF_FLAG);
rte_ctrlmbuf_init() and CTRL_MBUF_FLAG and rte_is_ctrlmbuf() are not
used - shouldn't they be removed and deprecated ?
KW
next reply other threads:[~2017-07-03 3:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 3:51 Kevin Wilson [this message]
2017-07-03 7:42 ` Olivier Matz
2017-11-25 11:43 ` Kevin Wilson
2017-12-01 16:38 ` Olivier MATZ
2017-12-08 15:49 ` [dpdk-dev] [RFC] mbuf: remove control mbuf Olivier Matz
2018-04-03 13:39 ` [dpdk-dev] [PATCH] " Olivier Matz
2018-04-03 14:42 ` Jerin Jacob
2018-04-11 21:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXs5wWKHqjc8Ct4fUDj0sMs=ONMRMi7iUchRF_VZDoNCWEy5A@mail.gmail.com' \
--to=wkevils@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).