From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wkevils@gmail.com>
Received: from mail-yb0-f170.google.com (mail-yb0-f170.google.com
 [209.85.213.170]) by dpdk.org (Postfix) with ESMTP id 7D0C02B99
 for <dev@dpdk.org>; Mon,  3 Jul 2017 05:51:52 +0200 (CEST)
Received: by mail-yb0-f170.google.com with SMTP id s15so17542091ybe.2
 for <dev@dpdk.org>; Sun, 02 Jul 2017 20:51:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=0w0fGfrZceNfAvd2Fp88RPHBSudJAlPDqN0CV22FTlw=;
 b=PdU0CdRG3XCbIH8xCUbKY3lqG47VyV0mkoDThsFE1t053Lk3pzvdwxDyI1sSvbimnu
 jlA0qyXdtL2Yzfbzt3JQCFYdzoj5VVo8YoG5MfjyPkRwMLj3geulNRjzVZIZwOC6pfMu
 57HfsO+JgUFdklGAqTJI5eB4x+X78xDR+KPW4dEIxGEtWeX2mDWszmhXrsS4ULO7TBqb
 cd9ma6C8W+qSyCwuK1n3TT2E6qe+YbkHemij/6ZV1N/wkgmdoukGPZ6oBTf+77QIfPag
 GOl3vj/SEgXzNMkebGxIM84RhOH2ShILiO7K8h4E0rivRwCL5uwHw0pJqp+WO1Em1eZY
 PESw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=0w0fGfrZceNfAvd2Fp88RPHBSudJAlPDqN0CV22FTlw=;
 b=fdVYtikozi1obwjyD+8Dcfyr8AbvLBx6BbX3w1Ye/J7m5dHYqf51jTey/le+K2Idth
 eWN21ijnLpkAF47yaD39Ae+XRqSlqLwvR/tzxrN+Pm2rdXmTPdl/Wc/bBwvDYbdHKl/c
 +BagT9pJAP429M4TaVfR+7sjHKr7Jw3YilRwzOpiAwES4x7oynehCbFee2A9FaAxM8dg
 XlDn987T07dalRdsoHcBLXCB/ZAEzPRaHRFp9K0rKYEBS0JZ1sEV0mHYzu2UrhqJfTU6
 LtLwy8WznXEMHEZHMET+iNHfjqWsEvpRw7vDjoC7TPDivCQRX2bno3uYhVw6h+FHasRe
 clVg==
X-Gm-Message-State: AKS2vOz60UsYGJsQCiU2OsVWJKvJGvF27m9v+vgr8iK2JFMTT+XKoMSn
 QMKklID8fCC/YzMcemPeLLBsg/oNfH4a
X-Received: by 10.37.183.6 with SMTP id t6mr25602501ybj.221.1499053911562;
 Sun, 02 Jul 2017 20:51:51 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.129.118.20 with HTTP; Sun, 2 Jul 2017 20:51:51 -0700 (PDT)
From: Kevin Wilson <wkevils@gmail.com>
Date: Mon, 3 Jul 2017 06:51:51 +0300
Message-ID: <CAGXs5wWKHqjc8Ct4fUDj0sMs=ONMRMi7iUchRF_VZDoNCWEy5A@mail.gmail.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: [dpdk-dev] rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used -
 shouldn't they be removed and deprecated ?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jul 2017 03:51:52 -0000

Hello,
With the most recent master tree we have:

git grep  rte_ctrlmbuf_init
doc/guides/prog_guide/mbuf_lib.rst:The rte_pktmbuf_init() and
rte_ctrlmbuf_init() functions initialize some fields in the mbuf
structure that
lib/librte_mbuf/rte_mbuf.c:rte_ctrlmbuf_init(struct rte_mempool *mp,
lib/librte_mbuf/rte_mbuf.h:void rte_ctrlmbuf_init(struct rte_mempool
*mp, void *opaque_arg,
lib/librte_mbuf/rte_mbuf_version.map:   rte_ctrlmbuf_init;

git grep  rte_is_ctrlmbuf
lib/librte_mbuf/rte_mbuf.h:rte_is_ctrlmbuf(struct rte_mbuf *m)

git grep CTRL_MBUF_FLAG
doc/guides/prog_guide/mbuf_lib.rst:or generic control buffers
(indicated by the CTRL_MBUF_FLAG).
lib/librte_mbuf/rte_mbuf.c:     m->ol_flags |= CTRL_MBUF_FLAG;
lib/librte_mbuf/rte_mbuf.h:#define CTRL_MBUF_FLAG       (1ULL << 63)
/**< Mbuf contains control data */
lib/librte_mbuf/rte_mbuf.h:     return !!(m->ol_flags & CTRL_MBUF_FLAG);

rte_ctrlmbuf_init() and CTRL_MBUF_FLAG and rte_is_ctrlmbuf() are not
used - shouldn't they be removed and deprecated ?

KW