From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f65.google.com (mail-it0-f65.google.com [209.85.214.65]) by dpdk.org (Postfix) with ESMTP id B4784271 for ; Thu, 14 Dec 2017 21:19:12 +0100 (CET) Received: by mail-it0-f65.google.com with SMTP id b5so14348642itc.3 for ; Thu, 14 Dec 2017 12:19:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=R7itle6eDnF3dDMP1XZjIx0bivjySsLEg/01M2CpVMs=; b=d+hLrf3AgmYw07SPVBgH2wbEU3X8l3R8/HJmcuw81ULQKrNqcxtHVu//KrInMjCYki thBtEcfCMx3paj3YvaVSV1hD8B5RGBBAXKJSJFyvqA/V/Abp55cIQDi3Mmi4iULCfah1 qJpfJ7gERcI3I97TJnQPEvw1+oBEGhgB6rfRSAK5U0MJB6UqREbaRDLv1iaPa3ztn/b+ aJLumouu+qPF3DBKjOXKbFNzLvhUtWG4gie1/Jvfd2Un/QAvPOG7AJ9VFtSTmSXtbKWD D+GE25S8WsFpNUKQ2JxyAVI98TAXjvqQAQRt40+QAQdlOuUfDhjecka6NXRq3KSlRnMU AB8A== X-Gm-Message-State: AKGB3mJUOqfhktxCgYtWGm74SKwV3UovEWzj8pHnRELUUhDlkVGGTN78 c8thdV8uMznHLwuLVO969ILbG4up3+TYFrQhKNr760sw X-Google-Smtp-Source: ACJfBosVv1HvMkEodRPb9h/D4O2VsvaRp4z3c7epcNzCzHQTlh1hj/xpFqYE7rctoRJlanyplkC5K3mJ9OI0cGe+17U= X-Received: by 10.36.53.20 with SMTP id k20mr4552788ita.21.1513282751965; Thu, 14 Dec 2017 12:19:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.167.144 with HTTP; Thu, 14 Dec 2017 12:18:31 -0800 (PST) In-Reply-To: <2d7fb769e8d846c69fe3f5b39ed8fa36@sandvine.com> References: <20171214182245.31991-1-mcroce@redhat.com> <2d7fb769e8d846c69fe3f5b39ed8fa36@sandvine.com> From: Matteo Croce Date: Thu, 14 Dec 2017 21:18:31 +0100 Message-ID: To: Kyle Larose Cc: "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] i40e: remove warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 20:19:13 -0000 On Thu, Dec 14, 2017 at 9:15 PM, Kyle Larose wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matteo Croce >> Sent: Thursday, December 14, 2017 1:23 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] i40e: remove warning >> >> Fix a printf warning which made the compilation fail when compiling with= GCC >> 7.2 and -Werror: >> >> error: format =E2=80=98%llu=E2=80=99 expects argument of type =E2=80= =98long long unsigned int=E2=80=99, >> but argument 8 has type =E2=80=98u64 {aka long unsigned int}=E2=80=99 = [-Werror=3Dformat=3D] >> >> Signed-off-by: Matteo Croce >> --- >> drivers/net/i40e/base/i40e_common.c | 2 +- >> drivers/net/i40e/base/i40e_nvm.c | 6 +++--- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/i40e/base/i40e_common.c >> b/drivers/net/i40e/base/i40e_common.c >> index 900d379ca..14834e8f2 100644 >> --- a/drivers/net/i40e/base/i40e_common.c >> +++ b/drivers/net/i40e/base/i40e_common.c >> @@ -3929,7 +3929,7 @@ STATIC void i40e_parse_discover_capabilities(struc= t >> i40e_hw *hw, void *buff, >> p->wr_csr_prot =3D (u64)number; >> p->wr_csr_prot |=3D (u64)logical_id << 32; >> i40e_debug(hw, I40E_DEBUG_INIT, >> - "HW Capability: wr_csr_prot =3D 0x%llX\= n\n", >> + "HW Capability: wr_csr_prot =3D 0x%lX\n= \n", >> (p->wr_csr_prot & 0xffff)); >> break; >> case I40E_AQ_CAP_ID_NVM_MGMT: > > > wr_src_prot is a u64, which will translate to long long on 32-bit systems= . This will likely trip over a similar warning in that case. > Should we instead use "HW Capability: wr_src_prot =3D 0x"PRIX64"\n\n"? > > See inttypes.h for more info. > Indeed. I'm making a v2 anyway because there are non printable color codes from the GCC output --=20 Matteo Croce per aspera ad upstream