From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.gora@gmail.com>
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
 [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id A5D935B16
 for <dev@dpdk.org>; Tue, 18 Sep 2018 19:42:19 +0200 (CEST)
Received: by mail-wm1-f67.google.com with SMTP id n11-v6so3816355wmc.2
 for <dev@dpdk.org>; Tue, 18 Sep 2018 10:42:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc;
 bh=VpLrmUbulxTtZ7O+82hKD5IQpKZN6H0r4LJ/KZJWP5Q=;
 b=jdtTUfSQL45QEHb0NCfiES8S7EW/PZ3UZUqElbi8SaAdLB90U54a3PKYMrmzqpjioW
 jjDDEI8ejQNXuZSu3Miuvun6PddkUzIOVRBesYZY55jt1PbGUSxF8Xnso1oAPBnrPLQH
 Pt5NP+u/hgLTNPTpvpY9mJ/y6OAwz7PqrdfYjtWpfDshxJVqntSLDMIHsLmfHCiv5jPY
 0hep6mD1Of+kBQJfHbvQDx3k7suue89rYAdS/y1N7qQbG0h+nyPzTc2Vvh4+itw2GKym
 JVSPf+Hf+vpAFrCAthP3BFR28HZS7AxHSPaYVqaxbgyvW68g266L+e9/6gnKh8AeSLjm
 KBWA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc;
 bh=VpLrmUbulxTtZ7O+82hKD5IQpKZN6H0r4LJ/KZJWP5Q=;
 b=W2veDJcHqysyf4PZrhMCcgV+Q7/Ds/U6irryHgsfnhqfaY2gEHBWNSQpVClFoQ0TBR
 EhmIJ27kqt3iWz6P3klT7MH5639oowAI7V9w1SSFJm5LF9YWJkMPI6fVfLNDuOJW19+K
 faCorTUrRU60XrxCr+d3T8enadsaKXW3/byOJjH0lgFcdg+Cz/6Da4qdVyxy/u6rhhK5
 91fFoIq57OFAAgH5+y0IOu5ZftUkitacAmnD4+M0RLF18jNqAW5XZml657zJ+u2+ornd
 6TGeu1Ib/k4M6L8nMSUePhOlY7nqC7RMuQ6gzQfxhWdY+GSTZar1Nzu3AU9rr+h5MJNC
 BjKQ==
X-Gm-Message-State: APzg51BreNtlB560aaIh3FZ37S3mEgd22/Y0PEKsNrVuL2uviNekmfb4
 VooYRNZwx1NUihzt/3txu8I2/+rxbI740irFfkk=
X-Google-Smtp-Source: ANB0VdZPbx3E/KZnLX3k1r52pkGg373Ye9Q0fO6zeB5j4QPD+U+uu6GKXijii8d/2ASycLpViI6qb3NjSzVUJPOC5II=
X-Received: by 2002:a1c:9808:: with SMTP id
 a8-v6mr16409889wme.62.1537292538884; 
 Tue, 18 Sep 2018 10:42:18 -0700 (PDT)
MIME-Version: 1.0
Sender: dan.gora@gmail.com
Received: by 2002:adf:fbc1:0:0:0:0:0 with HTTP; Tue, 18 Sep 2018 10:41:38
 -0700 (PDT)
In-Reply-To: <0e366549-2ae6-2e70-6e60-7e5970b1a98e@intel.com>
References: <20180911232906.18352-1-dg@adax.com>
 <20180911232906.18352-2-dg@adax.com>
 <0e366549-2ae6-2e70-6e60-7e5970b1a98e@intel.com>
From: Dan Gora <dg@adax.com>
Date: Tue, 18 Sep 2018 14:41:38 -0300
X-Google-Sender-Auth: U0MF-Y6if3dxo6tcbuKgeYpDKEA
Message-ID: <CAGyogRY1AxbF0y8fn6m2MfwvEFx=SA1V61x+VRwqhoFXdx2ZhA@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Igor Ryzhov <iryzhov@nfware.com>, 
 Stephen Hemminger <stephen@networkplumber.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 1/2] kni: add API to set link status on
	kernel interface
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 17:42:19 -0000

On Tue, Sep 18, 2018 at 1:54 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 9/12/2018 12:29 AM, Dan Gora wrote:
>> Add a new API function to KNI, rte_kni_update_link() to allow DPDK
>> applications to update the link status for KNI network interfaces in
>> the linux kernel.
>>
>> Signed-off-by: Dan Gora <dg@adax.com>
>
> +1 to sysfs implementation.
>
> But right now this API is not used at all which makes it hard to test and catch
> when API broken.
> Can you please implement the API either on kni sample app or kni unit test?
>
> Also you need to add new API to .map file for shared library build. (you would
> catch this if API implemented somewhere...)

Understood.. I'll work on this ASAP.

-dan