From: Dan Gora <dg@adax.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add kni changes to release note
Date: Mon, 5 Nov 2018 17:27:41 -0200 [thread overview]
Message-ID: <CAGyogRYLMVvZ0PPecPOquuBwSq92VCTLzrA2_GVAzgJAEvXo=Q@mail.gmail.com> (raw)
In-Reply-To: <61f79ace-a913-d8f3-35cd-0385965b56f0@intel.com>
On Mon, Nov 5, 2018 at 5:06 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > +* kni: Added the new API function ``rte_kni_update_link()`` to allow the user
> > + to set the carrier state of the KNI kernel network interface.
> > +
>
> It is good to document new API, which can be on "new features" section above, we
> mostly don't document new APIs in "api changes" section, but also it is
> important to document behavior change too.
That doesn't really make any sense.. APIs which are removed are
documented here, why wouldn't API additions be documented there as
well?
The new API function is an API change, it's not really a new DPDK
"feature" like a new subsystem or something..
> Now by default kni interfaces will have carrier off, and there won't be any
> traffic and people may get stuck, this is to help them, that is why I mentioned
> sysfs interface, since this patch replaces that one, can you please add those
> information here?
The sysfs trick was never really an "interface", it is/was completely
external to DPDK, but I'll add a blurb about it if you think that
it'll help..
next prev parent reply other threads:[~2018-11-05 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 18:29 Dan Gora
2018-11-05 19:06 ` Ferruh Yigit
2018-11-05 19:27 ` Dan Gora [this message]
2018-11-05 19:54 ` [dpdk-dev] [PATCH v2] " Dan Gora
2018-11-14 0:34 ` Ferruh Yigit
2018-11-18 23:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyogRYLMVvZ0PPecPOquuBwSq92VCTLzrA2_GVAzgJAEvXo=Q@mail.gmail.com' \
--to=dg@adax.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).