From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.gora@gmail.com>
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
 [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 954304CBD
 for <dev@dpdk.org>; Mon,  5 Nov 2018 20:28:18 +0100 (CET)
Received: by mail-wr1-f67.google.com with SMTP id o15-v6so7180248wrv.4
 for <dev@dpdk.org>; Mon, 05 Nov 2018 11:28:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=rFnGSZgHY/v8LEL4pI+YdeswgiwxGMOMp6kM4Fvi1z8=;
 b=Snh1BzRYMTGN3L8Jks0eyGR6qFxNhQeIw80ATAsbFGCUY6kSbKIeaq37sIqcUawc8B
 Zhbi4VmGHZXmLKoyKzzlKOG/DLGMGB86j448ho0fwY3RoiR6nNRqQoiVYaMKKmKoQPcj
 i1vnXWf44YCEjS4/vTUiXlaZ4sfNsRPwrBHqoo0euYNqZJhUdk3fJQ1xPdkIVMWIQRXh
 N/dl5uLfdwHxGWa7i1Esn4kN1upJbirr9dvSer4Jt7wjcV/DIFbQI85ZLMrEFnQC0mw5
 lZ9YyhfyW1gzVOGBMcMd6BkgYms06AhnhFl19dWxDebOJ9sYkqsoDVIvINuu20ZWXewQ
 Ldeg==
X-Gm-Message-State: AGRZ1gJtOjPm+T7KYyWCsjbhkIbOJYejxuMs8W3hFxA5GEnNydhPu35n
 VPQeUcHYoIbvOewcdTmXjSNHrIiAMKAWSY3aEFm2XRx3
X-Google-Smtp-Source: AJdET5cQMTyofcwGOA9ryMjZWdR4lRn8T3MHy/GkeA2Fg2Jme+Qw4WN+10M8xA+PKanNMeL1fWt6eVnhpeWplaI5ggY=
X-Received: by 2002:a5d:618c:: with SMTP id
 j12-v6mr13664190wru.300.1541446098080; 
 Mon, 05 Nov 2018 11:28:18 -0800 (PST)
MIME-Version: 1.0
References: <20181105182934.20599-1-dg@adax.com>
 <61f79ace-a913-d8f3-35cd-0385965b56f0@intel.com>
In-Reply-To: <61f79ace-a913-d8f3-35cd-0385965b56f0@intel.com>
From: Dan Gora <dg@adax.com>
Date: Mon, 5 Nov 2018 17:27:41 -0200
Message-ID: <CAGyogRYLMVvZ0PPecPOquuBwSq92VCTLzrA2_GVAzgJAEvXo=Q@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>, 
 Marko Kovacevic <marko.kovacevic@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] doc: add kni changes to release note
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2018 19:28:18 -0000

On Mon, Nov 5, 2018 at 5:06 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > +* kni: Added the new API function ``rte_kni_update_link()`` to allow the user
> > +  to set the carrier state of the KNI kernel network interface.
> > +
>
> It is good to document new API, which can be on "new features" section above, we
> mostly don't document new APIs in "api changes" section, but also it is
> important to document behavior change too.

That doesn't really make any sense.. APIs which are removed are
documented here, why wouldn't API additions be documented there as
well?

The new API function is an API change, it's not really a new DPDK
"feature" like a new subsystem or something..

> Now by default kni interfaces will have carrier off, and there won't be any
> traffic and people may get stuck, this is to help them, that is why I mentioned
> sysfs interface, since this patch replaces that one, can you please add those
> information here?

The sysfs trick was never really an "interface", it is/was completely
external to DPDK, but I'll add a blurb about it if you think that
it'll help..