From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.gora@gmail.com>
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com
 [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 9905E1B179
 for <dev@dpdk.org>; Thu, 18 Oct 2018 21:00:37 +0200 (CEST)
Received: by mail-wr1-f68.google.com with SMTP id q1-v6so1951816wrs.4
 for <dev@dpdk.org>; Thu, 18 Oct 2018 12:00:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=rBsnt4/GqpT8U+r+YzhCdHvronVbFApOMOyHHIWu0Zw=;
 b=dBS+y3AGQn1HbDqwgJzY0duNn5JBIvJm0rgOEB96vMYksABHW23Pia8jDVXNzdp+c2
 mquP04aNpxzK/htMchcgB20SY8DdH7JvZMMuWWkyeQqU3wfjV3TC6gmFFNFgnCBAsI6P
 ckFYnw4mls0MaK21ZUsOMiEw0zG7zpdE2QU/Cy7ghEqgTOqKp/PpjuPVgH/mQ14K4AgC
 fFETQqNzlxxUhly+G59ASkxkUOtnqUSBHNeGLxKyZZfMFElIrEDYWB/uI2LnYMfqtLrF
 MVUeTryWjbZn9AvhmMnkQDIkMRnjF5Fju7AIXHfz+yfuP5G7zHrdJ/s2GOiSeqsuHcXt
 7IWw==
X-Gm-Message-State: ABuFfohNdaTxJ01Tup3IDm1/q1z1Aeljrdrga3yhLQcD/fD3lyouo8j6
 IICmIolIvjSfSBIZBatAy3AC20n75zBKd9To2Cg=
X-Google-Smtp-Source: ACcGV63dmiBjZZzFh9JHJCeWx6QeXojyhK0q/st/KudSyPmGaD8sSMxwlxlkJMCs408KcUkUSvaI975gGwsn5E50AcI=
X-Received: by 2002:a05:6000:124e:: with SMTP id
 j14mr28510493wrx.315.1539889237044; 
 Thu, 18 Oct 2018 12:00:37 -0700 (PDT)
MIME-Version: 1.0
References: <20180911232906.18352-1-dg@adax.com>
 <20181017010412.23141-2-dg@adax.com>
 <2f51725f-c9f0-ccad-90e4-9ca8e4a8072d@intel.com>
In-Reply-To: <2f51725f-c9f0-ccad-90e4-9ca8e4a8072d@intel.com>
From: Dan Gora <dg@adax.com>
Date: Thu, 18 Oct 2018 16:00:00 -0300
Message-ID: <CAGyogRYsa+OhKYcU5iSL7oqbCaBoA7aAQEW8gMvff40CaDQ6Rw@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Igor Ryzhov <iryzhov@nfware.com>, 
 Stephen Hemminger <stephen@networkplumber.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v4 1/6] kni: add API to set link status on
	kernel interface
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2018 19:00:37 -0000

On Thu, Oct 18, 2018 at 10:44 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> KNI sample application calls this API each 100ms, so this keeps writing
> "carrier" file.
>
> What do you think writing to "carrier" file only if status changed?
>
> And it is possible to register to RTE_ETH_EVENT_INTR_LSC event in sample
> application instead of polling but not sure if all drivers supports it.

Yeah I'm not really interested in implementing this to be honest.  I
really don't have time.

> Or what do you think storing the link status in sample application and call this
> function only if link status changed?

No, one of the major points of this API was to NOT have to carry
around this state in the application.

d