From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by dpdk.org (Postfix) with ESMTP id 4B3B92BF9 for ; Tue, 11 Sep 2018 23:46:30 +0200 (CEST) Received: by mail-wr1-f46.google.com with SMTP id e1-v6so18499563wrt.3 for ; Tue, 11 Sep 2018 14:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=SRpp811Af9H73PbV6TDGJwmoc9izMmhZFPWxxPLMOn8=; b=iHKf40gQeqEvceVSQ7uQXaLTozOMxhH1P4XjUJId7E2PNpoxS2cfzACi6jc7hM+Lk/ g3T0HyX+9urZ9poLYr+nFB+yGYNa+hrrVA/m4p8+414J2xgLJ+AuU/qObXFrOBTzdlEO iHhp14tRLb4WN/LM6bnA3/PM9c3dHP29Wx+jFgneCxY2irnGbQXrXv1hj7Nilh0QBNTW f5UiIfV5EBTimLJg0Um50Uz7wGAC+tT+vvd6pFjXimicTndyeSduCyOs7W4s59Ozo0Ql a7EEBG3Ql8GADGQKKaedQWFkUk2Gl7joNiEhfAe5cpxOxy9l6ee8Nh4bcZODD5AlQciY Jerw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=SRpp811Af9H73PbV6TDGJwmoc9izMmhZFPWxxPLMOn8=; b=sjPzPb4JNHG3moRuK1/k22JKe34wxoscTnfCrMQU/aCv56qYou6dxPm9jHIim18eyb FATbL3W8DdmPWFP+bR8fCi1SBbF9Yn7kkfGnYPgIzjQtE/v0uudLhbZumzHMT4PD8ibq XFnGLLBia9Go6mFTIfqUsc+pK++5a564pRGdFQUu2tFiWeZFJCsAaXcKBQLkON1lxH3h CV8dnzXgHxkU6pqeZ+Fdzx6H3DA3L4G4H8wM8idgzhjWckbCxFs1KOnRPnWRW1EsjIXC ifV4XoqSKMaq5r/2MG0XRjz81t+fFz7XbF4EDQ0QSGx38zIZTJc2rZwaZxi6LxD33dCO 3OKw== X-Gm-Message-State: APzg51BbD0DgMlwz2NXhaj7lFe/uIaHwAy08J7Jfnl7ftZis87IY0yGV awrNNKw9JyFtrcJ2NB8muh3tqe+a0uUzwdDWs98= X-Google-Smtp-Source: ANB0VdbNenq8fBakVSqgLEk5fZCbgsVaxEYMlrQAbYVJsjsiaVOruKM/HlU8Z7lJTmCD//BF1NsBI7XvYLttIgalHwY= X-Received: by 2002:adf:f687:: with SMTP id v7-v6mr20008362wrp.201.1536702389631; Tue, 11 Sep 2018 14:46:29 -0700 (PDT) MIME-Version: 1.0 Sender: dan.gora@gmail.com Received: by 2002:adf:fbc1:0:0:0:0:0 with HTTP; Tue, 11 Sep 2018 14:45:49 -0700 (PDT) In-Reply-To: <20180905135751.74f6c14b@shemminger-XPS-13-9360> References: <20180628224513.18391-1-dg@adax.com> <20180629015508.26599-1-dg@adax.com> <20180629015508.26599-11-dg@adax.com> <20180829085410.4411c07e@xeon-e3> <20180829150014.0ae59128@xeon-e3> <20180829161043.11bb2434@xeon-e3> <20180830150911.6b0e7901@xeon-e3> <20180905135751.74f6c14b@shemminger-XPS-13-9360> From: Dan Gora Date: Tue, 11 Sep 2018 18:45:49 -0300 X-Google-Sender-Auth: Z_o2Z0YTk_Vw7cQKMxywtB_jaRw Message-ID: To: Stephen Hemminger Cc: Igor Ryzhov , Ferruh Yigit , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 21:46:30 -0000 Hi All, So I implemented the "write to /sys/devices/virtual/net/*/carrier" method to change the link status, but there is one more minor thing that I wanted to point out about this approach. The problem is that you cannot read or write the '/sys/devices/virtual/net/*/carrier' file while the interface is marked 'down'. This means that link status changes can only be performed by the DPDK application while the interface is in the "up" state. With the ioctl method, you can change the carrier state at pretty much any time. Is this a problem? It's not a huge one, I guess, but it is something else to consider. Please let me know what you all think. thanks dan