From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dan.gora@gmail.com>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
by dpdk.org (Postfix) with ESMTP id 944971B513
for <dev@dpdk.org>; Wed, 20 Jun 2018 19:04:21 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id n5-v6so767820wmc.5
for <dev@dpdk.org>; Wed, 20 Jun 2018 10:04:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:sender:in-reply-to:references:from:date:message-id
:subject:to:cc;
bh=rE3+9IDDNjD8LTOWctyjt/z3QnYqlSixvZzg/X793MY=;
b=LLYrO3cwT1247bwieFQ0vt8+aUlrjLjp7coUcOO7py0l3stVbEXvYTCR/R1PoOjdzQ
tFrHOE6j9MnjDE/WWRbAnxsz0wdVeOtJcsvovPmu7xcEpx53C8NoNcRN8hJHy4GJL4nX
OGVrhMk8ke7XRe/yudOmluOLeY792wV/z6rTrQJEZmZHk6ffAW7E3hverPY840SsLy/B
QlXuSYKe2bd8ClIfFONy+jQVQiW5eDAHyHCf2J0H+iwWfdppxBmt4wWjMaJTMmwc0KNc
JVH4q71nVCgmU/2Qky9rDRHZakQHGqLGsC6LlvbFDqy9Ui19r4MF8g98Ca0C5GUyw01E
JYrQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
:date:message-id:subject:to:cc;
bh=rE3+9IDDNjD8LTOWctyjt/z3QnYqlSixvZzg/X793MY=;
b=c8+RSa9FPpZWpBZzm+LhCJZV2qml9qzI0+MVJATO0AhHcR8XijtJQd9xR1IohWANyt
Vk9AbcSkgLbW0Aen0ONsI26z+ooH2sOtjiRe0V5G5Xy2GN1mHX0mFju+up9EMk0toLL6
H4FBy5un4YdNt0rDRXeNgJvC2UDxP8wgIQ1Edv+UNTk4t/ueVZRIlbQWmyZDFZ2A4hZQ
4uFfZmJBpkptR8oh/BFQhuUzWDHa2MhjrDFjMptkjXnJinL3YYQvgaryGGBGLOw6xHXL
2hrpYT0iDuhZ4y3EgLxh6Yzbvjn8rffcvveqtGaSsHT2emT/kihsMfotNhMkwzrst8eZ
QTVA==
X-Gm-Message-State: APt69E0PjTbx7xjSb6bla4jJDesfHPceGamRPEvFcMJ8ENMHfO+7dNNI
dliuhyKnWQLZPgT65YEM4DhG0k9K15cIZuijy18=
X-Google-Smtp-Source: ADUXVKLGv0J+36CWC/Qa3D+iCbcpnQiOWQ9nAbOe40G/7JkplGrp6ehXLx/l2+7LiIWnJNbwATdBBm2LL74j2JDD2mE=
X-Received: by 2002:a1c:4405:: with SMTP id r5-v6mr2191403wma.62.1529514261102;
Wed, 20 Jun 2018 10:04:21 -0700 (PDT)
MIME-Version: 1.0
Sender: dan.gora@gmail.com
Received: by 2002:adf:eb43:0:0:0:0:0 with HTTP; Wed, 20 Jun 2018 10:03:40
-0700 (PDT)
In-Reply-To: <d00e6b84-ac5a-dae0-fba6-5f40d0bf69b2@intel.com>
References: <20180620150122.45945-1-ferruh.yigit@intel.com>
<d00e6b84-ac5a-dae0-fba6-5f40d0bf69b2@intel.com>
From: Dan Gora <dg@adax.com>
Date: Wed, 20 Jun 2018 10:03:40 -0700
X-Google-Sender-Auth: tpRRtQrPggctai5ZtB7iJ9PF-U4
Message-ID: <CAGyogRaDw0mLLY+3w9_7JqAF3E2cHDfKOUkiFgXbtkHMDdahBA@mail.gmail.com>
To: "Hunt, David" <david.hunt@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>, Bruce Richardson <bruce.richardson@intel.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Remy Horton <remy.horton@intel.com>,
Ori Kam <orika@mellanox.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
John McNamara <john.mcnamara@intel.com>, Jijiang Liu <jijiang.liu@intel.com>,
dev@dpdk.org,
Liang Ma <liang.j.ma@intel.com>, Xueming Li <xuemingl@mellanox.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2018 17:04:21 -0000
Hi Ferruh,
Thanks for this.. I had started working on a patch to do this as well
because I got bit by this error.
Shouldn't all of the example applications also add the code to strip
the unsupported Tx and Rx offload bits as well? It would help new
users (like me!) to understand that this is a requirement for all
callers of rte_eth_dev_configure().
rte_eth_dev_info_get(port_id, &dev_info);
/* Only set the offload bits which are actually supported */
port_conf.txmode.offloads &= dev_info.tx_offload_capa;
port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
thanks
dan
On Wed, Jun 20, 2018 at 8:11 AM, Hunt, David <david.hunt@intel.com> wrote:
> Hi Ferruh,
> On 20/6/2018 4:01 PM, Ferruh Yigit wrote:
>>
>> ethdev layer introduced checks for application requested RSS hash
>> functions and returns error for ones unsupported by hardware
>>
>> This check breaks some sample applications which blindly configures
>> RSS hash functions without checking underlying hardware support.
>>
>> Updated examples to mask out unsupported RSS has functions during device
>> configuration.
>> Prints a log if configuration values updated by this check.
>>
>> Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Return error added in this release, so no need to backport the fix to
>> previous versions.
>>
>> Cc: David Hunt <david.hunt@intel.com>
>> Cc: Liang Ma <liang.j.ma@intel.com>
>> Cc: Xueming Li <xuemingl@mellanox.com>