From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 8ADF71B158 for ; Fri, 28 Sep 2018 01:06:06 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id z16-v6so392396wmi.3 for ; Thu, 27 Sep 2018 16:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lYIysICa+SeVvb0e2g6nCpgQRm/5dSARkBXIzm6GdpM=; b=Wsa6wp1GXJjDybBpCe45b2VtNO/utVTBM2Ag902l4atDsS1G4i/70drCscjpkwhWVt Jd8oYPTVSwANIm2Wsfb7uzuSYjLrVr0r2qC41bJiT9luh73k/96FoTMRyJqgUTi6z3fm j3aF+CIxX0uOuits4l4gt2kjXvo2GyG09B1zIpERQETTdBIZvfmZjzufT67z0jd2Y8w+ akGxMUKTbN20EBKqBN+kRKLxbx7Ze5xEvlGtKfJKio/OuJ0+T/rDBeDxBZ0oOTA9I8CJ 9UnMZ1xkvVCC+XNexiMaBfPvxt1LpOicWEdFEkv6IxdD1dwRibbt2EZVJooXUmZU9kDX 7rNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lYIysICa+SeVvb0e2g6nCpgQRm/5dSARkBXIzm6GdpM=; b=TAu+Sxs8TCL8kO2vGxUEyHFfBnhoEMWDOW42t10a2kwfYN9MMGbCAMmdtxh1lgOAJT nFoLZlVhJCthx4vG4XOMB9AeZ2+Z0yEJoxFEgl3wkt+NcPMK6S44jcuKfgYB6V6Pljby crnDOphiqh9/nTuP//dDeE17AZi+E/6L4LdplggL3tE4IxS2RqunefUiLDN2jctF2VAc 8Ize47GIycIFyuSseajFqOm9fImmZAHKAKmUH28FRSRaPwu3yqa2zs6p90G8+cuOXDmG MFkZLDpBC+9zS2XCqOQaXp7a5JHGlX3+Sj4htBhaQKSXblDHzuzISEXAjIbgPOEImfQB cI2A== X-Gm-Message-State: ABuFfogAcInqKNI2XB7MJ1i2TRIuDJc3HKU7aB4p3zT92R4F6yQBaLrQ JXNf2od9OirghUccBvtKhc1cP5jMu3F/sV8TVZA= X-Google-Smtp-Source: ACcGV632JZ9Y9KiihxMx9vpOrQ3WSarkAYpgB3UHJ36EqRn3IkQpWmT2JSIwMBaDbPOMXk7xajXT4woQlnmmg9yPt0U= X-Received: by 2002:a1c:1a48:: with SMTP id a69-v6mr413969wma.43.1538089565906; Thu, 27 Sep 2018 16:06:05 -0700 (PDT) MIME-Version: 1.0 Sender: dan.gora@gmail.com Received: by 2002:adf:fbc1:0:0:0:0:0 with HTTP; Thu, 27 Sep 2018 16:05:25 -0700 (PDT) In-Reply-To: References: <20180911232906.18352-1-dg@adax.com> <20180919195549.5585-1-dg@adax.com> <20180919195549.5585-2-dg@adax.com> <671135e5-a666-4254-c5c6-672c3863146b@intel.com> <61731242-db6c-0c5d-bcab-e82b45e324d7@intel.com> From: Dan Gora Date: Thu, 27 Sep 2018 20:05:25 -0300 X-Google-Sender-Auth: G10lsWBm4-BEgXL3r3FKWZ-L23g Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Igor Ryzhov , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 23:06:06 -0000 On Thu, Sep 27, 2018 at 6:49 PM, Ferruh Yigit wrote: >>> It would be useful if it writes the values of virtual interface, but this API >>> prints user input. >>> >> I'm sorry, Ferruh, I really don't understand what you are referring to >> here. What virtual interface are you talking about? > > Virtual interface is KNI interface, Linux virtual network interface. > > > Let me try again, > > You are adding a new API to KNI library, which is to set link status of KNI > interface. > > This API prints some link related values in its log. But these values are not > applied to KNI interface or not the values coming from KNI interface. These are > just values provided by user to the API, I am saying printing these values in > log can be confusing, the user may think API applies these values to KNI interface. Well, yes the link_status (link up, link down) _is_ applied to the KNI interface. When that occurs, most people want to know what the link speed is that the link came up at. Again, this is how every other Ethernet driver in linux works. I doubt that someone would be confused by that. If the KNI interface is purely virtual (that is, it does not correspond to any physical Ethernet port), then the DPDK application writer is under no obligation to use this API function, or they can use it and just set the speed to 0. If the end user understands that the KNI interface is purely virtual, then they should not be confused that the speed is 0 or that the duplex/autoNeg values are irrelevant. I just don't see how this could cause any confusion.