[dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

[dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

[Ferruh Yigit]

Commit 89397a01ce4a ("kni: set default carrier state of interface")
changes the KNI interface default carrier status. Which prevents traffic
flow by default and may break some existing usage / testing.

Document this behavior change in release notes.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Dan Gora <dg@adax.com>
---
 doc/guides/rel_notes/release_18_11.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index 6ce276b22..69c4d1bf6 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -383,6 +383,13 @@ API Changes
   This means ``ethtool "-a|--show-pause", "-s|--change"`` won't work, and
   ``ethtool <iface>`` output will have less information.
 
+* KNI, by default interface carrier status is ``off`` which means there won't be any traffic.
+  It can be set to ``on`` via ``rte_kni_update_link()`` API or via ``sysfs`` interface:
+  ``echo 1 > /sys/class/net/vEth0/carrier``. Note interface should be ``up`` to be able
+  to read/write sysfs interface.
+  When KNI sample application is used ``-m`` parameter can be used to automatically update
+  the carrier status for the interface.
+
 
 ABI Changes
 -----------
-- 
2.17.2

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

[Dan Gora]

Hi Ferruh,

On Mon, Nov 5, 2018 at 3:28 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Commit 89397a01ce4a ("kni: set default carrier state of interface")
> changes the KNI interface default carrier status. Which prevents traffic
> flow by default and may break some existing usage / testing.
>
> Document this behavior change in release notes.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Sorry about this.. I guess I should have done this with the patch series...

The changes here don't include the new module parameter to the KNI
kernel module.  I'll send a new release note patch in a few minutes
which hopefully covers everything.  I guess the test plan
documentation needs to be updated as well, but I don't know where
those documents live.  Are they separate from the main DPDK source?


thanks
dan

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

[Ferruh Yigit]

On 11/5/2018 6:12 PM, Dan Gora wrote:
> Hi Ferruh,
> 
> On Mon, Nov 5, 2018 at 3:28 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> Commit 89397a01ce4a ("kni: set default carrier state of interface")
>> changes the KNI interface default carrier status. Which prevents traffic
>> flow by default and may break some existing usage / testing.
>>
>> Document this behavior change in release notes.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Sorry about this.. I guess I should have done this with the patch series...
> 
> The changes here don't include the new module parameter to the KNI
> kernel module.  I'll send a new release note patch in a few minutes
> which hopefully covers everything.  I guess the test plan
> documentation needs to be updated as well, but I don't know where
> those documents live.  Are they separate from the main DPDK source?

There is no test plan documentation within dpdk repo. There is DTS (dpdk test
suit) in a separate repo [1], which needs to be updated, and indeed this patch
is to point them the change because existing test is failing after changes...

[1]
https://git.dpdk.org/tools/dts/

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

[Dan Gora]

On Mon, Nov 5, 2018 at 4:21 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> There is no test plan documentation within dpdk repo. There is DTS (dpdk test
> suit) in a separate repo [1], which needs to be updated, and indeed this patch
> is to point them the change because existing test is failing after changes...
>
> [1]
> https://git.dpdk.org/tools/dts/

Should patches for the DTS get sent to this list (dev@dpdk.org) as
well or is there are separate list for those?

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

[Dan Gora]

On Mon, Nov 5, 2018 at 4:23 PM Dan Gora <dg@adax.com> wrote:
>
> On Mon, Nov 5, 2018 at 4:21 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > There is no test plan documentation within dpdk repo. There is DTS (dpdk test
> > suit) in a separate repo [1], which needs to be updated, and indeed this patch
> > is to point them the change because existing test is failing after changes...
> >
> > [1]
> > https://git.dpdk.org/tools/dts/
>
> Should patches for the DTS get sent to this list (dev@dpdk.org) as
> well or is there are separate list for those?

Never mind.. It's in the CONTRIBUTING.TXT file.. RTFM, dan..

======
Contributions to DTS should be submitted as git formatted patches to the
DTS mailing list: dts@dpdk.org
======

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

[Thomas Monjalon]

05/11/2018 18:28, Ferruh Yigit:
> Commit 89397a01ce4a ("kni: set default carrier state of interface")
> changes the KNI interface default carrier status. Which prevents traffic
> flow by default and may break some existing usage / testing.
> 
> Document this behavior change in release notes.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks