From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 513274CA9 for ; Wed, 24 Oct 2018 22:57:27 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id l6-v6so7050687wrt.1 for ; Wed, 24 Oct 2018 13:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zrXogILNIgfSnCRl8RcL9d4+rxNrolA+/nY2+c3I2ss=; b=aZaBii72s4MlZVrYYU1v6djCL+4Vio9Mj9xXlPQO8DUe6t9BjaVVk2IV7BpGCh2XPF 1ZCSm45SyQcpSZE7pX93f2iIrH1o9/CJSaiBFVvPWK/8XvIu90Sq4jV+f07xpSYWOtR9 U3uDaN2TFStOJjD3QUMSi9ETVDR0ZGrI93222LuusGYyV+cTyK/qVpRZPxcV3dajSw1V Zeoqbny2D1Dk0BgjYvx414GFeyRQ75bar19OXjmfuk4xKc8CVjGBAff5jbkwbFMz5ksq Ll4rILuUY0E9lrmtC9GWAhNrQcgPvZxSSnTvdr4k4oms4w10cPznvczXffDLQ5kXeL6+ u+hA== X-Gm-Message-State: AGRZ1gIXIgGJgaCGLw+z0gMFPcxVw0zcI1zYVUAIOgIaTsJnwbhQH35B p2rF9gRzp8bp2c1gbR27loxAgpxO8K92MlmYEbE= X-Google-Smtp-Source: AJdET5fb6WEAnVcMJcXJwx63CMBQKYI/B6umGOkPlYqTkxkrcGKm8A9NpFOhX1AD69p6olG4PSO5nDJtg6rVlhqLmn4= X-Received: by 2002:adf:94e2:: with SMTP id 89-v6mr1310333wrr.25.1540414646706; Wed, 24 Oct 2018 13:57:26 -0700 (PDT) MIME-Version: 1.0 References: <20180911232906.18352-1-dg@adax.com> <20181024202719.24902-1-dg@adax.com> <20181024202719.24902-5-dg@adax.com> <20181024134602.5511fa0b@xeon-e3> In-Reply-To: <20181024134602.5511fa0b@xeon-e3> From: Dan Gora Date: Wed, 24 Oct 2018 17:56:50 -0300 Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, Igor Ryzhov , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 20:57:27 -0000 On Wed, Oct 24, 2018 at 5:46 PM Stephen Hemminger wrote: > > + pid = getpid(); > > + RTE_LOG(INFO, APP, "========================\n"); > > + RTE_LOG(INFO, APP, "KNI Running\n"); > > + RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid); > > + RTE_LOG(INFO, APP, " Show KNI Statistics.\n"); > > + RTE_LOG(INFO, APP, "kill -SIGUSR2 %d\n", pid); > > + RTE_LOG(INFO, APP, " Zero KNI Statistics.\n"); > > + RTE_LOG(INFO, APP, "========================\n"); > > + fflush(stdout); > > + > > Thanks for updating the example to cover the new code. > > This seems like an overly wordy message which should really be in the documentation > not a billboard in the code. > > In my opinion, having verbose messages is unhelpful since it just clutters > the experience. Sigh... This is version 6 of this patch. You could have said something about it at any point in the last two and a half months that I have been struggling to get this merged. These "features" were never documented at all, so you would have no idea they existed unless you read the code. The point of this patch is that you can just copy and paste the commands directly from the screen. This saves you from having to type 'ps -ef|grep kni', cut the PID, type 'kill -SIGUSR1', then paste the PID. How is that easier that what I have done? And it's not a billboard, it's 7 lines. Have you actually tried it? The amount of nitpicking on these patches has been just incredible.. People get entire subsystems merged with 1/10th the hassle that I've been given to add one stupid function. It's extremely frustrating. I've totally given up on trying to get my other KNI patches merged.. It's just not worth it.. dan