From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D869A0350; Mon, 29 Jun 2020 23:15:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A31531BF60; Mon, 29 Jun 2020 23:15:03 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id D7BF51BF46 for ; Mon, 29 Jun 2020 23:15:02 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id r12so8568155ilh.4 for ; Mon, 29 Jun 2020 14:15:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kFAuokXkAXu3sy1/J/EamcTAXr0+wr8oLsWa709Uee8=; b=ftVnJArJn5Ru/sNaY5xh0ink7jV96gn6OIZCxKg1WRcrC29XHRXxPNwkpn6AOWEcen ZemBDvmtrA2URt8hcGjSh7xspe2+yBvJFxTwtlGb0LgUlurnMbloUBSMX+t1oORX3xaC 0Bh77mSqmBdo0m1j+CqchTWtnmchbgVCvI0HOsGcJrfH5Dk1xlWKBVSSmGNrdqga3jlR s1yUhZjEI+IYtkpxJjXJD8fHriOx/r9sLwzO8KmZmrzvIXD2icEbcJsPTaiRrHktdjaJ xJDeW7mnNd/VY3S66lhCW+UflCPZovqoGsUKJiWV7/v7tNZ1+mGmeVN7yoC3qrJwFFAg nBQQ== X-Gm-Message-State: AOAM5306rAin3j30OFWUyrWksIdQbCK8HQqr9u0Uc/FgSB8fQeEsJgrC tnETi139ZMrahlnM/LDniX2nLd9JEmYxzX87ssM= X-Google-Smtp-Source: ABdhPJzGEzS32cG/sS177ZoG5uX+S+wqSkWfevmCmxC9Og1Jkj7ODH8ZgMLzzZgVkCcwRvrdkqcfHNZwzzYn1REfvsE= X-Received: by 2002:a92:4b08:: with SMTP id m8mr17097716ilg.150.1593465302214; Mon, 29 Jun 2020 14:15:02 -0700 (PDT) MIME-Version: 1.0 References: <20200421195446.1730-1-dg@adax.com> <20200422234255.7066-1-dg@adax.com> <7c4c38bb-ecec-8cad-1220-c6a057574e0e@ericsson.com> In-Reply-To: From: Dan Gora Date: Mon, 29 Jun 2020 18:14:26 -0300 Message-ID: To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: "dev@dpdk.org" , David Marchand , Jerin Jacob , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v4 0/2] eal: choose initial PRNG seed source at runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 29, 2020 at 6:06 PM Mattias R=C3=B6nnblom wrote: > > It's unlikely to fail, and if it does something is probably seriously > wrong with your system. You also seem to think it might fail, since you > take great care of setting errno and having non-zero return code in > __rte_getentropy(). Well, no, I don't personally think that it will fail and certainly even if a read call to /dev/random fails, the whole function will not fail. As I said, I was trying to emulate the glibc getentropy and all its semantics. > From what I recall, it was Bruce that suggested rdseed should be > included as one of the sources. I have no opinion on that particular > subject, other than I think kernel-originated randomness should have > priority. In light of new attacks on rdseed, it should probably just be removed, IMHO= . https://www.phoronix.com/scan.php?page=3Darticle&item=3Dcrosstalk-srbds-vul= nerability&num=3D1 thanks d