Re: [dpdk-dev] [PATCH v5 3/5] examples/kni: monitor and update link status continually

[Dan Gora <dg@adax.com>]

On Mon, Oct 22, 2018 at 9:51 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > +Running the kni Example Application
> > +-----------------------------------
> >
> > -Loading the KNI kernel module without any parameter is the typical way a DPDK application
> > -gets packets into and out of the kernel net stack.
> > -This way, only one kernel thread is created for all KNI devices for packet receiving in kernel side:
> > +The ``kni`` example application requires a number of command line options:
> >
> >  .. code-block:: console
> >
> > -    #insmod rte_kni.ko
> > +    kni [EAL options] -- -P -p PORTMASK --config="(port,lcore_rx,lcore_tx[,lcore_kthread,...])[,(port,lcore_rx,lcore_tx[,lcore_kthread,...])]"
>
> + [-m]:
>
> kni [EAL options] -- -P -p PORTMASK
> --config="(port,lcore_rx,lcore_tx[,lcore_kthread,...])[,(port,lcore_rx,lcore_tx[,lcore_kthread,...])]"
> [-m]
>
> Can be added while merging.
>

ugh.. ok... I'll fix this... I thought I added it, but I guess I missed it here.

> > -Callbacks for Kernel Requests
> > -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > -
> > -To execute specific PMD operations in user space requested by some Linux* commands,
> > -callbacks must be implemented and filled in the struct rte_kni_ops structure.
> > -Currently, setting a new MTU, change in MAC address, configuring promiscusous mode and
> > -configuring the network interface(up/down) re supported.
> > -Default implementation for following is available in rte_kni library.
> > -Application may choose to not implement following callbacks:
> > -
> > -- ``config_mac_address``
> > -- ``config_promiscusity``
>
> I am for keeping this section, is there any specific reason to remove this?

Just because it's not really relevant to the KNI sample app.
Information about the KNI callbacks was moved to the main KNI
documentation page and updated there.

I'll update the info there to add the details that there are default
implementations for these two callbacks if they don't specify one.

thanks
d