From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 2392A1B462 for ; Mon, 22 Oct 2018 22:05:17 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id w186-v6so356649wmf.0 for ; Mon, 22 Oct 2018 13:05:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2yp44NgUC7P9HbJlP8wRaHpjmYAyAOEuC8EFDHHUneY=; b=UDwxy7S2zK6liqBGBa8UIfJ6ohBjcoEDX5UuH9ylmukUil8ewDzEq4MfQTlms/02vo 47i+Jtliu6RuWd+9cp3jEIM88ZTp2W73D8eq5B3Wbw0G+Z42Pe2S2NcQzeY+cc30c3FQ FaJOr8H+1oUdwLEzfYmalS0j/F5uVugvGd0ae6Gx0KeH323CPQuioBCzoZh+sRbIJSk8 v7056A8VWgEbS45jhMszGFeM0o7ZEek09jS4fZCNGA5/QFVk1Kk9CScyz2PAVyMLiLsv E+Iv5X9qzXWQsKT8DepBy+wwlwCRnxp2PvSNWP5ceaa7oh9xNkB1YrjV8EdofYTJINNW Z5tw== X-Gm-Message-State: ABuFfogGBdzvaesOdUGP4fxQTeJw0MlQv8rhlCd5LzB4ln3k/CqUwwoz P+KDpf1ZoDnLc+mTrJ75hut3/IchJ3cOy4zTUY8= X-Google-Smtp-Source: ACcGV63KL+AHcp+9FCPJ+288x+DfHTykxoCQ8wvpY9KbTwph1y574GoXhNxs5EAfIVxISk62s2oqj5hFPxoX7s/9gV0= X-Received: by 2002:a1c:5801:: with SMTP id m1-v6mr17013499wmb.118.1540238716318; Mon, 22 Oct 2018 13:05:16 -0700 (PDT) MIME-Version: 1.0 References: <20180911232906.18352-1-dg@adax.com> <20181019002358.17132-1-dg@adax.com> <20181019002358.17132-4-dg@adax.com> <7e26ad9a-612d-cf87-6d76-ea36224a5c01@intel.com> In-Reply-To: <7e26ad9a-612d-cf87-6d76-ea36224a5c01@intel.com> From: Dan Gora Date: Mon, 22 Oct 2018 17:04:38 -0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Igor Ryzhov , Stephen Hemminger , John McNamara , Marko Kovacevic Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 3/5] examples/kni: monitor and update link status continually X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 20:05:17 -0000 On Mon, Oct 22, 2018 at 9:51 AM Ferruh Yigit wrote: > > +Running the kni Example Application > > +----------------------------------- > > > > -Loading the KNI kernel module without any parameter is the typical way a DPDK application > > -gets packets into and out of the kernel net stack. > > -This way, only one kernel thread is created for all KNI devices for packet receiving in kernel side: > > +The ``kni`` example application requires a number of command line options: > > > > .. code-block:: console > > > > - #insmod rte_kni.ko > > + kni [EAL options] -- -P -p PORTMASK --config="(port,lcore_rx,lcore_tx[,lcore_kthread,...])[,(port,lcore_rx,lcore_tx[,lcore_kthread,...])]" > > + [-m]: > > kni [EAL options] -- -P -p PORTMASK > --config="(port,lcore_rx,lcore_tx[,lcore_kthread,...])[,(port,lcore_rx,lcore_tx[,lcore_kthread,...])]" > [-m] > > Can be added while merging. > ugh.. ok... I'll fix this... I thought I added it, but I guess I missed it here. > > -Callbacks for Kernel Requests > > -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > - > > -To execute specific PMD operations in user space requested by some Linux* commands, > > -callbacks must be implemented and filled in the struct rte_kni_ops structure. > > -Currently, setting a new MTU, change in MAC address, configuring promiscusous mode and > > -configuring the network interface(up/down) re supported. > > -Default implementation for following is available in rte_kni library. > > -Application may choose to not implement following callbacks: > > - > > -- ``config_mac_address`` > > -- ``config_promiscusity`` > > I am for keeping this section, is there any specific reason to remove this? Just because it's not really relevant to the KNI sample app. Information about the KNI callbacks was moved to the main KNI documentation page and updated there. I'll update the info there to add the details that there are default implementations for these two callbacks if they don't specify one. thanks d