From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4772DA04BA; Wed, 7 Oct 2020 06:46:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E20D2C16; Wed, 7 Oct 2020 06:46:44 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 0D5FC29AC for ; Wed, 7 Oct 2020 06:46:43 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id u19so1032785ion.3 for ; Tue, 06 Oct 2020 21:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EJEQA+hqfNPydYAOalB2iC/2Pqv4iGiDA3MVO6xj5GQ=; b=EbqYygDYpOBpEz2OzaZ8qnQ9OTchCPsQvfcKKKbszxdMvumYLTUCho+cphEsVw2ZD5 gmwRC2LCOKF24Df9qgf00kzY6yO6d5OwZtuKD65i4jtMZBTNlB8P4P1Q/b/buJu2o42V KZ2IAnXM3rv2slKrVf4Xct1Bwz1FBdxGZbDc0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EJEQA+hqfNPydYAOalB2iC/2Pqv4iGiDA3MVO6xj5GQ=; b=h5UjTNQef76zZU6VoOEmtGlBqZ/VYXgP9ZXnlDG8vjzB0spLU2s+2n7OJh65u42RqH W3OxJzCsXjdxC4TvqMyek+AnetEaFv36Qkx5Jqp/1jo2hLEGi3gH2OZVC3/v9ZkBSA7U c3Jcu0dkgobWGrNHX32VutSoB6I/3iXdIpWzZfI0oZ0rTcvquaAngiMJyIAg1hXJGrRv 8aBCANv+wcspHiNIMGXnl5ltZVpCUH6KDw31ZDGnegbWzFXw1ObLpzb7+lAkyG3G/NAJ AWuQMwG0l2RTOYf3lEDP8/+RXEP4gNro3s2RyALU8wQZ30uC2RyXB47k0QusDMkvamAX 6U0Q== X-Gm-Message-State: AOAM5338kdoDngo6TxKNh83hW7XMmCUXZEAF7ktCuSekunXc0/UgtUWq O86LfRyq+QaiRAMkjw20Sdv0ecnhvjtQ5Vy2kELl2Q== X-Google-Smtp-Source: ABdhPJzxP3rZw+hRzJpVo6fwKTkz5Ee/Pl8SZ86WhuS5TndkfAejmOKE9ocVRlUcxb8zc/kDZhCFbsajszSMh0IC7Z4= X-Received: by 2002:a05:6602:2354:: with SMTP id r20mr894092iot.93.1602046001142; Tue, 06 Oct 2020 21:46:41 -0700 (PDT) MIME-Version: 1.0 References: <20200122101654.20824-1-kalesh-anakkur.purayil@broadcom.com> <20200930123314.27669-1-kalesh-anakkur.purayil@broadcom.com> <20200930123314.27669-4-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: From: Kalesh Anakkur Purayil Date: Wed, 7 Oct 2020 10:16:30 +0530 Message-ID: To: Ophir Munk Cc: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC PATCH v4 3/3] app/testpmd: handle device recovery event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ophir, Thank you for the comments. I will address them in the next version. I will push these changes as Patches next time and not as an RFC. Hope that is OK. Regards, Kalesh On Tue, Oct 6, 2020 at 10:55 PM Ophir Munk wrote: > Hi Kalesh, > Please find a few comments. > The name you gave to the event (EVENT_RESET) is very close to an already > existing one: "EVENT_INTR_RESET". > But they are different. > EVENT_INTR_RESET originates from a port reset. It requires application > reaction. It is widely used. It is documented in *.rst files. > EVENT_RESET originates from FW error (or maybe any error). It requires no > application reaction (PMD manages by itself). It is not documented. > I therefore suggest renaming it (maybe EVENT_ERR_RECOVERING) and please > document it in *.rst files. > More comments below: > > > -----Original Message----- > > From: dev On Behalf Of Kalesh A P > > Sent: Wednesday, September 30, 2020 3:33 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [RFC PATCH v4 3/3] app/testpmd: handle device > recovery > > event > > > > From: Kalesh AP > > > > Added code to handle device reset and recovery event in testpmd. > > This is an indication from the PMD that device has reset and recovered > error > > condition. > > > > Signed-off-by: Kalesh AP > > Reviewed-by: Ajit Kumar Khaparde > > --- > > app/test-pmd/testpmd.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > fe6450c..1c8fb46 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -380,6 +380,8 @@ static const char * const eth_event_desc[] = { > > [RTE_ETH_EVENT_NEW] = "device probed", > > [RTE_ETH_EVENT_DESTROY] = "device released", > > [RTE_ETH_EVENT_FLOW_AGED] = "flow aged", > > + [RTE_ETH_EVENT_RESET] = "device reset", > > "device reset" is similar to the existing "reset" string. Can you suggest > a different one? Maybe "error under recovery" ? > > > + [RTE_ETH_EVENT_RECOVERED] = "device recovery", > > Wouldn't you prefer "device recovered" ? > > > [RTE_ETH_EVENT_MAX] = NULL, > > }; > > > > @@ -394,7 +396,9 @@ uint32_t event_print_mask = (UINT32_C(1) << > > RTE_ETH_EVENT_UNKNOWN) | > > (UINT32_C(1) << RTE_ETH_EVENT_IPSEC) | > > (UINT32_C(1) << RTE_ETH_EVENT_MACSEC) | > > (UINT32_C(1) << RTE_ETH_EVENT_INTR_RMV) | > > - (UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED); > > + (UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED) | > > + (UINT32_C(1) << RTE_ETH_EVENT_RESET) | > > + (UINT32_C(1) << RTE_ETH_EVENT_RECOVERED); > > /* > > * Decide if all memory are locked for performance. > > */ > > -- > > 2.10.1 > > -- Regards, Kalesh A P