From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 852C2A0C43; Mon, 15 Nov 2021 04:41:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AB2440E01; Mon, 15 Nov 2021 04:41:15 +0100 (CET) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id 72ABF40141 for ; Mon, 15 Nov 2021 04:41:14 +0100 (CET) Received: by mail-ed1-f41.google.com with SMTP id b15so65292259edd.7 for ; Sun, 14 Nov 2021 19:41:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t9gNiSa96ZtPhkJpMTG+p9xVAcQR9IZa9O/e3c3vDco=; b=cTIAImgJRNJZlK338QtZFA/S2sf2z4PxsImfAMLnkv3ugwsonbuWzwU0Au7Ku11bIl u0Li4LfEWMriNe26CuyWRRx3RZsK62+HAXLDcP07/yGZilgb8gcmfR47OMQnFEEDBt71 jgkpup1lSMmbdSEbBxl0x0llMaL7ldXXeV/Cw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t9gNiSa96ZtPhkJpMTG+p9xVAcQR9IZa9O/e3c3vDco=; b=CqZWJjY1DAERiU1YAuWxOXQgu84xQ9dJZqV7M8IJlb7ClBBn3Qn3rao9U9KgQLox5S 83Q5iXJuwd+ttu1ErIj1XToEK2qZlByVP0kZVqDxNOY+5J1IMWErkKm8OzO0cf+P6CXp W9xyn1GRIRtJm+U112xWF2qTcRGTftZazNeKVZ7zRDK+o6wRyKBc02YN+X7WzqVJL/It eN6eXhSl1wvHCU6gI+MLgB6mKFDKvvVxaNK/JCWNN0HAqXFlQemKNXZWzbam/oA+J+R3 x4vE3pTmmV66mbxvVjJXyycHfaBUF0vj0oe48h4akw2YFPomyXddjxvmgyl6vgh2k89h BNFg== X-Gm-Message-State: AOAM532dMez+ADm/w3W+PkUv5eleyHM0hY8nupqGwCop7sWDqNbhPJkX V43MO2uGYS/ObAPAvOrRXMIC45B5B2RJ0z6PCvoY0A== X-Google-Smtp-Source: ABdhPJzphOT1zr+ZvToNRKLDPC6mpsGGcC20Ex00MQugt4ZIJk6kxzB7G4/hFx6vhes0qMbszcsiJgt+0BY0TOU7aIk= X-Received: by 2002:a17:906:2f97:: with SMTP id w23mr45276373eji.31.1636947673797; Sun, 14 Nov 2021 19:41:13 -0800 (PST) MIME-Version: 1.0 References: <20211109210403.114391-1-stephen@networkplumber.org> <20211110161848.34050-1-stephen@networkplumber.org> In-Reply-To: <20211110161848.34050-1-stephen@networkplumber.org> From: Kalesh Anakkur Purayil Date: Mon, 15 Nov 2021 09:11:03 +0530 Message-ID: Subject: Re: [PATCH v2] test/bpf_convert: do not require DNS lookup To: Stephen Hemminger Cc: Konstantin Ananyev , Luca Boccassi , dpdk-dev Content-Type: multipart/alternative; boundary="0000000000009d4b9b05d0cb94dd" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000009d4b9b05d0cb94dd Content-Type: text/plain; charset="UTF-8" On Wed, Nov 10, 2021 at 9:48 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > These tests were using strings with hostname (dpdk.org) and this makes > test code do a DNS lookup. In container environment used for OpenSuse > build, DNS is unavailable. Replace dpdk.org with an IPv4 address > extra space character before Replace? > reserved for documentation (RFC 5737) and use IPv6 in one example (RFC > 3849). > Actual addresses don't matter for this test whichis validating tke > Missing space between which and is and typo in "the" > classic BPF to eBPF for common cases. > > Signed-off-by: Stephen Hemminger > --- > v2 - use RFC reserved address > > app/test/test_bpf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c > index ef861d05e755..785f3e689e10 100644 > --- a/app/test/test_bpf.c > +++ b/app/test/test_bpf.c > @@ -3359,8 +3359,8 @@ static const char * const sample_filters[] = { > "dst net 192.168.0.0/24", > "dst net 192.168.0.0 mask 255.255.255.0", > "port 53", > - "host dpdk.org and not (port 80 or port 25)", > - "host dpdk.org and not port 80 and not port 25", > + "host 192.0.2.1 and not (port 80 or port 25)", > + "host 2001:4b98:db0::8 and not port 80 and not port 25", > "port not 53 and not arp", > "(tcp[0:2] > 1500 and tcp[0:2] < 1550) or (tcp[2:2] > 1500 and > tcp[2:2] < 1550)", > "ether proto 0x888e", > -- > 2.30.2 > > -- Regards, Kalesh A P --0000000000009d4b9b05d0cb94dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Nov 10, 2021 at 9:48 PM Steph= en Hemminger <stephen@netw= orkplumber.org> wrote:
These tests were using strings with hostname (dpdk.org) and this ma= kes
test code do a DNS lookup. In container environment used for OpenSuse
build, DNS is unavailable.=C2=A0 Replace dpdk.org with an IPv4 address
extra space character before Replace?
reserved for documentation (RFC 5737) and use IPv6 in one example (RFC 3849= ).
Actual addresses don't matter for this test whichis validating tke
<= /blockquote>
Missing space between which and is and typo in "the&q= uot;=C2=A0
classic BPF to eBPF for common cases.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2 - use RFC reserved address

=C2=A0app/test/test_bpf.c | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c
index ef861d05e755..785f3e689e10 100644
--- a/app/test/test_bpf.c
+++ b/app/test/test_bpf.c
@@ -3359,8 +3359,8 @@ static const char * const sample_filters[] =3D {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "dst net 192.168.0.0/24",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "dst net 192.168.0.0 mask 255.255.255.0&qu= ot;,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "port 53",
-=C2=A0 =C2=A0 =C2=A0 =C2=A0"host dpdk.org and not (port 80 or port 25)"= ;,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0"host dpdk.org and not port 80 and not port 25&q= uot;,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0"host 192.0.2.1 and not (port 80 or port 2= 5)",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0"host 2001:4b98:db0::8 and not port 80 and= not port 25",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "port not 53 and not arp",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "(tcp[0:2] > 1500 and tcp[0:2] < 155= 0) or (tcp[2:2] > 1500 and tcp[2:2] < 1550)",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "ether proto 0x888e",
--
2.30.2



--
Regards,
Kalesh A P
--0000000000009d4b9b05d0cb94dd--