From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E9E8A00C5; Thu, 7 May 2020 12:32:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0385C1DBA5; Thu, 7 May 2020 12:32:48 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 1016B1DBA2 for ; Thu, 7 May 2020 12:32:47 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id i16so1719041ils.12 for ; Thu, 07 May 2020 03:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g96Sj+132QyYPkUPZJZ+Q6lLYd51W6zW3dA/3vJYVoo=; b=UmhK34XrjMizSu1bhRnsA41fr8cOz7VAuavYJSpVdHIUZt0C0L8i1KrYTegooz51wU XZVcnvqd6BAPAqwhjnHdDBkh+tAdrnJf5vE/93XEx9BfiFKrlU/utjVIMtPGfJj59x+d KoXN2CEzkJeyhZPqTyY0jkMGHw5B2Jpbyri84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g96Sj+132QyYPkUPZJZ+Q6lLYd51W6zW3dA/3vJYVoo=; b=DtL4ek1vWatMOLnW9N535wakxs1fxcMK/he2eH4r2AOtGfXR8rIks0CkwgTphx/r9w P2CnOjfP6nvj5CPKZPE3rg5/ZRYTi2jIeG0WCqgDl4L+utKO/WGeWRNzRUKLN4AFb7cI Yp6tuDagc0dEM/ew/IYDGbVWRQgWJjhpZEM3NUq9aP5nDG9/I8oT9HE9iCoaZIBPkJKY Wi6iLLL2j6E9aHHR8XP6vX9HUXXK0ux4Vws4tOIaHL0Y3vbhtEEq/12U2lHldohSJAfu XNq7A8jwU5MMcpdCjr/LaFuS79iqBUDoqDw7tp8qOUZ9na+KVWL9MO3ZNz6NqoTML4vl UQ2A== X-Gm-Message-State: AGi0PuYH7eYq3DNucU7toYHfHQnF0fIbj83PTuBIzNcRcGdfqbPgt2Ru 0A8Jemhv2lhW/Ux/JRouDNSwbPJFpF7umDRuzDeBuw== X-Google-Smtp-Source: APiQypJOLGNuvsAW9Y96Ij0l3nfri4hpsRdQtHPREaYtv905PVQ8IRKTEzTSCvNH5plq5yEPntKuTQPVuDeHHreyzmI= X-Received: by 2002:a92:8fc4:: with SMTP id r65mr13231318ilk.179.1588847566202; Thu, 07 May 2020 03:32:46 -0700 (PDT) MIME-Version: 1.0 References: <20200507090827.27945-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: From: Kalesh Anakkur Purayil Date: Thu, 7 May 2020 16:02:34 +0530 Message-ID: To: "Iremonger, Bernard" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "Xing, Beilei" , "Wu, Jingjing" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bernard, On Thu, May 7, 2020 at 3:18 PM Iremonger, Bernard < bernard.iremonger@intel.com> wrote: > Hi Kalesh, > > > -----Original Message----- > > From: Kalesh A P > > Sent: Thursday, May 7, 2020 10:08 AM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; Xing, Beilei > > ; Wu, Jingjing ; > Iremonger, > > Bernard > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing > > issue > > > > From: Kalesh AP > > > > Note that the issue was observed in an internal Coverity scan. > > > > Fixes: e088907bb851 ("app/testpmd: add command for getting loaded DDP > > profiles") > > Cc: stable@dpdk.org > > > > Signed-off-by: Kalesh AP > > --- > > app/test-pmd/cmdline.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > b040630..996a498 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -16891,8 +16891,10 @@ cmd_ddp_get_list_parsed( #ifdef > > RTE_LIBRTE_I40E_PMD > > size = PROFILE_INFO_SIZE * MAX_PROFILE_NUM + 4; > > p_list = (struct rte_pmd_i40e_profile_list *)malloc(size); > > - if (!p_list) > > + if (!p_list) { > > printf("%s: Failed to malloc buffer\n", __func__); > > + return; > > + } > > > > if (ret == -ENOTSUP) > > ret = rte_pmd_i40e_get_ddp_list(res->port_id, > > -- > > 2.10.1 > > ./devtools/check-git-log.sh -1 > Wrong headline case: > "app/testpmd: fix NULL pointer dereferencing issue": NULL --> null > [Kalesh]: will fix it. > Missing 'Coverity issue:' tag: > app/testpmd: fix NULL pointer dereferencing issue > [Kalesh]: This was found in an internal scan. So there is no Coverity issue tag for this. > > Regards, > > Bernard. > -- Regards, Kalesh A P