From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D52B48AAD; Sat, 8 Nov 2025 13:59:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EDAE40261; Sat, 8 Nov 2025 13:59:36 +0100 (CET) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by mails.dpdk.org (Postfix) with ESMTP id 44DA540264 for ; Fri, 7 Nov 2025 10:51:43 +0100 (CET) Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8906eb94264so62950485a.0 for ; Fri, 07 Nov 2025 01:51:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762509102; x=1763113902; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mTIj8EliqdXUWa0KGp4Jy/hf1p1P+uPkiIWQFfZ64Xo=; b=NkEG8F6s9UfMNIQcOWkMwG2L2ShK1jztF5ZhDUBGAwJd0sq6abiUPsgHyb4nTXzouH pOvO/gRqfXpjwmNxq1bY5JetW+pQLPpfoPXAvgC2Zsp/TMkg6O0JYtq4JlzWGCgtgK0u 4jnArB2yQ0AVFB7bA9ZRXuuzsMRN4eDHTI1N0HGP5B3WIf8xUwPtda2ZM4/F4HyNHgKu QLVOapHyuuJcQYjJekQaxmr5UUjy/vBsx2uz2jWHVlkdPyrOTakKbHFalTa/yKoPoZYx fSmnLA/QvHaprvpm8ecbsHJ1w1n2TaCLtFCdcxLq8a/duIIQvq8n6QjXCm/idGlDJ2+H qmXw== X-Forwarded-Encrypted: i=1; AJvYcCWpEGomSnAM8yISqSZTKElZHKXkxM2ga32biG3I9pAeZ94nPPQhL9EI3Di7pY3Mdl+uYlk=@dpdk.org X-Gm-Message-State: AOJu0YylrfXX0b1zOxnUaO+6b7ZpdlzirL/zseQqtaCCoNZCgPC34o50 gJo5urNDjOAl2V2D3LKqx0gHyEPCz6QV/VOBcwaOjfPrDlNQPfHYu5chLbGb9UkRi9FaoUkLU1q WbkKZnERwR6pXREwJ/rFmTon0B5Gyg4s= X-Gm-Gg: ASbGnctFNDHECM925PNK6lmx5SNZ0EW75/RCSDcvdlbT05wUEc9uDXyjq+jO9cgzez0 c7IEkMPEUN9nAzSSlehyU7c0Exh22CiFay140lVfUp4nOrHG8Y738fgM/h/zLxkYisUITttJbdK ZxW6Lgf8eKPuo5xDKwzmP8+xm/f5MGLshZ/P3Cl43BlGFaG6P4+aUmRMehh8c5U+OgIPzS18q3w BV2vIzZrFeR7mxf6FshTp3T4rX3nLVFSUxQWf1s6c0uT5AB4JXV+AddHq1rmqK+wYRGYDNMiBjR qD57T2cMH1ggfdCFrQ== X-Google-Smtp-Source: AGHT+IFxC5VlQQYivM2sz9s3MICTdv9CSiW7yD7GN+I9RNS48FcrOh2Ce7aa9NsQAl6BiF7yiMS6Ff+7obkKJJra3W4= X-Received: by 2002:a05:620a:1aa2:b0:84a:d3ce:c749 with SMTP id af79cd13be357-8b2453520b1mr301017185a.64.1762509102474; Fri, 07 Nov 2025 01:51:42 -0800 (PST) MIME-Version: 1.0 References: <20251106163807.201451-1-hemant.agrawal@nxp.com> <20251106163807.201451-2-hemant.agrawal@nxp.com> <20251106112911.0c50107b@phoenix> In-Reply-To: <20251106112911.0c50107b@phoenix> From: Maxime Leroy Date: Fri, 7 Nov 2025 10:51:31 +0100 X-Gm-Features: AWmQ_bm__hLfi56Cez46NQYRDr2Bo_tUeEclA3hyVwHkxJt2bfdnNSSZzLtvSnc Message-ID: Subject: Re: [PATCH 2/3] net/dpaa2: clear active VDQ state when freeing Rx queues To: stephen@networkplumber.org Cc: Hemant Agrawal , dev@dpdk.org, jun.yang@nxp.com, stable@dpdk.org Content-Type: multipart/alternative; boundary="000000000000f768eb0642fe2062" X-Mailman-Approved-At: Sat, 08 Nov 2025 13:59:34 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000f768eb0642fe2062 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeu. 6 nov. 2025, 20:29, Stephen Hemminger a =C3=A9crit : > On Thu, 6 Nov 2025 22:08:06 +0530 > Hemant Agrawal wrote: > > > +static void > > +dpaa2_clear_queue_active_dps(struct dpaa2_queue *q, int num_lcores) > > +{ > > + int i; > > + > > + for (i =3D 0; i < num_lcores; i++) { > > + struct queue_storage_info_t *qs =3D q->q_storage[i]; > > + > > + if (!qs) > > + continue; > > + > > + if (qs->active_dqs) { > > + clear_swp_active_dqs(qs->active_dpio_id); > > + qs->active_dqs =3D NULL; > > + } > > + } > > +} > > + > > Why not use RTE_LCORE_FOREACH() here? > For the loop, I did it the same way as in dpaa2_queue_storage_alloc(), to stay aligned with the rest of the driver instead of using RTE_LCORE_FOREACH(). Thanks Hemant for upstreaming my patch. However, you added my email in .mailmap as a new entry =E2=80=94 it should instead be added as a second em= ail under the existing Maxime Leroy entry. > --000000000000f768eb0642fe2062 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Le jeu. 6 nov. 2025, 20:29, Step= hen Hemminger <stephen@net= workplumber.org> a =C3=A9crit=C2=A0:
On Thu,=C2=A0 6 Nov 2025 22:08:06 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> +static void
> +dpaa2_clear_queue_active_dps(struct dpaa2_queue *q, int num_lcores) > +{
> +=C2=A0 =C2=A0 =C2=A0int i;
> +
> +=C2=A0 =C2=A0 =C2=A0for (i =3D 0; i < num_lcores; i++) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct queue_storage_= info_t *qs =3D q->q_storage[i];
> +
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!qs)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0continue;
> +
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (qs->active_dqs= ) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0clear_swp_active_dqs(qs->active_dpio_id);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0qs->active_dqs =3D NULL;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +=C2=A0 =C2=A0 =C2=A0}
> +}
> +

Why not use RTE_LCORE_FOREACH() here?

For the loop, I did it the same way a= s in dpaa2_queue_storage_alloc(), to stay aligned with the rest of the driv= er instead of using RTE_LCORE_FOREACH().

<= div dir=3D"auto">Thanks Hemant for upstreaming my patch. However, you added= my email in .mailmap as a new entry =E2=80=94 it should instead be added a= s a second email under the existing Maxime Leroy entry.
--000000000000f768eb0642fe2062--