From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC763A04A2; Thu, 3 Mar 2022 02:57:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D74740141; Thu, 3 Mar 2022 02:57:21 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 8BD2B40041 for ; Thu, 3 Mar 2022 02:57:20 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id bx5so3396443pjb.3 for ; Wed, 02 Mar 2022 17:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gi3yQlDIKfTp50U6p3U+x51ueb1AlDMFgMRYNBmEkdY=; b=aAZs3bXkDJGGunnorlMCUkKqolzV1PiN5ZgJCBZSQbWLZkEj+7rUPjhB0B63zl8QUO 5IE4Xt/RvX8cs4qfxBE4TOh/HkQowWVKjCVjl28xoEdwLgK4dP3H32vTyg9bDw4qUETe dzKvY+PgcpwiPa9zdcGYrUMi6Pb0xx4keHm4QUYAyZy79vLDarl2ZWTDAXgW06IlfQrR sLHKv9MPSHAHVZdYHsiihV12eR5PigFzgxPLO1ln3jbdXx2ognFqenZSn4ZejBPgh0ol IScnXw0fTfX2C7gY/BaLKZOpjz0eqFbby7d5llOKGypS7DECvZ++J3YxcO6rVALr8MIu Yb0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gi3yQlDIKfTp50U6p3U+x51ueb1AlDMFgMRYNBmEkdY=; b=4rbddrqnfitJJx/qu76qA+DF3tnq8e7vCydDJhCbaVDP7ayfT7FWze7MpTlYc92ihm N3fUcRqy3wtsbnzlib0w0Vcr0n8HcGRnXiaiicz8/uTpdFXgppwY83KEIP4OR3HmJXEE WcaOWWbvQMa4BaX5r+Vrld/qykvYF49HDZEafEqt0IAMV9rWseEOebjebj9SQjk3Z+Po S2Vfq5g1ZKenJbTUZJ4PF39MInVrwc/uuoJFdYfRxump11HhKz7s4QS6GhFNs1AHUtNS RyQqepBf28lhaugTo8xJBWzSOutZI/5BUATZh0h55lZXacUXcwvqYI00bX20o4EtNEYf kmgA== X-Gm-Message-State: AOAM532LuZ8Y/8bPTFr4ZUfqv8yrrMz9b7fwB9wxqf09zbtVPBGrVAuf POAS/oGSxDsCs+x9N4/7TAnYB6bCbrJgAULgEHc= X-Google-Smtp-Source: ABdhPJwOJksAw1/rKhvPuPjR22YZqnPnibL2ssvx3ImelFc8rGBDDEK0TzNa48szdkQTEWWmP68H0e5r/cGfbGDnl40= X-Received: by 2002:a17:90a:8c14:b0:1be:e874:1cbb with SMTP id a20-20020a17090a8c1400b001bee8741cbbmr2797618pjo.210.1646272639621; Wed, 02 Mar 2022 17:57:19 -0800 (PST) MIME-Version: 1.0 References: <20220302123400.188209-1-baymaxhuang@gmail.com> In-Reply-To: From: Harold Huang Date: Thu, 3 Mar 2022 09:57:08 +0800 Message-ID: Subject: Re: [PATCH] net/kni: initialize rte_kni_conf to 0 before using it To: Ferruh Yigit Cc: dev@dpdk.org, Liron Himi Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 3, 2022 at 2:16 AM Ferruh Yigit wrote: > > On 3/2/2022 12:33 PM, Harold Huang wrote: > > When kni driver calls eth_kni_start to start device, some fields such as > > min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause > > kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu > > value. This is unexpected and in some time we could not change the kni > > device mtu with ip link command. > > > > Agree on the problem and the solution, thanks for the fix. > > > Fixes: ff1e35fb5f8 ("kni: calculate MTU from mbuf size") > > Signed-off-by: Harold Huang > > --- > > drivers/net/kni/rte_eth_kni.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c > > index c428caf441..23b15edfac 100644 > > --- a/drivers/net/kni/rte_eth_kni.c > > +++ b/drivers/net/kni/rte_eth_kni.c > > @@ -128,6 +128,7 @@ eth_kni_start(struct rte_eth_dev *dev) > > const char *name = dev->device->name + 4; /* remove net_ */ > > > > mb_pool = internals->rx_queues[0].mb_pool; > > + memset(&conf, 0, sizeof(conf)); > > Can you prefer initialize to zero, instead of 'memset', I think it > is more clear that way: Thanks. Sounds good, fix it. > > - struct rte_kni_conf conf; > + struct rte_kni_conf conf = { 0 }; > > > strlcpy(conf.name, name, RTE_KNI_NAMESIZE); > > conf.force_bind = 0; > > conf.group_id = port_id; >