DPDK patches and discussions
 help / color / mirror / Atom feed
From: "santhosh K.S" <santhoshachar08@gmail.com>
To: rami.rosen@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Accessing "device_id" from "rte_pci_device"
Date: Wed, 25 Jul 2018 15:58:20 +0530	[thread overview]
Message-ID: <CAHJickZVQDd1ODkhLcqi3sxjSaqoiVk0SHbw3LOo0RxdFGSHSA@mail.gmail.com> (raw)
In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F967337C28@HASMSX110.ger.corp.intel.com>

Hi  Rami Rosen, et al,

Thanks for the response. Yes I can see in the code that rte_device struct
is part of rte_eth_dev_info. I tried to apply the patch you pointed o
<http://patchwork.dpdk.org/patch/37654/>n 17.11.3. But it failed at many
places. We don't want to migrate to 18.05 as it is not a stable release.
I've been asked to migrate to a stable version only. I also noticed from
the release note
<https://doc.dpdk.org/guides-18.05/rel_notes/release_18_05.html> that
*rte_ctrlmbuf_init()
API *is deprecated in 18.05. Which results in breaking our code, which
means more re-work; which we are trying our best to avoid at this point in
time. Hence We are not interested in migrating to 18.05. Can you please
suggest a safer alternative patch, which I can use to get around this
problem?

Best Regards,
Santhosh K S

On Wed, Jul 25, 2018 at 12:11 PM Rosen, Rami <rami.rosen@intel.com> wrote:

> Hi Santhos.
>
>
>
> >There is no member named "*device*" in "*rte_eth_dev_info*" struct. I
> looked at both 17.11 API documentation
> <http://doc.dpdk.org/api-17.11/structrte__eth__dev__info.html> and 18.05
> API documentation
> <http://doc.dpdk.org/api-18.05/structrte__eth__dev__info.html>.
>
>
>
> This is not accurate. There is no “device” in rte_eth_dev_info
>
> In 17.11, but there is a “device” in rte_eth_dev_info
>
>   in 18.05  (this is exactly what Ferru pathc did)
>
> See for example:
>
> http://doc.dpdk.org/api-18.05/rte__ethdev_8h_source.html
>
>
>
> and look for the first member of rte_eth_dev_info:
>
>
>
> truct rte_eth_dev_info
> <http://doc.dpdk.org/api-18.05/structrte__eth__dev__info.html> {
>
> 1055  struct rte_device
> <http://doc.dpdk.org/api-18.05/structrte__device.html> *device;
>
>
>
> (Or download 18.05 and look in the header file)
>
>
>
> It seems that the 18.05 API documentation
> <http://doc.dpdk.org/api-18.05/structrte__eth__dev__info.html> is not
> complete,
>
> should be fixed.
>
>
>
> Regards,
>
> Rami Rosen
>
> Intel Corporation
>
>
>

  reply	other threads:[~2018-07-25 10:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 10:09 santhosh K.S
2018-07-24 19:22 ` Rosen, Rami
     [not found]   ` <CAHJickaT+gCoJ_O=jjwfyr8Hnm3PF60zt7fWpfChOm6p0yvhjg@mail.gmail.com>
     [not found]     ` <CAHJickYNGDAe=pNBhdqNykns0NUD6k0xjTvjTx0sKQLVaVnWyA@mail.gmail.com>
2018-07-25  6:40       ` Rosen, Rami
2018-07-25 10:28         ` santhosh K.S [this message]
2018-07-25 11:21           ` Rosen, Rami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHJickZVQDd1ODkhLcqi3sxjSaqoiVk0SHbw3LOo0RxdFGSHSA@mail.gmail.com \
    --to=santhoshachar08@gmail.com \
    --cc=dev@dpdk.org \
    --cc=rami.rosen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).