From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by dpdk.org (Postfix) with ESMTP id 4F20F27D for ; Mon, 25 Feb 2019 07:22:49 +0100 (CET) Received: by mail-ed1-f65.google.com with SMTP id d9so6517613edh.12 for ; Sun, 24 Feb 2019 22:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6YXRlgV90xg5jD5K5OzMKoS8ZmLfHRcDUIpLHGqcOLQ=; b=FhUvmnVbV3JPpiJKm2Ta1Yo1/AzX2K0cuIYQHYqY8v5bcX4zH1ha7BuBJMRZIhw+Cd mT/cLlgxPhPNXukX8S8ZqaZdj1bXSjZugX6S137DFSuC6LXply4EGn9kZVtXzZ6wVEVa snQiYKbZLMmiKWXEscUcG2YjyoBMUDKfRU4RNYITRiQ2EtoE1gCZM7P2zTNiRGKq17LC HK8BkcayWXdAc+HPqnkF9IDiLse2CPbuJ2fZ0M2GInXMPIY785ozpaG6QbjegP5UD/bi LVJsw2+sfQRTvlMxQ38ljH56BS9nwm2WR/Xs2a8T6tqIVzhqDVNx/thgX8+92VlSAST3 J9PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6YXRlgV90xg5jD5K5OzMKoS8ZmLfHRcDUIpLHGqcOLQ=; b=gJg2cjnFEn9ZCKCQDEeDPCr+2bjtxHXPki/a1rNSbvF0p+OzvDfCLr6eI5VRr9PH6a vwIikDCQ3yHzitohEEWmy8YibQpEl0nFF7QX8JKyTO+luyVdYc86G5YHdkKnS+CUP3Gj qLDJdHuscIIUobeSqWZ+FBk1j6GetAPaK5EeYj7jnEbKK1aUXhiE2Q2rSuINcIyGeozk XqJ9e9ZSq/91IbLoIutsFEgjn2verGjVgSF4NY03RoX5J0n/xWjqycUAMFEMif/J3Ogh f28wf3Rdp/tCX30BbwqtunPOKuA5YCrPHFbdUFHvSGz7AOZ3dHnqRyPmpskQ4CGhRP/B YnDg== X-Gm-Message-State: AHQUAuYr2PDjZD5Jvg+fg6ohLQJK5og+bU/3LpdTFx8uAA+hjk5apSug 2lHJCaFnplQVWrZzUuchUubfSonXOhaqtt2hgR8= X-Google-Smtp-Source: AHgI3Ia91+F9yYzP/fFp1pzciYPLK1orB1Vlf8lFlAJFH/9rsXhYC/CEtyZi83H1IcLMno7qFj0Mh5XRYpmHgIcMiyE= X-Received: by 2002:a17:906:51cd:: with SMTP id v13mr11554605ejk.71.1551075768592; Sun, 24 Feb 2019 22:22:48 -0800 (PST) MIME-Version: 1.0 References: <20190224224201.26224-1-thomas@monjalon.net> In-Reply-To: <20190224224201.26224-1-thomas@monjalon.net> From: Rami Rosen Date: Mon, 25 Feb 2019 08:22:37 +0200 Message-ID: To: Thomas Monjalon Cc: Pablo De Lara Guarch , dev , tomaszx.jozwiak@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 06:22:49 -0000 Checked on Fedora 28 Reviewed-by: Rami Rosen On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon wrote: > The call to strlcpy uses either libc, libbsd or internal rte_strlcpy. > No need to call the DPDK flavor explictly. > > Signed-off-by: Thomas Monjalon > --- > app/test-compress-perf/comp_perf_options_parse.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-compress-perf/comp_perf_options_parse.c > b/app/test-compress-perf/comp_perf_options_parse.c > index 66eb81fc59..d2b208de35 100644 > --- a/app/test-compress-perf/comp_perf_options_parse.c > +++ b/app/test-compress-perf/comp_perf_options_parse.c > @@ -373,7 +373,7 @@ parse_driver_name(struct comp_test_data *test_data, > const char *arg) > if (strlen(arg) > (sizeof(test_data->driver_name) - 1)) > return -1; > > - rte_strlcpy(test_data->driver_name, arg, > + strlcpy(test_data->driver_name, arg, > sizeof(test_data->driver_name)); > > return 0; > @@ -385,7 +385,7 @@ parse_test_file(struct comp_test_data *test_data, > const char *arg) > if (strlen(arg) > (sizeof(test_data->input_file) - 1)) > return -1; > > - rte_strlcpy(test_data->input_file, arg, > sizeof(test_data->input_file)); > + strlcpy(test_data->input_file, arg, sizeof(test_data->input_file)); > > return 0; > } > -- > 2.20.1 > > -- regards, Rami Rosen