From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 3E95F1B485; Mon, 22 Apr 2019 09:14:48 +0200 (CEST) Received: by mail-ed1-f66.google.com with SMTP id a6so8816784edv.1; Mon, 22 Apr 2019 00:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y23dja1ExWAJDT7iDIhRbErGuzu0p2H4bL3BTVvfjCc=; b=dSubjDtuxiYmCSMwMnCVHaeL9f5ZyQv76l6pF3E2l5TLoVqWo0U4cD9HIAETyeQGzJ S0ZoXGdOdizOyW92TT0hfbrnkg4ef/b4e/GYNHM4qtJIA1VuKib8uWk/MgNveJvkDx6C 4NZp4fcGD0ZKHqHRVsTgN3AUu/3ULWk847A3M2CLclN/GwN3HgW0C5u8wd77f/YM3s/f hJSwoKatReKgIunI9q4pKh09R87/RznRy9iIRSAkPw7fCAogJLY5SplcdcLehJelbIS1 RNU04goKGqWvnE8ueRR8cLTY4fwNwQU0y7j8G04hcPhVKxLXZI5xllK1sN5eiXkNmKMq PtzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y23dja1ExWAJDT7iDIhRbErGuzu0p2H4bL3BTVvfjCc=; b=iqyQwTmMpdMUacm686HCHRG7M1ycSCtXmstpd9eLKckuJ7M2cnQzTgUP27tngtdPpm jHaTxCQLvPCFdL86enRc6gb01S7Ev52ZDh/T3siOdLHdtMt1GeOdUnUn+iXYY2SXwxwV 2rV0bHE9BCJ2zB6AvbZa8QzU/BDaKVNdKeKHRkY7LJ2+xLjiY852sARzvvh2F2x7sWkQ 6dV65HR6PFiSnViJ1sLvvEDJeri0gL7KNheDQ6mg0MJb1iRXWPuKGYtgi3KO9rguhf5q jSdn5u67zTVp69lk4J1A/GO9epyT+8X8FtHbPn2B8EntbMQLCgK7dD9Jv/xlEhLw+MZD llOg== X-Gm-Message-State: APjAAAWVTLYCacf4raMLqkE7wur3ydtt3aFnv2EUbEbyQwxsCCpNXKDH AUulLf56T0HiQ20SfNNLAJt1P23TSPF2kY9LqEI= X-Google-Smtp-Source: APXvYqzv2vTd66q99da4dY+LXva+WQGeAlV/p8cgG3JkJO4926xfuf6+xYY85TjWh2W20e9Qx/6k3oXP74GoKZ7kykg= X-Received: by 2002:a17:906:1344:: with SMTP id x4mr8920938ejb.29.1555917287840; Mon, 22 Apr 2019 00:14:47 -0700 (PDT) MIME-Version: 1.0 References: <1555551081-29524-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: From: Rami Rosen Date: Mon, 22 Apr 2019 10:14:36 +0300 Message-ID: To: "Yang, Qiming" Cc: "Lu, Wenzhuo" , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix coverity issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 07:14:48 -0000 Fix the issues reported by Coverity check, "Null-checking vsi suggests that it may be null, but it has already been dereferenced on all paths leading to the check." Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") Fixes: ff963bfa7cb1 ("net/ice: support RSS") Cc: stable@dpdk.org Signed-off-by: Wenzhuo Lu --- Reviewed-by: Rami Rosen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 004DBA05D3 for ; Mon, 22 Apr 2019 09:14:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 903C71B4A5; Mon, 22 Apr 2019 09:14:49 +0200 (CEST) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 3E95F1B485; Mon, 22 Apr 2019 09:14:48 +0200 (CEST) Received: by mail-ed1-f66.google.com with SMTP id a6so8816784edv.1; Mon, 22 Apr 2019 00:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y23dja1ExWAJDT7iDIhRbErGuzu0p2H4bL3BTVvfjCc=; b=dSubjDtuxiYmCSMwMnCVHaeL9f5ZyQv76l6pF3E2l5TLoVqWo0U4cD9HIAETyeQGzJ S0ZoXGdOdizOyW92TT0hfbrnkg4ef/b4e/GYNHM4qtJIA1VuKib8uWk/MgNveJvkDx6C 4NZp4fcGD0ZKHqHRVsTgN3AUu/3ULWk847A3M2CLclN/GwN3HgW0C5u8wd77f/YM3s/f hJSwoKatReKgIunI9q4pKh09R87/RznRy9iIRSAkPw7fCAogJLY5SplcdcLehJelbIS1 RNU04goKGqWvnE8ueRR8cLTY4fwNwQU0y7j8G04hcPhVKxLXZI5xllK1sN5eiXkNmKMq PtzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y23dja1ExWAJDT7iDIhRbErGuzu0p2H4bL3BTVvfjCc=; b=iqyQwTmMpdMUacm686HCHRG7M1ycSCtXmstpd9eLKckuJ7M2cnQzTgUP27tngtdPpm jHaTxCQLvPCFdL86enRc6gb01S7Ev52ZDh/T3siOdLHdtMt1GeOdUnUn+iXYY2SXwxwV 2rV0bHE9BCJ2zB6AvbZa8QzU/BDaKVNdKeKHRkY7LJ2+xLjiY852sARzvvh2F2x7sWkQ 6dV65HR6PFiSnViJ1sLvvEDJeri0gL7KNheDQ6mg0MJb1iRXWPuKGYtgi3KO9rguhf5q jSdn5u67zTVp69lk4J1A/GO9epyT+8X8FtHbPn2B8EntbMQLCgK7dD9Jv/xlEhLw+MZD llOg== X-Gm-Message-State: APjAAAWVTLYCacf4raMLqkE7wur3ydtt3aFnv2EUbEbyQwxsCCpNXKDH AUulLf56T0HiQ20SfNNLAJt1P23TSPF2kY9LqEI= X-Google-Smtp-Source: APXvYqzv2vTd66q99da4dY+LXva+WQGeAlV/p8cgG3JkJO4926xfuf6+xYY85TjWh2W20e9Qx/6k3oXP74GoKZ7kykg= X-Received: by 2002:a17:906:1344:: with SMTP id x4mr8920938ejb.29.1555917287840; Mon, 22 Apr 2019 00:14:47 -0700 (PDT) MIME-Version: 1.0 References: <1555551081-29524-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: From: Rami Rosen Date: Mon, 22 Apr 2019 10:14:36 +0300 Message-ID: To: "Yang, Qiming" Cc: "Lu, Wenzhuo" , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix coverity issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422071436.-tCj0aP8t3tEf9n9TN84CCPrvSGKvUMsGH2Z2ZOS-lw@z> Fix the issues reported by Coverity check, "Null-checking vsi suggests that it may be null, but it has already been dereferenced on all paths leading to the check." Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") Fixes: ff963bfa7cb1 ("net/ice: support RSS") Cc: stable@dpdk.org Signed-off-by: Wenzhuo Lu --- Reviewed-by: Rami Rosen